Skip to content

[GR-60343] Add change tracking for AdaptiveCollectionPolicy. #10310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2024
Merged

[GR-60343] Add change tracking for AdaptiveCollectionPolicy. #10310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f7307
Add change tracking for AdaptiveCollectionPolicy.
peter-hofer Dec 5, 2024
305e44d
Adopt JDK-8319713: avoid conservative full GC after successful young GC.
peter-hofer Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions ...le.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/AdaptiveCollectionPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

import com.oracle.svm.core.Uninterruptible;
import com.oracle.svm.core.heap.GCCause;
import com.oracle.svm.core.util.BasedOnJDKFile;
import com.oracle.svm.core.util.TimeUtils;
import com.oracle.svm.core.util.UnsignedUtils;

Expand All @@ -42,6 +43,13 @@
* its base class {@code AdaptiveSizePolicy}. Method and variable names have been kept mostly the
* same for comparability.
*/
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/shared/adaptiveSizePolicy.hpp")
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp")
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.hpp")
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp")
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/parallel/psParallelCompact.cpp#L951-L1174")
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/parallel/psScavenge.cpp#L321-L639")
@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-25+1/src/hotspot/share/gc/shared/gc_globals.hpp#L308-L420")
class AdaptiveCollectionPolicy extends AbstractCollectionPolicy {

/*
Expand Down Expand Up @@ -152,7 +160,7 @@ public String getName() {
}

@Override
public boolean shouldCollectCompletely(boolean followingIncrementalCollection) { // should_{attempt_scavenge,full_GC}
public boolean shouldCollectCompletely(boolean followingIncrementalCollection) { // should_attempt_scavenge
guaranteeSizeParametersInitialized();

if (!followingIncrementalCollection && shouldCollectYoungGenSeparately(!SerialGCOptions.useCompactingOldGen())) {
Expand Down Expand Up @@ -182,17 +190,7 @@ public boolean shouldCollectCompletely(boolean followingIncrementalCollection) {
return true;
}

UnsignedWord youngUsed = HeapImpl.getHeapImpl().getYoungGeneration().getChunkBytes();
UnsignedWord oldUsed = HeapImpl.getHeapImpl().getOldGeneration().getChunkBytes();

/*
* If the remaining free space in the old generation is less than what is expected to be
* needed by the next collection, do a full collection now.
*/
UnsignedWord averagePromoted = UnsignedUtils.fromDouble(avgPromoted.getPaddedAverage());
UnsignedWord promotionEstimate = UnsignedUtils.min(averagePromoted, youngUsed);
UnsignedWord oldFree = oldSize.subtract(oldUsed);
return promotionEstimate.aboveThan(oldFree);
return false;
}

private void updateAverages(boolean isSurvivorOverflow, UnsignedWord survivedChunkBytes, UnsignedWord promotedChunkBytes) {
Expand Down