[GR-31342] Implemented node object inlining, lock free specialization and other features for Truffle DSL.

PullRequest: graal/12538

Author: chumer

compiler/src/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/SimplifyingGraphDecoder.java

@@ -44,6 +44,7 @@
 import org.graalvm.compiler.nodes.extended.AnchoringNode;
 import org.graalvm.compiler.nodes.extended.GuardingNode;
 import org.graalvm.compiler.nodes.extended.IntegerSwitchNode;
+import org.graalvm.compiler.nodes.extended.UnsafeAccessNode;
 import org.graalvm.compiler.nodes.java.ArrayLengthNode;
 import org.graalvm.compiler.nodes.java.LoadFieldNode;
 import org.graalvm.compiler.nodes.java.LoadIndexedNode;
@@ -202,9 +203,18 @@ protected void handleFixedNode(MethodScope methodScope, LoopScope loopScope, int
      * canonicalized (and therefore be a non-fixed node).
      *
      * @param methodScope The current method.
-     * @param node The node to be canonicalized.
+     * @param originalNode The node to be canonicalized.
      */
-    protected Node canonicalizeFixedNode(MethodScope methodScope, Node node) {
+    protected Node canonicalizeFixedNode(MethodScope methodScope, Node originalNode) {
+        Node node = originalNode;
+        if (originalNode instanceof UnsafeAccessNode) {
+            /*
+             * Ensure that raw stores and loads are eventually transformed to fields to make node
+             * plugins trigger for them reliably during PE.
+             */
+            node = ((UnsafeAccessNode) node).canonical(canonicalizerTool);
+        }
+
         /*
          * Duplicate cases for frequent classes (LoadFieldNode, LoadIndexedNode and ArrayLengthNode)
          * to improve performance (Haeubl, 2017).

compiler/src/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java

@@ -1466,9 +1466,10 @@ private static void deleteInvoke(Invoke invoke) {
 
     @SuppressWarnings("try")
     @Override
-    protected Node canonicalizeFixedNode(MethodScope s, Node node) {
+    protected Node canonicalizeFixedNode(MethodScope s, Node originalNode) {
         PEMethodScope methodScope = (PEMethodScope) s;
 
+        Node node = originalNode;
         Node replacedNode = node;
         if (nodePlugins != null && nodePlugins.length > 0) {
             if (node instanceof LoadFieldNode) {

compiler/src/org.graalvm.compiler.truffle.compiler.hotspot/src/org/graalvm/compiler/truffle/compiler/hotspot/HotSpotTruffleGraphBuilderPlugins.java

@@ -43,6 +43,9 @@
 
 final class HotSpotTruffleGraphBuilderPlugins {
 
+    /**
+     * Installed for runtime compilation using partial evaluation.
+     */
     static void registerCompilationFinalReferencePlugins(InvocationPlugins plugins, boolean canDelayIntrinsification, HotSpotKnownTruffleTypes types) {
         InvocationPlugins.Registration r = new InvocationPlugins.Registration(plugins, Reference.class);
         r.register(new RequiredInvocationPlugin("get", InvocationPlugin.Receiver.class) {
@@ -85,6 +88,7 @@ public boolean apply(GraphBuilderContext b, ResolvedJavaMethod targetMethod, Rec
                 return true;
             }
         });
+
     }
 
 }

compiler/src/org.graalvm.compiler.truffle.runtime/src/org/graalvm/compiler/truffle/runtime/GraalTruffleRuntime.java

@@ -94,6 +94,7 @@
 import com.oracle.truffle.api.TruffleOptions;
 import com.oracle.truffle.api.TruffleRuntime;
 import com.oracle.truffle.api.TruffleSafepoint;
+import com.oracle.truffle.api.dsl.InlineSupport;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.FrameDescriptor;
 import com.oracle.truffle.api.frame.FrameInstance;
@@ -402,6 +403,17 @@ private static UnmodifiableEconomicMap<String, Class<?>> initLookupTypes(Iterabl
                         TruffleString.class,
                         AbstractTruffleString.class,
                         Buffer.class,
+                        InlineSupport.InlinableField.class,
+                        InlineSupport.StateField.class,
+                        InlineSupport.BooleanField.class,
+                        InlineSupport.ByteField.class,
+                        InlineSupport.ShortField.class,
+                        InlineSupport.IntField.class,
+                        InlineSupport.CharField.class,
+                        InlineSupport.FloatField.class,
+                        InlineSupport.LongField.class,
+                        InlineSupport.DoubleField.class,
+                        InlineSupport.ReferenceField.class,
         }) {
             m.put(c.getName(), c);
         }

compiler/src/org.graalvm.compiler.truffle.test/src/org/graalvm/compiler/truffle/test/CachedLibraryCompilationTest.java

@@ -45,6 +45,7 @@
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.nodes.RootNode;
 
+@SuppressWarnings("truffle-inlining")
 public class CachedLibraryCompilationTest extends PartialEvaluationTest {
 
     private Context context;

compiler/src/org.graalvm.compiler.truffle.test/src/org/graalvm/compiler/truffle/test/ContextLookupCompilationTest.java

@@ -45,6 +45,7 @@
 import org.graalvm.word.LocationIdentity;
 import org.junit.Assert;
 import org.junit.Assume;
+import org.junit.Ignore;
 import org.junit.Test;
 
 import com.oracle.truffle.api.CompilerAsserts;
@@ -153,6 +154,7 @@ public String getName() {
     }
 
     @Test
+    @Ignore("GR-43475") // fails transiently
     public void testContextThreadLocalRead() throws Throwable {
         Engine engine = Engine.create();
         Context c = createContext(engine, SHARED1);

compiler/src/org.graalvm.compiler.truffle.test/src/org/graalvm/compiler/truffle/test/GR35581Test.java

@@ -102,6 +102,7 @@ protected Object runUnderASTLock() {
         }
 
         @Specialization
+        @SuppressWarnings("truffle-neverdefault")
         Object doIt(@Cached("runUnderASTLock()") Object cacheValue) {
             return cacheValue;
         }