[GR-45479] Fix IndexOutOfBoundsException when reading the result of RegExp match.

PullRequest: graal/14342

Author: jirkamarsik

regex/src/com.oracle.truffle.regex.test/src/com/oracle/truffle/regex/tregex/test/JsTests.java

@@ -227,4 +227,12 @@ public void quantifierOverflow() {
         test(String.format("x{%d,}", max + 1), "", "x", 0, false);
         expectSyntaxError(String.format("x{%d,%d}", max + 1, max), "", JsErrorMessages.QUANTIFIER_OUT_OF_ORDER);
     }
+
+    @Test
+    public void gr45479() {
+        // minimized test case
+        test("\\s*(p$)?", "", "px", 0, true, 0, 0, -1, -1);
+        // original test case
+        test("^(\\d{1,2})[:.,;\\-]?(\\d{1,2})?[:.,;\\-]?(\\d{1,2})?[:.,;\\-]?(\\d{1,3})?[:.,;\\-]?\\s*([ap](?=[m]|^\\w|$))?", "i", "08:00:00.000 PDT", 0, true, 0, 13, 0, 2, 3, 5, 6, 8, 9, 12, -1, -1);
+    }
 }

regex/src/com.oracle.truffle.regex/src/com/oracle/truffle/regex/tregex/dfa/DFAGenerator.java

@@ -438,7 +438,7 @@ private void expandState(DFAStateNodeBuilder state) {
             if (isGenericCG()) {
                 transition.getTarget().incPredecessors();
             }
-            if (state.isUnAnchoredFinalState() && !successorState.isFinalState()) {
+            if (state.isUnAnchoredFinalState() && !successorState.isUnAnchoredFinalState()) {
                 simpleCGMustCopy = true;
             }
         }

regex/src/com.oracle.truffle.regex/src/com/oracle/truffle/regex/tregex/nodes/TRegexExecNode.java

@@ -217,12 +217,13 @@ private boolean nfaProducesSameResult(VirtualFrame frame, TruffleString input, i
             return true;
         }
         assert !(runnerNode instanceof NFARegexSearchNode);
-        RegexResult btResult = regressionTestRun(frame, nfaNode, input, fromIndex);
-        if (resultsEqual(result, btResult, getNumberOfCaptureGroups())) {
+        RegexResult nfaResult = regressionTestRun(frame, nfaNode, input, fromIndex);
+        if (resultsEqual(result, nfaResult, getNumberOfCaptureGroups())) {
             return true;
         }
         Loggers.LOG_INTERNAL_ERRORS.severe(
-                        () -> String.format("Regex: %s\nInput: %s\nfromIndex: %d\nNFA executor Result: %s\nDFA Result:         %s", getSource().toStringEscaped(), input, fromIndex, btResult, result));
+                        () -> String.format("Regex: %s\nInput: %s\nfromIndex: %d\nNFA executor Result: %s\nDFA Result:         %s", getSource().toStringEscaped(), input, fromIndex, nfaResult,
+                                        result));
         return false;
     }