Skip to content

Commit cf1ef9d

Browse files
[GR-32046] Fix microservice benchmark heap settings.
PullRequest: graal/9148
2 parents de4c232 + ca1ec62 commit cf1ef9d

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

compiler/ci_common/benchmark-suites.libsonnet

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -162,17 +162,17 @@
162162
},
163163

164164
// Microservice benchmarks
165-
microservice_benchmarks: cc.compiler_benchmark + c.heap.default + {
165+
microservice_benchmarks: cc.compiler_benchmark + {
166166
suite:: "microservices",
167167
packages+: {
168168
"python3": "==3.6.5",
169169
"pip:psutil": "==5.8.0"
170170
},
171171
local upload = ["bench-uploader.py", "bench-results.json"],
172172
run+: [
173-
self.benchmark_cmd + ["shopcart-jmeter:large", "--"] + self.extra_vm_args,
173+
self.benchmark_cmd + ["shopcart-jmeter:large", "--"] + self.extra_vm_args + ["-Xms8g", "-Xmx8g"],
174174
upload,
175-
self.benchmark_cmd + ["petclinic-jmeter:tiny", "--"] + self.extra_vm_args,
175+
self.benchmark_cmd + ["petclinic-jmeter:tiny", "--"] + self.extra_vm_args + ["-Xms8g", "-Xmx8g"],
176176
upload,
177177
self.benchmark_cmd + ["shopcart-wrk:mixed-tiny", "--"] + self.extra_vm_args + ["-Xms32m", "-Xmx112m", "-XX:ActiveProcessorCount=1", "-XX:MaxDirectMemorySize=256m"],
178178
upload,
@@ -196,15 +196,15 @@
196196
upload,
197197
self.benchmark_cmd + ["tika-wrk:pdf-medium", "--"] + self.extra_vm_args + ["-Xms80m", "-Xmx500m", "-XX:ActiveProcessorCount=4"],
198198
upload,
199-
self.benchmark_cmd + ["petclinic-wrk:mixed-tiny", "--"] + self.extra_vm_args + ["-Xms32m", "-Xmx100m", "-XX:ActiveProcessorCount=1"],
199+
self.benchmark_cmd + ["petclinic-wrk:mixed-tiny", "--"] + self.extra_vm_args + ["-Xms32m", "-Xmx100m", "-XX:ActiveProcessorCount=1"],
200200
upload,
201-
self.benchmark_cmd + ["petclinic-wrk:mixed-small", "--"] + self.extra_vm_args + ["-Xms40m", "-Xmx128m", "-XX:ActiveProcessorCount=2"],
201+
self.benchmark_cmd + ["petclinic-wrk:mixed-small", "--"] + self.extra_vm_args + ["-Xms40m", "-Xmx128m", "-XX:ActiveProcessorCount=2"],
202202
upload,
203-
self.benchmark_cmd + ["petclinic-wrk:mixed-medium", "--"] + self.extra_vm_args + ["-Xms80m", "-Xmx256m", "-XX:ActiveProcessorCount=4"],
203+
self.benchmark_cmd + ["petclinic-wrk:mixed-medium", "--"] + self.extra_vm_args + ["-Xms80m", "-Xmx256m", "-XX:ActiveProcessorCount=4"],
204204
upload,
205-
self.benchmark_cmd + ["petclinic-wrk:mixed-large", "--"] + self.extra_vm_args + ["-Xms320m", "-Xmx1280m", "-XX:ActiveProcessorCount=16"],
205+
self.benchmark_cmd + ["petclinic-wrk:mixed-large", "--"] + self.extra_vm_args + ["-Xms320m", "-Xmx1280m", "-XX:ActiveProcessorCount=16"],
206206
upload,
207-
self.benchmark_cmd + ["petclinic-wrk:mixed-huge", "--"] + self.extra_vm_args + ["-Xms640m", "-Xmx3072m", "-XX:ActiveProcessorCount=32"],
207+
self.benchmark_cmd + ["petclinic-wrk:mixed-huge", "--"] + self.extra_vm_args + ["-Xms640m", "-Xmx3072m", "-XX:ActiveProcessorCount=32"],
208208
upload
209209
],
210210
timelimit: "7:00:00"

compiler/ci_common/compiler-common.libsonnet

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@
2626
},
2727
plain_benchmark_cmd:: ["mx", "--kill-with-sigquit", "benchmark", "--fork-count-file=${FORK_COUNT_FILE}", "--extras=${BENCH_SERVER_EXTRAS}", "--results-file", "${BENCH_RESULTS_FILE_PATH}", "--machine-name=${MACHINE_NAME}", "--tracker=rss"],
2828
benchmark_cmd:: bench_common.hwlocIfNuma(self.should_use_hwloc, self.plain_benchmark_cmd, node=self.default_numa_node),
29-
extra_vm_args:: ["--profiler=${MX_PROFILER}", "--jvm=${JVM}", "--jvm-config=${JVM_CONFIG}", "-Xmx${XMX}", "-Xms${XMS}", "-XX:+PrintConcurrentLocks", "-Dgraal.CompilationFailureAction=Diagnose"],
29+
min_heap_size:: if std.objectHasAll(self.environment, 'XMS') then ["-Xms${XMS}"] else [],
30+
max_heap_size:: if std.objectHasAll(self.environment, 'XMX') then ["-Xmx${XMX}"] else [],
31+
extra_vm_args:: ["--profiler=${MX_PROFILER}", "--jvm=${JVM}", "--jvm-config=${JVM_CONFIG}", "-XX:+PrintConcurrentLocks", "-Dgraal.CompilationFailureAction=Diagnose"] + self.min_heap_size + self.max_heap_size,
3032
should_mx_build:: true,
3133
setup+: [
3234
["cd", "./" + config.compiler.compiler_suite],

0 commit comments

Comments
 (0)