[GR-45992] Let msgs of ImplicitExceptions match HotSpot again.

PullRequest: graal/14506

Author: fniephaus

substratevm/src/com.oracle.svm.core/.checkstyle_checks.xml

@@ -71,6 +71,12 @@
       <property name="message" value="Exception and error messages must not start with a lowercase letter"/>
       <property name="ignoreComments" value="true"/>
     </module>
+    <module name="SuppressionCommentFilter">
+      <property name="offCommentFormat" value="Checkstyle: allow inconsistent exceptions and errors"/>
+      <property name="onCommentFormat" value="Checkstyle: disallow inconsistent exceptions and errors"/>
+      <property name="idFormat" value="exceptionsAndErrors"/>
+      <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Tolerate inconsistent exceptions and errors"/>
+    </module>
 
     <module name="RegexpSinglelineJava">
       <property name="id" value="newLinesFormatStrings"/>

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/snippets/ImplicitExceptions.java

@@ -234,20 +234,24 @@ private static ArithmeticException createDivisionByZeroException() {
         return new ArithmeticException("/ by zero");
     }
 
+    // Checkstyle: allow inconsistent exceptions and errors
+
     /** Foreign call: {@link #CREATE_INTEGER_OVERFLOW_EXCEPTION}. */
     @SubstrateForeignCallTarget(stubCallingConvention = true)
     private static ArithmeticException createIntegerOverflowException() {
         vmErrorIfImplicitExceptionsAreFatal();
-        return new ArithmeticException("Integer overflow");
+        return new ArithmeticException("integer overflow");
     }
 
     /** Foreign call: {@link #CREATE_LONG_OVERFLOW_EXCEPTION}. */
     @SubstrateForeignCallTarget(stubCallingConvention = true)
     private static ArithmeticException createLongOverflowException() {
         vmErrorIfImplicitExceptionsAreFatal();
-        return new ArithmeticException("Long overflow");
+        return new ArithmeticException("long overflow");
     }
 
+    // Checkstyle: disallow inconsistent exceptions and errors
+
     /** Foreign call: {@link #CREATE_ASSERTION_ERROR_NULLARY}. */
     @SubstrateForeignCallTarget(stubCallingConvention = true)
     private static AssertionError createAssertionErrorNullary() {
@@ -354,20 +358,24 @@ private static void throwNewDivisionByZeroException() {
         throw new ArithmeticException("/ by zero");
     }
 
+    // Checkstyle: allow inconsistent exceptions and errors
+
     /** Foreign call: {@link #THROW_NEW_INTEGER_OVERFLOW_EXCEPTION}. */
     @SubstrateForeignCallTarget(stubCallingConvention = true)
     private static void throwNewIntegerOverflowException() {
         vmErrorIfImplicitExceptionsAreFatal();
-        throw new ArithmeticException("Integer overflow");
+        throw new ArithmeticException("integer overflow");
     }
 
     /** Foreign call: {@link #THROW_NEW_LONG_OVERFLOW_EXCEPTION}. */
     @SubstrateForeignCallTarget(stubCallingConvention = true)
     private static void throwNewLongOverflowException() {
         vmErrorIfImplicitExceptionsAreFatal();
-        throw new ArithmeticException("Long overflow");
+        throw new ArithmeticException("long overflow");
     }
 
+    // Checkstyle: disallow inconsistent exceptions and errors
+
     /** Foreign call: {@link #THROW_NEW_ASSERTION_ERROR_NULLARY}. */
     @SubstrateForeignCallTarget(stubCallingConvention = true)
     private static void throwNewAssertionErrorNullary() {