Skip to content

Commit bec64ec

Browse files
committed
Refactor comments.
1 parent 1a848dc commit bec64ec

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/flow/MethodTypeFlowBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -627,11 +627,11 @@ protected void apply(boolean forceReparse, Object reason) {
627627
*/
628628
AnalysisType returnType = TypeFlow.filterUncheckedInterface(method.getSignature().getReturnType());
629629
if (returnType.getJavaKind().isObject()) {
630-
// TODO the return type state should not be all-instantiated, it should be the
631-
// persisted result of the open-world analysis [GR-52421]
630+
// GR-52421: the return type state should not be all-instantiated, it should be the
631+
// persisted result of the open-world analysis
632632
insertAllInstantiatedTypesReturn();
633633
}
634-
// TODO verify that tracked parameter state is subset of persisted state [GR-52421]
634+
// GR-52421: verify that tracked parameter state is subset of persisted state
635635
insertPlaceholderParamAndReturnFlows();
636636
return;
637637
}

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/image/LIRNativeImageCodeCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ public void patchMethods(DebugContext debug, RelocatableBuffer relocs, ObjectFil
358358
HostedImageHeapConstantPatch patch = (HostedImageHeapConstantPatch) codeAnnotation;
359359

360360
if (patch.constant instanceof ImageHeapConstant hc && hc.isInBaseLayer()) {
361-
// TODO use object offset in base layer heap [GR-52911]
361+
// GR-52911: use object offset in base layer heap
362362
continue;
363363
}
364364
ObjectInfo objectInfo = imageHeap.getConstantInfo(patch.constant);

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/image/NativeImageCodeCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ public void writeConstants(NativeImageHeapWriter writer, RelocatableBuffer buffe
683683
ByteBuffer bb = buffer.getByteBuffer();
684684
dataSection.buildDataSection(bb, (position, constant) -> {
685685
if (constant instanceof ImageHeapConstant hc && hc.isInBaseLayer()) {
686-
// TODO use object offset in base layer heap [GR-52911]
686+
// GR-52911: use object offset in base layer heap
687687
return;
688688
}
689689
writer.writeReference(buffer, position, (JavaConstant) constant, "VMConstant: " + constant);

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/image/NativeImageHeapWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ private void writeField(RelocatableBuffer buffer, ObjectInfo fields, HostedField
156156
addNonDataRelocation(buffer, index, prepareRelocatable(info, value));
157157
} else {
158158
if (value instanceof ImageHeapConstant hc && hc.isInBaseLayer()) {
159-
// TODO use object offset in base layer heap [GR-52911]
159+
// GR-52911: use object offset in base layer heap
160160
return;
161161
}
162162
write(buffer, index, value, info != null ? info : field);
@@ -205,7 +205,7 @@ private void writeConstant(RelocatableBuffer buffer, int index, JavaKind kind, J
205205
con = constant;
206206
}
207207
if (con instanceof ImageHeapConstant hc && hc.isInBaseLayer()) {
208-
// TODO use object offset in base layer heap [GR-52911]
208+
// GR-52911: use object offset in base layer heap
209209
return;
210210
}
211211
write(buffer, index, con, info);

0 commit comments

Comments
 (0)