Use HashMap instead of List ClassEntry.methods

Author: zakkak

substratevm/src/com.oracle.objectfile/src/com/oracle/objectfile/debugentry/ClassEntry.java

@@ -59,7 +59,7 @@ public class ClassEntry extends StructureTypeEntry {
     /**
      * Details of methods located in this instance.
      */
-    protected List<MethodEntry> methods;
+    protected Map<String, MethodEntry> methods;
     /**
      * A list recording details of all primary ranges included in this class sorted by ascending
      * address range.
@@ -94,7 +94,7 @@ public ClassEntry(String className, FileEntry fileEntry, int size) {
         super(className, size);
         this.interfaces = new LinkedList<>();
         this.fileEntry = fileEntry;
-        this.methods = new LinkedList<>();
+        this.methods = new HashMap<>();
         this.primaryEntries = new LinkedList<>();
         this.primaryIndex = new HashMap<>();
         this.localFiles = new LinkedList<>();
@@ -295,7 +295,8 @@ protected MethodEntry processMethod(DebugMethodInfo debugMethodInfo, DebugInfoBa
          */
         FileEntry methodFileEntry = debugInfoBase.ensureFileEntry(fileName, filePath, cachePath);
         final MethodEntry methodEntry = new MethodEntry(methodFileEntry, methodName, this, resultType, paramTypeArray, paramNameArray, modifiers, debugMethodInfo.isDeoptTarget());
-        methods.add(methodEntry);
+        String key = methodName + debugMethodInfo.paramSignature() + resultTypeName;
+        methods.put(key, methodEntry);
         return methodEntry;
     }
 
@@ -350,12 +351,10 @@ public MethodEntry ensureMethodEntry(DebugMethodInfo debugMethodInfo, DebugInfoB
         String methodName = debugInfoBase.uniqueDebugString(debugMethodInfo.name());
         String paramSignature = debugMethodInfo.paramSignature();
         String returnTypeName = debugMethodInfo.valueType();
-        // TODO improve data structure to avoid loops...
-        for (MethodEntry methodEntry : methods) {
-            if (methodEntry.match(methodName, paramSignature, returnTypeName)) {
-                return methodEntry;
-            }
+        MethodEntry methodEntry = methods.get(methodName + paramSignature + returnTypeName);
+        if (methodEntry == null) {
+            methodEntry = processMethod(debugMethodInfo, debugInfoBase, debugContext);
         }
-        return processMethod(debugMethodInfo, debugInfoBase, debugContext);
+        return methodEntry;
     }
 }