[GR-17828] [GR-21998] Prevent repeated initialization built-in net library.

PullRequest: graal/5861

Author: peter-hofer

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/code/DeoptimizationSourcePositionEncoder.java

@@ -48,36 +48,36 @@ public DeoptimizationSourcePositionEncoder() {
         this.objectConstants = FrequencyEncoder.createIdentityEncoder();
     }
 
-    public void encodeAndInstall(List<NodeSourcePosition> deoptimzationSourcePositions, CodeInfo target) {
-        addObjectConstants(deoptimzationSourcePositions);
+    public void encodeAndInstall(List<NodeSourcePosition> deoptSourcePositions, CodeInfo target, ReferenceAdjuster adjuster) {
+        addObjectConstants(deoptSourcePositions);
         Object[] encodedObjectConstants = objectConstants.encodeAll(new Object[objectConstants.getLength()]);
 
         UnsafeArrayTypeWriter encodingBuffer = UnsafeArrayTypeWriter.create(ByteArrayReader.supportsUnalignedMemoryAccess());
         EconomicMap<NodeSourcePosition, Long> sourcePositionStartOffsets = EconomicMap.create(Equivalence.IDENTITY_WITH_SYSTEM_HASHCODE);
-        NonmovableArray<Integer> deoptimizationStartOffsets = NonmovableArrays.createIntArray(deoptimzationSourcePositions.size());
+        NonmovableArray<Integer> deoptStartOffsets = NonmovableArrays.createIntArray(deoptSourcePositions.size());
 
-        encodeSourcePositions(deoptimzationSourcePositions, sourcePositionStartOffsets, deoptimizationStartOffsets, encodingBuffer);
-        NonmovableArray<Byte> deoptimizationEncodings = NonmovableArrays.createByteArray(TypeConversion.asS4(encodingBuffer.getBytesWritten()));
-        encodingBuffer.toByteBuffer(NonmovableArrays.asByteBuffer(deoptimizationEncodings));
+        encodeSourcePositions(deoptSourcePositions, sourcePositionStartOffsets, deoptStartOffsets, encodingBuffer);
+        NonmovableArray<Byte> deoptEncodings = NonmovableArrays.createByteArray(TypeConversion.asS4(encodingBuffer.getBytesWritten()));
+        encodingBuffer.toByteBuffer(NonmovableArrays.asByteBuffer(deoptEncodings));
 
-        install(target, deoptimizationStartOffsets, deoptimizationEncodings, encodedObjectConstants, deoptimzationSourcePositions);
+        install(target, deoptStartOffsets, deoptEncodings, encodedObjectConstants, deoptSourcePositions, adjuster);
     }
 
     @Uninterruptible(reason = "Nonmovable object arrays are not visible to GC until installed in target.")
-    private static void install(CodeInfo target, NonmovableArray<Integer> deoptimizationStartOffsets, NonmovableArray<Byte> deoptimizationEncodings,
-                    Object[] encodedObjectConstants, List<NodeSourcePosition> deoptimizationSourcePositions) {
+    private static void install(CodeInfo target, NonmovableArray<Integer> deoptStartOffsets, NonmovableArray<Byte> deoptEncodings,
+                    Object[] encodedObjectConstants, List<NodeSourcePosition> deoptSourcePositions, ReferenceAdjuster adjuster) {
 
-        NonmovableObjectArray<Object> deoptimizationObjectConstants = NonmovableArrays.copyOfObjectArray(encodedObjectConstants);
-        RuntimeCodeInfoAccess.setDeoptimizationMetadata(target, deoptimizationStartOffsets, deoptimizationEncodings, deoptimizationObjectConstants);
+        NonmovableObjectArray<Object> deoptObjectConstants = adjuster.copyOfObjectArray(encodedObjectConstants);
+        RuntimeCodeInfoAccess.setDeoptimizationMetadata(target, deoptStartOffsets, deoptEncodings, deoptObjectConstants);
 
-        afterInstallation(deoptimizationStartOffsets, deoptimizationEncodings, deoptimizationSourcePositions, deoptimizationObjectConstants);
+        afterInstallation(deoptStartOffsets, deoptEncodings, deoptSourcePositions, deoptObjectConstants, adjuster);
     }
 
     @Uninterruptible(reason = "Safe for GC, but called from uninterruptible code.", calleeMustBe = false)
-    private static void afterInstallation(NonmovableArray<Integer> deoptimizationStartOffsets, NonmovableArray<Byte> deoptimizationEncodings,
-                    List<NodeSourcePosition> deoptimizationSourcePositions, NonmovableObjectArray<Object> deoptimizationObjectConstants) {
+    private static void afterInstallation(NonmovableArray<Integer> deoptStartOffsets, NonmovableArray<Byte> deoptEncodings,
+                    List<NodeSourcePosition> deoptSourcePositions, NonmovableObjectArray<Object> deoptObjectConstants, ReferenceAdjuster adjuster) {
 
-        verifyEncoding(deoptimizationSourcePositions, deoptimizationStartOffsets, deoptimizationEncodings, deoptimizationObjectConstants);
+        assert !adjuster.isFinished() || verifyEncoding(deoptSourcePositions, deoptStartOffsets, deoptEncodings, deoptObjectConstants);
     }
 
     private void addObjectConstants(List<NodeSourcePosition> deoptimzationSourcePositions) {
@@ -97,18 +97,18 @@ private void addObjectConstants(NodeSourcePosition sourcePosition, EconomicSet<N
         processedPositions.add(sourcePosition);
     }
 
-    private void encodeSourcePositions(List<NodeSourcePosition> deoptimzationSourcePositions, EconomicMap<NodeSourcePosition, Long> sourcePositionStartOffsets,
-                    NonmovableArray<Integer> deoptimizationStartOffsets, UnsafeArrayTypeWriter encodingBuffer) {
-        for (int i = 0; i < deoptimzationSourcePositions.size(); i++) {
-            NodeSourcePosition sourcePosition = deoptimzationSourcePositions.get(i);
+    private void encodeSourcePositions(List<NodeSourcePosition> deoptSourcePositions, EconomicMap<NodeSourcePosition, Long> sourcePositionStartOffsets,
+                    NonmovableArray<Integer> deoptStartOffsets, UnsafeArrayTypeWriter encodingBuffer) {
+        for (int i = 0; i < deoptSourcePositions.size(); i++) {
+            NodeSourcePosition sourcePosition = deoptSourcePositions.get(i);
             int startOffset;
             if (sourcePosition == null) {
                 startOffset = DeoptimizationSourcePositionDecoder.NO_SOURCE_POSITION;
             } else {
                 startOffset = TypeConversion.asS4(encodeSourcePositions(sourcePosition, sourcePositionStartOffsets, encodingBuffer));
                 assert startOffset > DeoptimizationSourcePositionDecoder.NO_SOURCE_POSITION;
             }
-            NonmovableArrays.setInt(deoptimizationStartOffsets, i, startOffset);
+            NonmovableArrays.setInt(deoptStartOffsets, i, startOffset);
         }
     }
 
@@ -139,11 +139,12 @@ private long encodeSourcePositions(NodeSourcePosition sourcePosition, EconomicMa
         return startAbsoluteOffset;
     }
 
-    private static boolean verifyEncoding(List<NodeSourcePosition> deoptimzationSourcePositions, NonmovableArray<Integer> deoptimizationStartOffsets,
-                    NonmovableArray<Byte> deoptimizationEncodings, NonmovableObjectArray<Object> deoptimizationObjectConstants) {
-        for (int i = 0; i < deoptimzationSourcePositions.size(); i++) {
-            NodeSourcePosition originalSourcePosition = deoptimzationSourcePositions.get(i);
-            NodeSourcePosition decodedSourcePosition = DeoptimizationSourcePositionDecoder.decode(i, deoptimizationStartOffsets, deoptimizationEncodings, deoptimizationObjectConstants);
+    private static boolean verifyEncoding(List<NodeSourcePosition> deoptSourcePositions, NonmovableArray<Integer> deoptStartOffsets,
+                    NonmovableArray<Byte> deoptEncodings, NonmovableObjectArray<Object> deoptObjectConstants) {
+
+        for (int i = 0; i < deoptSourcePositions.size(); i++) {
+            NodeSourcePosition originalSourcePosition = deoptSourcePositions.get(i);
+            NodeSourcePosition decodedSourcePosition = DeoptimizationSourcePositionDecoder.decode(i, deoptStartOffsets, deoptEncodings, deoptObjectConstants);
 
             verifySourcePosition(originalSourcePosition, decodedSourcePosition);
         }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/NativeLibrarySupport.java

@@ -141,7 +141,7 @@ private boolean loadLibrary0(File file, boolean asBuiltin) {
         return addLibrary(asBuiltin, canonical, true);
     }
 
-    private boolean addLibrary(boolean asBuiltin, String canonical, boolean loadAndInitialize) {
+    private boolean addLibrary(boolean asBuiltin, String canonical, boolean initialize) {
         lock.lock();
         try {
             NativeLibrary lib = null;
@@ -171,19 +171,22 @@ private boolean addLibrary(boolean asBuiltin, String canonical, boolean loadAndI
                 lib = PlatformNativeLibrarySupport.singleton().createLibrary(canonical, asBuiltin);
                 created = true;
             }
-            if (loadAndInitialize) {
-                currentLoadContext.push(lib);
-                try {
-                    if (!lib.load()) {
-                        return false;
-                    }
-                    if (libraryInitializer != null) {
-                        libraryInitializer.initialize(lib);
-                    }
-                } finally {
-                    NativeLibrary top = currentLoadContext.pop();
-                    assert top == lib;
+            currentLoadContext.push(lib);
+            try {
+                if (!lib.load()) {
+                    return false;
+                }
+                /*
+                 * Initialization of a library must be skipped if it can be initialized at most once
+                 * per process and another isolate has already initialized it. However, the library
+                 * must be (marked as) loaded above so it cannot be loaded and initialized later.
+                 */
+                if (initialize && libraryInitializer != null) {
+                    libraryInitializer.initialize(lib);
                 }
+            } finally {
+                NativeLibrary top = currentLoadContext.pop();
+                assert top == lib;
             }
             if (created) {
                 knownLibraries.add(lib);
@@ -210,6 +213,7 @@ public PointerBase findSymbol(String name) {
     }
 
     public void registerInitializedBuiltinLibrary(String name) {
-        addLibrary(true, name, false);
+        boolean success = addLibrary(true, name, false);
+        assert success;
     }
 }

substratevm/src/com.oracle.svm.graal/src/com/oracle/svm/graal/meta/RuntimeCodeInstaller.java

@@ -328,7 +328,7 @@ private void createCodeChunkInfos(CodeInfo runtimeMethodInfo, ReferenceAdjuster
         assert !adjuster.isFinished() || codeInfoEncoder.verifyFrameInfo(runtimeMethodInfo);
 
         DeoptimizationSourcePositionEncoder sourcePositionEncoder = new DeoptimizationSourcePositionEncoder();
-        sourcePositionEncoder.encodeAndInstall(compilation.getDeoptimizationSourcePositions(), runtimeMethodInfo);
+        sourcePositionEncoder.encodeAndInstall(compilation.getDeoptimizationSourcePositions(), runtimeMethodInfo, adjuster);
     }
 
     private void patchData(Map<Integer, NativeImagePatcher> patcher, @SuppressWarnings("unused") ObjectConstantsHolder objectConstants) {