Skip to content

Commit 64d0a26

Browse files
committed
fix README
1 parent e7686c6 commit 64d0a26

File tree

1 file changed

+6
-5
lines changed
  • substratevm/src/com.oracle.svm.native.libcontainer

1 file changed

+6
-5
lines changed

substratevm/src/com.oracle.svm.native.libcontainer/README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,19 @@ the OpenJDK, it should be updated regularly to profit from upstream fixes and im
3232
track of this, `ContainerLibrary.java` contains `@BasedOnJDKFile` annotations for each imported file,
3333
which links to the source version in the JDK. With this information, all upstream changes can be
3434
detected. Note that strictly speaking, the referenced version in the annotation does not necessarily
35-
mean that the file was imported, but rather that all changes have been reviewed. If there are changes
36-
that are irrelevant for `libsvm_container`, we might keep the file as is and still bump the version.
37-
That said, we plan to do full reimports regularly, at least once every for every release.
35+
mean that the file was imported from that revision. Rather that all changes have been reviewed. If
36+
there are changes that are irrelevant for `libsvm_container`, we might keep the file as is and still
37+
bump the version. That said, we plan to do full reimports regularly, at least once every for every
38+
release.
3839

3940
To help keeping the `@BasedOnJDKFile` annotations up to date, the
4041
`mx gate --tags check_libcontainer_annotations` command ensures that the actual files and
4142
annotations are in sync.
4243

4344
To do a full reimport, replace the files in [`src/hotspot`](./src/hotspot) with those from the OpenJDK.
4445
The `mx reimport-libcontainer-files --jdk-repo path/to/jdk` can help with that. Then reapply all the
45-
changes (`#ifdef` guards) using the diff tool of your choice. Finally, adopt the files in
46-
[`src/svm`](./src/svm) to provide new functionality, if needed. Finally, the `@BasedOnJDKFile`
46+
changes (`#ifdef` guards) using the diff tool of your choice. Then, adopt the files in
47+
[`src/svm`](./src/svm) to provide new functionality, if needed. Finally, update the `@BasedOnJDKFile`
4748
annotations in `ContainerLibrary.java` to reflect the import revision.
4849

4950
## Local Testing

0 commit comments

Comments
 (0)