[GR-36107] Fix boolean to signed value cast

PullRequest: graal/10952

Author: rudihorn

sulong/projects/com.oracle.truffle.llvm.runtime/src/com/oracle/truffle/llvm/runtime/nodes/cast/LLVMToDoubleNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, 2021, Oracle and/or its affiliates.
+ * Copyright (c) 2016, 2022, Oracle and/or its affiliates.
  *
  * All rights reserved.
  *
@@ -118,7 +118,7 @@ protected LLVMToDoubleNode createRecursive() {
 
         @Specialization
         protected double doDouble(boolean from) {
-            return from ? 1.0 : 0.0;
+            return from ? -1.0 : 0.0;
         }
 
         @Specialization

sulong/projects/com.oracle.truffle.llvm.runtime/src/com/oracle/truffle/llvm/runtime/nodes/cast/LLVMToFloatNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, 2021, Oracle and/or its affiliates.
+ * Copyright (c) 2016, 2022, Oracle and/or its affiliates.
  *
  * All rights reserved.
  *
@@ -116,7 +116,7 @@ protected LLVMToFloatNode createRecursive() {
 
         @Specialization
         protected float doFloat(boolean from) {
-            return from ? 1.0f : 0.0f;
+            return from ? -1.0f : 0.0f;
         }
 
         @Specialization

sulong/projects/com.oracle.truffle.llvm.runtime/src/com/oracle/truffle/llvm/runtime/nodes/cast/LLVMToVectorNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2021, Oracle and/or its affiliates.
+ * Copyright (c) 2017, 2022, Oracle and/or its affiliates.
  *
  * All rights reserved.
  *
@@ -148,7 +148,7 @@ protected LLVMI8Vector doI1(LLVMI1Vector from) {
             assert from.getLength() == getVectorLength();
             final byte[] vector = new byte[getVectorLength()];
             for (int i = 0; i < getVectorLength(); i++) {
-                vector[i] = (byte) (from.getValue(i) ? 0xff : 0);
+                vector[i] = (byte) (from.getValue(i) ? -1 : 0);
             }
             return LLVMI8Vector.create(vector);
         }
@@ -223,7 +223,7 @@ protected LLVMI16Vector doI1(LLVMI1Vector from) {
             assert from.getLength() == getVectorLength();
             final short[] vector = new short[getVectorLength()];
             for (int i = 0; i < getVectorLength(); i++) {
-                vector[i] = (short) (from.getValue(i) ? 1 : 0);
+                vector[i] = (short) (from.getValue(i) ? -1 : 0);
             }
             return LLVMI16Vector.create(vector);
         }
@@ -298,7 +298,7 @@ protected LLVMI32Vector doI1(LLVMI1Vector from) {
             assert from.getLength() == getVectorLength();
             final int[] vector = new int[getVectorLength()];
             for (int i = 0; i < getVectorLength(); i++) {
-                vector[i] = from.getValue(i) ? 1 : 0;
+                vector[i] = from.getValue(i) ? -1 : 0;
             }
             return LLVMI32Vector.create(vector);
         }
@@ -373,7 +373,7 @@ protected LLVMI64Vector doI1(LLVMI1Vector from) {
             assert from.getLength() == getVectorLength();
             final long[] vector = new long[getVectorLength()];
             for (int i = 0; i < getVectorLength(); i++) {
-                vector[i] = from.getValue(i) ? 1 : 0;
+                vector[i] = from.getValue(i) ? -1 : 0;
             }
             return LLVMI64Vector.create(vector);
         }
@@ -460,7 +460,7 @@ protected LLVMFloatVector doI1(LLVMI1Vector from) {
             assert from.getLength() == getVectorLength();
             final float[] vector = new float[getVectorLength()];
             for (int i = 0; i < getVectorLength(); i++) {
-                vector[i] = from.getValue(i) ? 1 : 0;
+                vector[i] = from.getValue(i) ? -1 : 0;
             }
             return LLVMFloatVector.create(vector);
         }
@@ -535,7 +535,7 @@ protected LLVMDoubleVector doI1(LLVMI1Vector from) {
             assert from.getLength() == getVectorLength();
             final double[] vector = new double[getVectorLength()];
             for (int i = 0; i < getVectorLength(); i++) {
-                vector[i] = from.getValue(i) ? 1 : 0;
+                vector[i] = from.getValue(i) ? -1 : 0;
             }
             return LLVMDoubleVector.create(vector);
         }

sulong/tests/com.oracle.truffle.llvm.tests.bitcode.native/bitcode/vector_double_sitofp.ll

@@ -0,0 +1,14 @@
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+@.str = private unnamed_addr constant [8 x i8] c"%lf,%lf\00"
+
+define i32 @main() #0 {
+  %1 = sitofp <4 x i1> <i1 0, i1 -1, i1 0, i1 -1> to <4 x double>
+  %2 = extractelement <4 x double> %1, i64 0
+  %3 = extractelement <4 x double> %1, i64 1
+  %4 = call i32 (i8*, ...) @printf(i8* nonnull dereferenceable(1) getelementptr inbounds ([8 x i8], [8 x i8]* @.str, i64 0, i64 0), double %2, double %3)
+  ret i32 0
+}
+
+declare i32 @printf(i8* nocapture readonly, ...) #1

sulong/tests/com.oracle.truffle.llvm.tests.sulong.Os.native/Os/vector-bool-sext.c

@@ -0,0 +1,40 @@
+/*
+ * Copyright (c) 2022, Oracle and/or its affiliates.
+ *
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without modification, are
+ * permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this list of
+ * conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright notice, this list of
+ * conditions and the following disclaimer in the documentation and/or other materials provided
+ * with the distribution.
+ *
+ * 3. Neither the name of the copyright holder nor the names of its contributors may be used to
+ * endorse or promote products derived from this software without specific prior written
+ * permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS
+ * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
+ * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+
+int a[4] = { 0, 1, 0, 1 };
+int main() {
+    int v[4];
+    for (int i = 0; i < 4; i++)
+        v[i] = -(a[i] > 0);
+    printf("%d,%d", v[0], v[1]);
+    return 0;
+}

sulong/tests/com.oracle.truffle.llvm.tests.sulong.Os.native/Os/vector-bool-sitofp.c

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2022, Oracle and/or its affiliates.
+ *
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without modification, are
+ * permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this list of
+ * conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright notice, this list of
+ * conditions and the following disclaimer in the documentation and/or other materials provided
+ * with the distribution.
+ *
+ * 3. Neither the name of the copyright holder nor the names of its contributors may be used to
+ * endorse or promote products derived from this software without specific prior written
+ * permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS
+ * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
+ * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+int32_t a[4] = { 0, 1, 0, 1 };
+int main() {
+    float v[4];
+    for (int i = 0; i < 4; i++)
+        v[i] = -(a[i] > 0);
+    printf("%f,%f\n", v[0], v[1]);
+    double w[4];
+    for (int i = 0; i < 4; i++)
+        w[i] = -(a[i] > 0);
+    printf("%lf,%lf", w[0], w[1]);
+    return 0;
+}

sulong/tests/com.oracle.truffle.llvm.tests.sulong.native/c/cast/bool-sitofp.c

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2022, Oracle and/or its affiliates.
+ *
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without modification, are
+ * permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this list of
+ * conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright notice, this list of
+ * conditions and the following disclaimer in the documentation and/or other materials provided
+ * with the distribution.
+ *
+ * 3. Neither the name of the copyright holder nor the names of its contributors may be used to
+ * endorse or promote products derived from this software without specific prior written
+ * permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS
+ * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
+ * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+
+int a;
+int b = 1;
+
+float sitofp(int i) {
+    return -(i > 0);
+}
+
+double sitolfp(int i) {
+    return -(i > 0);
+}
+
+int main() {
+    printf("%f,%f\n", sitofp(a), sitofp(b));
+    printf("%lf,%lf", sitolfp(a), sitolfp(b));
+    return 0;
+}