Implement more JVMTI features.

Author: dprcci

substratevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/GCImpl.java

@@ -29,6 +29,7 @@
 
 import java.lang.ref.Reference;
 
+import com.oracle.svm.core.jvmti.JvmtiPostEvents;
 import org.graalvm.nativeimage.CurrentIsolate;
 import org.graalvm.nativeimage.IsolateThread;
 import org.graalvm.nativeimage.Platform;
@@ -169,6 +170,8 @@ public void collectionHint(boolean fullGC) {
 
     private void collect(GCCause cause, boolean forceFullGC) {
         if (!hasNeverCollectPolicy()) {
+            JvmtiPostEvents.postGarbageCollectionStart();
+            JvmtiPostEvents.postGarbageCollectionFinish();
             boolean outOfMemory = collectWithoutAllocating(cause, forceFullGC);
             if (outOfMemory) {
                 throw OutOfMemoryUtil.heapSizeExceeded();

substratevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/ImageHeapWalker.java

@@ -126,7 +126,7 @@ private static boolean walkPartitionInline(Object firstObject, Object lastObject
 
     @Uninterruptible(reason = "Bridge between uninterruptible and potentially interruptible code.", mayBeInlined = true, calleeMustBe = false)
     private static boolean visitObject(ObjectVisitor visitor, Object currentObject) {
-        return visitor.visitObject(currentObject);
+        return visitor. visitObject(currentObject);
     }
 
     @Uninterruptible(reason = "Bridge between uninterruptible and potentially interruptible code.", mayBeInlined = true, calleeMustBe = false)

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateOptions.java

@@ -467,16 +467,16 @@ public static void updateMaxJavaStackTraceDepth(EconomicMap<OptionKey<?>, Object
     @Option(help = "Enable JVM Tool Interface (JVMTI) support.", type = OptionType.User)//
     public static final HostedOptionKey<Boolean> JVMTI = new HostedOptionKey<>(false);
 
-    // TEMP (chaeubl): we need to support multiple values
-    @Option(help = "Loads the specified native agent library specified by the absolute path name. " +
-                    "After the library path, a comma-separated list of options specific to the library can be used.", type = OptionType.User)//
-    public static final RuntimeOptionKey<String> AgentPath = new RuntimeOptionKey<>(null);
-
     // TEMP (chaeubl): we need to support multiple values
     @Option(help = "Loads the specified native agent library. " +
                     "After the library name, a comma-separated list of options specific to the library can be used.", type = OptionType.User)//
     public static final RuntimeOptionKey<String> AgentLib = new RuntimeOptionKey<>(null);
 
+    // TEMP (chaeubl): we need to support multiple values
+    @Option(help = "Loads the specified native agent library specified by the absolute path name. " +
+                    "After the library path, a comma-separated list of options specific to the library can be used.", type = OptionType.User)//
+    public static final RuntimeOptionKey<String> AgentPath = new RuntimeOptionKey<>(null);
+
     @Option(help = "Alignment of AOT and JIT compiled code in bytes.")//
     public static final HostedOptionKey<Integer> CodeAlignment = new HostedOptionKey<>(16);
 

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/graal/snippets/CEntryPointSnippets.java

@@ -33,6 +33,9 @@
 
 import java.util.Map;
 
+import com.oracle.svm.core.jvmti.JvmtiEnvManager;
+import com.oracle.svm.core.jvmti.JvmtiManager;
+import com.oracle.svm.core.jvmti.JvmtiPostEvents;
 import org.graalvm.nativeimage.CurrentIsolate;
 import org.graalvm.nativeimage.ImageSingletons;
 import org.graalvm.nativeimage.Isolate;
@@ -401,6 +404,9 @@ private static int initializeIsolateInterruptibly1(CEntryPointCreateIsolateParam
 
         if (SubstrateOptions.JVMTI.getValue()) {
             JvmtiAgents.singleton().load();
+
+            //JvmtiPostEvents.postVMInit();
+            JvmtiPostEvents.postVMStart();
         }
 
         assert !isolateInitialized;
@@ -639,9 +645,12 @@ private static boolean initiateTearDownIsolateInterruptibly() {
         VMThreads.singleton().threadExit();
 
         if (SubstrateOptions.JVMTI.getValue()) {
+            JvmtiPostEvents.postVMDeath();
+            JvmtiManager.freeAllJvmtiClassesUnmanagedMemory();
             JvmtiAgents.singleton().unload();
         }
 
+
         return true;
     }
 

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/headers/LibCSupport.java

@@ -34,7 +34,7 @@
 import com.oracle.svm.core.memory.NativeMemory;
 
 /** Platform-independent LibC support. Don't use this class directly, use {@link LibC} instead. */
-public interface LibCSupport {
+public  interface LibCSupport {
     @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
     int errno();
 

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/hub/DynamicHub.java

@@ -1801,6 +1801,7 @@ private ClassRepository getGenericInfo() {
         return companion.getGenericInfo(this);
     }
 
+
     ClassRepository computeGenericInfo() {
         String genericSignature = getGenericSignature0();
         if (genericSignature == null) {

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/NativeLibraries.java

@@ -68,7 +68,7 @@ protected static PointerBase findSymbol(Collection<PlatformNativeLibrarySupport.
 
     /** Returns the directory containing the native image, or {@code null}. */
     @NeverInline("Reads the return address.")
-    private static String getImageDirectory() {
+    public static String getImageDirectory() {
         /*
          * While one might expect code for shared libraries to work for executables as well, this is
          * not necessarily the case. For example, `dladdr` on Linux returns `argv[0]` for

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/UninterruptibleUtils.java

@@ -602,6 +602,21 @@ public static int modifiedUTF8Length(java.lang.String string, boolean addNullTer
             return result + (addNullTerminator ? 1 : 0);
         }
 
+        //TODO @dprcci FINISH THAT TłOMORROW
+        @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
+        public static int modifiedUTF8LengthCharArray(char[] buffer, int bufferLength, boolean addNullTerminator, CharReplacer replacer) {
+            int result = 0;
+            for (int index = 0; index < bufferLength; index++) {
+                char ch = buffer[index];
+                if (replacer != null) {
+                    ch = replacer.replace(ch);
+                }
+                result += modifiedUTF8Length(ch);
+            }
+
+            return result + (addNullTerminator ? 1 : 0);
+        }
+
         /**
          * Writes the encoded {@code string} into the given {@code buffer} using the modified UTF8
          * encoding (null characters that are present in the input will be encoded in a way that
@@ -637,6 +652,29 @@ public static Pointer toModifiedUTF8(java.lang.String string, int stringLength,
             VMError.guarantee(pos.belowOrEqual(bufferEnd), "Must not write out of bounds.");
             return pos;
         }
+
+        @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
+        public static Pointer toModifiedUTF8FromCharArray(char[] charArray, int endIndex, Pointer buffer, Pointer bufferEnd, boolean addNullTerminator) {
+            return toModifiedUTF8FromCharArray(charArray, endIndex, buffer, bufferEnd, addNullTerminator, null);
+        }
+
+        @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
+        public static Pointer toModifiedUTF8FromCharArray(char[] charArray, int endIndex, Pointer buffer, Pointer bufferEnd, boolean addNullTerminator, CharReplacer replacer) {
+            Pointer pos = buffer;
+            for (int i = 0; i < endIndex; i++) {
+                char ch = charArray[i];
+                if (replacer != null) {
+                    ch = replacer.replace(ch);
+                }
+                pos = writeModifiedUTF8(pos, ch);
+            }
+            if (addNullTerminator) {
+                pos.writeByte(0, (byte) 0);
+                pos = pos.add(1);
+            }
+            VMError.guarantee(pos.belowOrEqual(bufferEnd), "Must not write out of bounds.");
+            return pos;
+        }
     }
 
     @FunctionalInterface

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jni/access/JNIAccessibleField.java

@@ -44,7 +44,7 @@
 /**
  * Information on a field that can be looked up and accessed via JNI.
  */
-public final class JNIAccessibleField extends JNIAccessibleMember {
+public final class  JNIAccessibleField extends JNIAccessibleMember {
     /* 10000000...0 */
     private static final UnsignedWord ID_STATIC_FLAG = WordFactory.unsigned(-1L).unsignedShiftRight(1).add(1);
     /* 01000000...0 */

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jni/access/JNIAccessibleMethod.java

@@ -27,8 +27,6 @@
 import java.lang.reflect.Modifier;
 
 import org.graalvm.collections.EconomicSet;
-import jdk.graal.compiler.nodes.NamedLocationIdentity;
-import jdk.graal.compiler.word.BarrieredAccess;
 import org.graalvm.nativeimage.Platform.HOSTED_ONLY;
 import org.graalvm.nativeimage.Platforms;
 import org.graalvm.nativeimage.c.function.CodePointer;
@@ -42,6 +40,8 @@
 import com.oracle.svm.core.util.VMError;
 import com.oracle.svm.util.ReflectionUtil;
 
+import jdk.graal.compiler.nodes.NamedLocationIdentity;
+import jdk.graal.compiler.word.BarrieredAccess;
 import jdk.vm.ci.meta.MetaAccessProvider;
 import jdk.vm.ci.meta.ResolvedJavaField;
 
@@ -129,10 +129,12 @@ boolean isPublic() {
         return Modifier.isPublic(modifiers);
     }
 
-    boolean isStatic() {
-        return Modifier.isStatic(modifiers);
+    boolean isNative() {
+        return Modifier.isNative(modifiers);
     }
 
+    boolean isStatic() {return Modifier.isStatic(modifiers);}
+
     @Platforms(HOSTED_ONLY.class)
     public void finishBeforeCompilation(EconomicSet<Class<?>> hidingSubclasses, int vtableEntryOffset, CodePointer nonvirtualEntry, PointerBase newObjectEntry, CodePointer callWrapperEntry,
                     CodePointer varargs, CodePointer array, CodePointer valist, CodePointer varargsNonvirtual, CodePointer arrayNonvirtual, CodePointer valistNonvirtual) {