[GR-35961] Use String.format within GraalSubstitutions.

PullRequest: graal/10700

Author: teshull

substratevm/src/com.oracle.svm.graal/src/com/oracle/svm/graal/GraalSubstitutions.java

@@ -157,7 +157,7 @@ public Object compute(MetaAccessProvider metaAccess, ResolvedJavaField original,
                     return clearedCache;
                 }
             }
-            throw VMError.shouldNotReachHere("Cannot find " + DebugContext.class.getName() + ".Immutable");
+            throw VMError.shouldNotReachHere(String.format("Cannot find %s.Immutable", DebugContext.class.getName()));
         }
     }
 
@@ -250,7 +250,7 @@ public static EconomicMap<Class<? extends Node>, List<MatchStatement>> lookup(Cl
                     @SuppressWarnings("unused") DebugContext debug) {
         EconomicMap<Class<? extends Node>, List<MatchStatement>> result = GraalSupport.get().matchRuleRegistry.get(theClass);
         if (result == null) {
-            VMError.shouldNotReachHere("MatchRuleRegistry.lookup(): unexpected class " + theClass.getName());
+            throw VMError.shouldNotReachHere(String.format("MatchRuleRegistry.lookup(): unexpected class %s", theClass.getName()));
         }
         return result;
     }
@@ -289,7 +289,7 @@ final class Target_org_graalvm_compiler_phases_BasePhase {
     static BasePhase.BasePhaseStatistics getBasePhaseStatistics(Class<?> clazz) {
         BasePhase.BasePhaseStatistics result = GraalSupport.get().basePhaseStatistics.get(clazz);
         if (result == null) {
-            throw VMError.shouldNotReachHere("Missing statistics for phase class: " + clazz.getName() + "\n");
+            throw VMError.shouldNotReachHere(String.format("Missing statistics for phase class: %s\n", clazz.getName()));
         }
         return result;
     }
@@ -302,7 +302,7 @@ final class Target_org_graalvm_compiler_lir_phases_LIRPhase {
     static LIRPhase.LIRPhaseStatistics getLIRPhaseStatistics(Class<?> clazz) {
         LIRPhase.LIRPhaseStatistics result = GraalSupport.get().lirPhaseStatistics.get(clazz);
         if (result == null) {
-            throw VMError.shouldNotReachHere("Missing statistics for phase class: " + clazz.getName() + "\n");
+            throw VMError.shouldNotReachHere(String.format("Missing statistics for phase class: %s\n", clazz.getName()));
         }
         return result;
     }
@@ -323,7 +323,7 @@ final class Target_org_graalvm_compiler_graph_NodeClass {
     public static NodeClass<?> get(Class<?> clazz) {
         NodeClass<?> nodeClass = GraalSupport.get().nodeClasses.get(clazz);
         if (nodeClass == null) {
-            throw VMError.shouldNotReachHere("Unknown node class: " + clazz.getName() + "\n");
+            throw VMError.shouldNotReachHere(String.format("Unknown node class: %s\n", clazz.getName()));
         }
         return nodeClass;
     }
@@ -347,7 +347,7 @@ final class Target_org_graalvm_compiler_lir_LIRInstructionClass {
     public static LIRInstructionClass<?> get(Class<? extends LIRInstruction> clazz) {
         LIRInstructionClass<?> instructionClass = GraalSupport.get().instructionClasses.get(clazz);
         if (instructionClass == null) {
-            throw VMError.shouldNotReachHere("Unknown instruction class: " + clazz.getName() + "\n");
+            throw VMError.shouldNotReachHere(String.format("Unknown instruction class: %s\n", clazz.getName()));
         }
         return instructionClass;
     }
@@ -362,7 +362,7 @@ final class Target_org_graalvm_compiler_lir_CompositeValueClass {
     public static CompositeValueClass<?> get(Class<? extends CompositeValue> clazz) {
         CompositeValueClass<?> compositeValueClass = GraalSupport.get().compositeValueClasses.get(clazz);
         if (compositeValueClass == null) {
-            throw VMError.shouldNotReachHere("Unknown composite value class: " + clazz.getName() + "\n");
+            throw VMError.shouldNotReachHere(String.format("Unknown composite value class: %s\n", clazz.getName()));
         }
         return compositeValueClass;
     }