Skip to content

Commit 23647a8

Browse files
committed
[GR-32846] Update to C1Visualizer 1.10.
PullRequest: graal/10780
2 parents 59ac3ad + f9385ee commit 23647a8

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

compiler/mx.compiler/mx_graal_tools.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,11 @@ def igv(args):
8282
def c1visualizer(args):
8383
"""run the C1 Compiler Visualizer"""
8484
v8u40 = mx.VersionSpec("1.8.0_40")
85+
v12 = mx.VersionSpec("12")
8586
def _c1vJdkVersionCheck(version):
86-
return version >= v8u40 and str(version).startswith('1.8.0')
87+
return version >= v8u40 and version < v12
8788
env = dict(os.environ)
88-
env['jdkhome'] = mx.get_jdk(_c1vJdkVersionCheck, versionDescription='(1.8 JDK that is >= 1.8.0u40 )', purpose="running C1 Visualizer").home
89+
env['jdkhome'] = mx.get_jdk(_c1vJdkVersionCheck, versionDescription='(JDK that is >= 1.8.0u40 and <= 11)', purpose="running C1 Visualizer").home
8990
run_netbeans_app('C1Visualizer', env, args() if callable(args) else args)
9091

9192
def hsdis(args, copyToDir=None):

compiler/mx.compiler/suite.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@
9696
},
9797

9898
"C1VISUALIZER_DIST" : {
99-
"urls" : ["https://lafo.ssw.uni-linz.ac.at/pub/graal-external-deps/c1visualizer/c1visualizer-1.7.zip"],
100-
"sha1" : "305a772ccbdc0e42dfa233b0ce6762d0dd1de6de",
99+
"urls" : ["https://lafo.ssw.uni-linz.ac.at/pub/graal-external-deps/c1visualizer/c1visualizer-1.10.zip"],
100+
"sha1" : "548e383a732944a84456c2caf36b163b9a8db495",
101101
"packedResource": True,
102102
},
103103

compiler/src/org.graalvm.compiler.options/src/org/graalvm/compiler/options/Option.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*
3838
* @see OptionDescriptor
3939
*/
40-
@Retention(RetentionPolicy.CLASS)
40+
@Retention(RetentionPolicy.SOURCE)
4141
@Target(ElementType.FIELD)
4242
public @interface Option {
4343

java-benchmarks/mx.java-benchmarks/mx_java_benchmarks.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ def validateReturnCode(self, retcode):
591591

592592
def postprocessRunArgs(self, benchname, runArgs):
593593
parser = argparse.ArgumentParser(add_help=False)
594-
parser.add_argument("-n", default=None)
594+
parser.add_argument("-n", "--iterations", default=None)
595595
parser.add_argument("-s", "--size", default=None)
596596
args, remaining = parser.parse_known_args(runArgs)
597597

@@ -606,10 +606,10 @@ def postprocessRunArgs(self, benchname, runArgs):
606606

607607
otherArgs = ["-s", self.workloadSize()] + remaining
608608

609-
if args.n:
610-
if args.n.isdigit():
611-
return ["-n", args.n] + otherArgs
612-
if args.n == "-1":
609+
if args.iterations:
610+
if args.iterations.isdigit():
611+
return ["-n", args.iterations] + otherArgs
612+
if args.iterations == "-1":
613613
return None
614614
else:
615615
iterations = self.daCapoIterations()[benchname]
@@ -635,10 +635,10 @@ def createCommandLineArgs(self, benchmarks, bmSuiteArgs):
635635

636636
def repairDatapoints(self, benchmarks, bmSuiteArgs, partialResults):
637637
parser = argparse.ArgumentParser(add_help=False)
638-
parser.add_argument("-n", default=None)
638+
parser.add_argument("-n", "--iterations", default=None)
639639
args, _ = parser.parse_known_args(self.runArgs(bmSuiteArgs))
640-
if args.n and args.n.isdigit():
641-
iterations = int(args.n)
640+
if args.iterations and args.iterations.isdigit():
641+
iterations = int(args.iterations)
642642
else:
643643
iterations = self.daCapoIterations()[benchmarks[0]]
644644
iterations = iterations + self.getExtraIterationCount(iterations)

0 commit comments

Comments
 (0)