[GR-39689] Unexpected IOException in SourceBuilder.

PullRequest: graal/12417

Author: woess

truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/polyglot/GR39689Test.java

@@ -0,0 +1,99 @@
+/*
+ * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * The Universal Permissive License (UPL), Version 1.0
+ *
+ * Subject to the condition set forth below, permission is hereby granted to any
+ * person obtaining a copy of this software, associated documentation and/or
+ * data (collectively the "Software"), free of charge and under any and all
+ * copyright rights in the Software, and any and all patent rights owned or
+ * freely licensable by each licensor hereunder covering either (i) the
+ * unmodified Software as contributed to or provided by such licensor, or (ii)
+ * the Larger Works (as defined below), to deal in both
+ *
+ * (a) the Software, and
+ *
+ * (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
+ * one is included with the Software each a "Larger Work" to which the Software
+ * is contributed by such licensors),
+ *
+ * without restriction, including without limitation the rights to copy, create
+ * derivative works of, display, perform, and distribute the Software and make,
+ * use, sell, offer for sale, import, export, have made, and have sold the
+ * Software and the Larger Work(s), and to sublicense the foregoing rights on
+ * either these or other terms.
+ *
+ * This license is subject to the following condition:
+ *
+ * The above copyright notice and either this complete permission notice or at a
+ * minimum a reference to the UPL must be included in all copies or substantial
+ * portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.oracle.truffle.api.test.polyglot;
+
+import java.io.IOException;
+import java.nio.file.AccessMode;
+import java.nio.file.LinkOption;
+import java.nio.file.Path;
+import java.util.Set;
+
+import org.graalvm.polyglot.Context;
+import org.graalvm.polyglot.io.FileSystem;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import com.oracle.truffle.api.TruffleFile;
+import com.oracle.truffle.api.source.Source;
+import com.oracle.truffle.api.test.OSUtils;
+import com.oracle.truffle.api.test.polyglot.FileSystemsTest.ForwardingFileSystem;
+import com.oracle.truffle.tck.tests.TruffleTestAssumptions;
+
+public class GR39689Test extends AbstractPolyglotTest {
+
+    @BeforeClass
+    public static void runWithWeakEncapsulationOnly() {
+        TruffleTestAssumptions.assumeWeakEncapsulation();
+    }
+
+    public GR39689Test() {
+        needsLanguageEnv = true;
+    }
+
+    @Before
+    public void setUp() {
+        setupEnv(Context.newBuilder().allowIO(true).fileSystem(new MockExistsFileSystem()).build());
+    }
+
+    @Test
+    public void testGetCanonicalFileOfNoLongerExistingFile() {
+        TruffleFile file = languageEnv.getPublicTruffleFile(OSUtils.isUnix() ? "/non-existent/a/b" : "C:/non-existent/a/b");
+        Assert.assertTrue(file.exists());
+
+        Source.newBuilder(ProxyLanguage.ID, file).content("irrelevant").build();
+    }
+
+    private static final class MockExistsFileSystem extends ForwardingFileSystem {
+        MockExistsFileSystem() {
+            super(FileSystem.newDefaultFileSystem());
+        }
+
+        @Override
+        public void checkAccess(Path path, Set<? extends AccessMode> modes, LinkOption... linkOptions) throws IOException {
+            if (modes.isEmpty()) { // exists
+                return;
+            }
+            super.checkAccess(path, modes, linkOptions);
+        }
+    }
+}

truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/source/Source.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -52,6 +52,7 @@
 import java.net.URLConnection;
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.NoSuchFileException;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.util.Arrays;
@@ -1007,7 +1008,7 @@ static Source buildSource(String language, Object origin, String name, String pa
                 }
             } else {
                 // Canonicalize the file if it exists
-                useTruffleFile = useTruffleFile.exists() ? useTruffleFile.getCanonicalFile() : useTruffleFile;
+                useTruffleFile = getCanonicalFileIfItExists(useTruffleFile);
             }
             useFileSystemContext = SourceAccessor.LANGUAGE.getFileSystemContext(useTruffleFile);
             useName = useName == null ? useTruffleFile.getName() : useName;
@@ -1038,7 +1039,7 @@ static Source buildSource(String language, Object origin, String name, String pa
             useFileSystemContext = useFileSystemContext == null ? SourceAccessor.ACCESSOR.engineSupport().getCurrentFileSystemContext() : useFileSystemContext;
             try {
                 useTruffleFile = SourceAccessor.getTruffleFile(tmpUri, useFileSystemContext);
-                useTruffleFile = useTruffleFile.exists() ? useTruffleFile.getCanonicalFile() : useTruffleFile;
+                useTruffleFile = getCanonicalFileIfItExists(useTruffleFile);
                 if (useContent == CONTENT_UNSET) {
                     if (isCharacterBased(useFileSystemContext, language, useMimeType)) {
                         String fileMimeType = useMimeType == null ? SourceAccessor.detectMimeType(useTruffleFile, getValidMimeTypes(useFileSystemContext, language)) : useMimeType;
@@ -1102,6 +1103,18 @@ static Source buildSource(String language, Object origin, String name, String pa
         return SOURCES.intern(key);
     }
 
+    private static TruffleFile getCanonicalFileIfItExists(TruffleFile file) throws IOException {
+        if (file.exists()) {
+            try {
+                return file.getCanonicalFile();
+            } catch (NoSuchFileException ex) {
+                // The file may have been deleted between exists() and getCanonicalFile().
+                // We handle this race condition as if the file did not exist.
+            }
+        }
+        return file;
+    }
+
     static byte[] readBytes(URLConnection connection) throws IOException {
         long size = connection.getContentLengthLong();
         if (size < 0) {
@@ -1413,13 +1426,13 @@ public LiteralBuilder content(ByteSequence bytes) {
          * The MIME type can be guessed by the system based on {@link #findMimeType(TruffleFile)
          * files} or {@link #findMimeType(URL) urls}.
          *
+         * @param mimeType the new mime type to be assigned, or <code>null</code> if default MIME
+         *            type should be used.
+         * @return instance of <code>this</code> builder ready to {@link #build() create new source}
          * @see LanguageInfo#getDefaultMimeType()
          * @see LanguageInfo#getMimeTypes()
          * @see Source#findMimeType(TruffleFile)
          * @see Source#findMimeType(URL)
-         * @param mimeType the new mime type to be assigned, or <code>null</code> if default MIME
-         *            type should be used.
-         * @return instance of <code>this</code> builder ready to {@link #build() create new source}
          * @since 19.0
          */
         public SourceBuilder mimeType(@SuppressWarnings("hiding") String mimeType) {