Skip to content

Commit 14c6ad3

Browse files
committed
ConfigurationCondition.objectReachable -> ConfigurationCondition.alwaysTrue
1 parent 556b055 commit 14c6ad3

File tree

19 files changed

+45
-45
lines changed

19 files changed

+45
-45
lines changed

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeReflection.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public final class RuntimeReflection {
6969
* @since 19.0
7070
*/
7171
public static void register(Class<?>... classes) {
72-
ImageSingletons.lookup(RuntimeReflectionSupport.class).register(ConfigurationCondition.objectReachable(), classes);
72+
ImageSingletons.lookup(RuntimeReflectionSupport.class).register(ConfigurationCondition.alwaysTrue(), classes);
7373
}
7474

7575
/**
@@ -80,7 +80,7 @@ public static void register(Class<?>... classes) {
8080
* @since 19.0
8181
*/
8282
public static void register(Executable... methods) {
83-
ImageSingletons.lookup(RuntimeReflectionSupport.class).register(ConfigurationCondition.objectReachable(), methods);
83+
ImageSingletons.lookup(RuntimeReflectionSupport.class).register(ConfigurationCondition.alwaysTrue(), methods);
8484
}
8585

8686
/**
@@ -91,7 +91,7 @@ public static void register(Executable... methods) {
9191
* @since 19.0
9292
*/
9393
public static void register(Field... fields) {
94-
ImageSingletons.lookup(RuntimeReflectionSupport.class).register(ConfigurationCondition.objectReachable(), false, fields);
94+
ImageSingletons.lookup(RuntimeReflectionSupport.class).register(ConfigurationCondition.alwaysTrue(), false, fields);
9595
}
9696

9797
/**

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeSerialization.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public final class RuntimeSerialization {
6161
* @since 21.3
6262
*/
6363
public static void register(Class<?>... classes) {
64-
ImageSingletons.lookup(RuntimeSerializationSupport.class).register(ConfigurationCondition.objectReachable(), classes);
64+
ImageSingletons.lookup(RuntimeSerializationSupport.class).register(ConfigurationCondition.alwaysTrue(), classes);
6565
}
6666

6767
/**
@@ -76,7 +76,7 @@ public static void register(Class<?>... classes) {
7676
* @since 21.3
7777
*/
7878
public static void registerWithTargetConstructorClass(Class<?> clazz, Class<?> customTargetConstructorClazz) {
79-
ImageSingletons.lookup(RuntimeSerializationSupport.class).registerWithTargetConstructorClass(ConfigurationCondition.objectReachable(), clazz, customTargetConstructorClazz);
79+
ImageSingletons.lookup(RuntimeSerializationSupport.class).registerWithTargetConstructorClass(ConfigurationCondition.alwaysTrue(), clazz, customTargetConstructorClazz);
8080
}
8181

8282
private RuntimeSerialization() {

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/ConfigurationCondition.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public final class ConfigurationCondition implements Comparable<ConfigurationCon
4646
private final String typeName;
4747
private static final ConfigurationCondition OBJECT_REACHABLE = new ConfigurationCondition(Object.class.getTypeName());
4848

49-
public static ConfigurationCondition objectReachable() {
49+
public static ConfigurationCondition alwaysTrue() {
5050
return OBJECT_REACHABLE;
5151
}
5252

substratevm/src/com.oracle.svm.configure.test/src/com/oracle/svm/configure/test/config/OmitPreviousConfigTests.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ private static void doTestTypeConfig(TypeConfiguration typeConfig) {
146146
}
147147

148148
private static void doTestExpectedMissingTypes(TypeConfiguration typeConfig) {
149-
Assert.assertNull(typeConfig.get(ConfigurationCondition.objectReachable(), "FlagTestA"));
150-
Assert.assertNull(typeConfig.get(ConfigurationCondition.objectReachable(), "FlagTestB"));
149+
Assert.assertNull(typeConfig.get(ConfigurationCondition.alwaysTrue(), "FlagTestA"));
150+
Assert.assertNull(typeConfig.get(ConfigurationCondition.alwaysTrue(), "FlagTestB"));
151151
}
152152

153153
private static void doTestTypeFlags(TypeConfiguration typeConfig) {
@@ -182,7 +182,7 @@ private static void doTestMethods(TypeConfiguration typeConfig) {
182182
}
183183

184184
private static void doTestProxyConfig(ProxyConfiguration proxyConfig) {
185-
ConfigurationCondition condition = ConfigurationCondition.objectReachable();
185+
ConfigurationCondition condition = ConfigurationCondition.alwaysTrue();
186186
Assert.assertFalse(proxyConfig.contains(condition, "testProxySeenA", "testProxySeenB", "testProxySeenC"));
187187
Assert.assertTrue(proxyConfig.contains(condition, "testProxyUnseen"));
188188
}
@@ -191,19 +191,19 @@ private static void doTestResourceConfig(ResourceConfiguration resourceConfig) {
191191
Assert.assertFalse(resourceConfig.anyResourceMatches("seenResource.txt"));
192192
Assert.assertTrue(resourceConfig.anyResourceMatches("unseenResource.txt"));
193193

194-
ConfigurationCondition condition = ConfigurationCondition.objectReachable();
194+
ConfigurationCondition condition = ConfigurationCondition.alwaysTrue();
195195
Assert.assertFalse(resourceConfig.anyBundleMatches(condition, "seenBundle"));
196196
Assert.assertTrue(resourceConfig.anyBundleMatches(condition, "unseenBundle"));
197197
}
198198

199199
private static void doTestSerializationConfig(SerializationConfiguration serializationConfig) {
200-
ConfigurationCondition condition = ConfigurationCondition.objectReachable();
200+
ConfigurationCondition condition = ConfigurationCondition.alwaysTrue();
201201
Assert.assertFalse(serializationConfig.contains(condition, "seenType", null));
202202
Assert.assertTrue(serializationConfig.contains(condition, "unseenType", null));
203203
}
204204

205205
private static ConfigurationType getConfigTypeOrFail(TypeConfiguration typeConfig, String typeName) {
206-
ConfigurationType type = typeConfig.get(ConfigurationCondition.objectReachable(), typeName);
206+
ConfigurationType type = typeConfig.get(ConfigurationCondition.alwaysTrue(), typeName);
207207
Assert.assertNotNull(type);
208208
return type;
209209
}
@@ -263,11 +263,11 @@ Map<ConfigurationMethod, ConfigurationMemberKind> getMethodsMap(ConfigurationMem
263263
}
264264

265265
void populateConfig() {
266-
ConfigurationType oldType = new ConfigurationType(ConfigurationCondition.objectReachable(), getTypeName());
266+
ConfigurationType oldType = new ConfigurationType(ConfigurationCondition.alwaysTrue(), getTypeName());
267267
setFlags(oldType);
268268
previousConfig.add(oldType);
269269

270-
ConfigurationType newType = new ConfigurationType(ConfigurationCondition.objectReachable(), getTypeName());
270+
ConfigurationType newType = new ConfigurationType(ConfigurationCondition.alwaysTrue(), getTypeName());
271271
for (Map.Entry<ConfigurationMethod, ConfigurationMemberKind> methodEntry : methodsThatMustExist.entrySet()) {
272272
newType.addMethod(methodEntry.getKey().getName(), methodEntry.getKey().getInternalSignature(), methodEntry.getValue());
273273
}
@@ -298,7 +298,7 @@ String getTypeName() {
298298

299299
void doTest() {
300300
String name = getTypeName();
301-
ConfigurationType configurationType = currentConfig.get(ConfigurationCondition.objectReachable(), name);
301+
ConfigurationType configurationType = currentConfig.get(ConfigurationCondition.alwaysTrue(), name);
302302
if (methodsThatMustExist.size() == 0) {
303303
Assert.assertNull("Generated configuration type " + name + " exists. Expected it to be cleared as it is empty.", configurationType);
304304
} else {

substratevm/src/com.oracle.svm.configure.test/src/com/oracle/svm/configure/test/config/ResourceConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class ResourceConfigurationTest {
4545
@Test
4646
public void anyResourceMatches() {
4747
ResourceConfiguration rc = new ResourceConfiguration();
48-
ConfigurationCondition defaultCond = ConfigurationCondition.objectReachable();
48+
ConfigurationCondition defaultCond = ConfigurationCondition.alwaysTrue();
4949
rc.addResourcePattern(defaultCond, ".*/Resource.*txt$");
5050

5151
Assert.assertTrue(rc.anyResourceMatches("com/my/app/Resource0.txt"));
@@ -64,7 +64,7 @@ public void anyResourceMatches() {
6464
@Test
6565
public void printJson() {
6666
ResourceConfiguration rc = new ResourceConfiguration();
67-
ConfigurationCondition defaultCond = ConfigurationCondition.objectReachable();
67+
ConfigurationCondition defaultCond = ConfigurationCondition.alwaysTrue();
6868
rc.addResourcePattern(defaultCond, ".*/Resource.*txt$");
6969
rc.ignoreResourcePattern(defaultCond, ".*/Resource2.txt$");
7070
PipedWriter pw = new PipedWriter();

substratevm/src/com.oracle.svm.configure/src/com/oracle/svm/configure/config/ConfigurationConditionPrintable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
final class ConfigurationConditionPrintable {
3737
static void printConditionAttribute(ConfigurationCondition condition, JsonWriter writer) throws IOException {
38-
if (!condition.equals(ConfigurationCondition.objectReachable())) {
38+
if (!condition.equals(ConfigurationCondition.alwaysTrue())) {
3939
writer.quote(CONDITIONAL_KEY).append(":{");
4040
writer.quote(TYPE_REACHABLE_KEY).append(':').quote(condition.getTypeName());
4141
writer.append("},").newline();

substratevm/src/com.oracle.svm.configure/src/com/oracle/svm/configure/trace/JniProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public TypeConfiguration getConfiguration() {
5656
@Override
5757
@SuppressWarnings("fallthrough")
5858
void processEntry(Map<String, ?> entry) {
59-
ConfigurationCondition condition = ConfigurationCondition.objectReachable();
59+
ConfigurationCondition condition = ConfigurationCondition.alwaysTrue();
6060
boolean invalidResult = Boolean.FALSE.equals(entry.get("result"));
6161
if (invalidResult) {
6262
return;

substratevm/src/com.oracle.svm.configure/src/com/oracle/svm/configure/trace/ReflectionProcessor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public ResourceConfiguration getResourceConfiguration() {
7373
@SuppressWarnings("fallthrough")
7474
public void processEntry(Map<String, ?> entry) {
7575
boolean invalidResult = Boolean.FALSE.equals(entry.get("result"));
76-
ConfigurationCondition condition = ConfigurationCondition.objectReachable();
76+
ConfigurationCondition condition = ConfigurationCondition.alwaysTrue();
7777
if (invalidResult) {
7878
return;
7979
}
@@ -257,7 +257,7 @@ private void addFullyQualifiedDeclaredMethod(String descriptor) {
257257
String qualifiedClass = descriptor.substring(0, classend);
258258
String methodName = descriptor.substring(classend + 1, sigbegin);
259259
String signature = descriptor.substring(sigbegin);
260-
configuration.getOrCreateType(ConfigurationCondition.objectReachable(), qualifiedClass).addMethod(methodName, signature, ConfigurationMemberKind.DECLARED);
260+
configuration.getOrCreateType(ConfigurationCondition.alwaysTrue(), qualifiedClass).addMethod(methodName, signature, ConfigurationMemberKind.DECLARED);
261261
}
262262

263263
private void addDynamicProxy(List<?> interfaceList, LazyValue<String> callerClass) {
@@ -268,7 +268,7 @@ private void addDynamicProxy(List<?> interfaceList, LazyValue<String> callerClas
268268
return;
269269
}
270270
}
271-
proxyConfiguration.add(ConfigurationCondition.objectReachable(), interfaces);
271+
proxyConfiguration.add(ConfigurationCondition.alwaysTrue(), interfaces);
272272
}
273273

274274
private void addDynamicProxyUnchecked(List<?> checkedInterfaceList, List<?> uncheckedInterfaceList, LazyValue<String> callerClass) {
@@ -285,6 +285,6 @@ private void addDynamicProxyUnchecked(List<?> checkedInterfaceList, List<?> unch
285285
List<String> interfaces = new ArrayList<>();
286286
interfaces.addAll(checkedInterfaces);
287287
interfaces.addAll(uncheckedInterfaces);
288-
proxyConfiguration.add(ConfigurationCondition.objectReachable(), interfaces);
288+
proxyConfiguration.add(ConfigurationCondition.alwaysTrue(), interfaces);
289289
}
290290
}

substratevm/src/com.oracle.svm.configure/src/com/oracle/svm/configure/trace/SerializationProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public SerializationConfiguration getSerializationConfiguration() {
4848
@Override
4949
void processEntry(Map<String, ?> entry) {
5050
boolean invalidResult = Boolean.FALSE.equals(entry.get("result"));
51-
ConfigurationCondition condition = ConfigurationCondition.objectReachable();
51+
ConfigurationCondition condition = ConfigurationCondition.alwaysTrue();
5252
if (invalidResult) {
5353
return;
5454
}

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/ConfigurationParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ protected ConfigurationCondition parseCondition(Map<String, Object> data) {
156156
warnOrFail("'" + TYPE_REACHABLE_KEY + "' should be of type string");
157157
}
158158
}
159-
return ConfigurationCondition.objectReachable();
159+
return ConfigurationCondition.alwaysTrue();
160160
}
161161

162162
}

0 commit comments

Comments
 (0)