Skip to content

Commit 56a19db

Browse files
committed
fix per review
1 parent 70b66a1 commit 56a19db

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Sources/Customization/DefaultEventDispatcher.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,7 @@ open class DefaultEventDispatcher: BackgroundingCallbacks, OPTEventDispatcher {
189189
// send notification BEFORE sending event to the server
190190
NotificationCenter.default.post(name: .willSendOptimizelyEvents, object: event)
191191

192-
let task = session.uploadTask(with: request, from: event.body) { (_, _, error) in
193-
//self.logger.d(response.debugDescription)
194-
192+
let task = session.uploadTask(with: request, from: event.body) { (_, _, error) in
195193
if let error = error {
196194
completionHandler(.failure(.eventDispatchFailed(error.localizedDescription)))
197195
} else {

Sources/Optimizely/OptimizelyClient.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,9 @@ open class OptimizelyClient: NSObject {
605605
/// Read a copy of project configuration data model.
606606
///
607607
/// This call returns a snapshot of the current project configuration.
608+
///
609+
/// When the caller keeps a copy of the return value, note that this data can be stale when a new datafile is downloaded (it's possible only when background datafile polling is enabled).
610+
///
608611
/// If a datafile change is notified (NotificationType.datafileChange), this method should be called again to get the updated configuration data.
609612
///
610613
/// - Returns: a snapshot of public project configuration data model

0 commit comments

Comments
 (0)