From 8a18abbfcc3935e051c94783ba923478dbbd1d7b Mon Sep 17 00:00:00 2001 From: Muhammad Noman Date: Fri, 13 May 2022 18:30:26 +0500 Subject: [PATCH 1/6] testing after removing flag name --- .github/workflows/javascript.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml index 85d76d54d..c25c65c85 100644 --- a/.github/workflows/javascript.yml +++ b/.github/workflows/javascript.yml @@ -85,7 +85,6 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info - flag-name: run-${{ matrix.node }} # This is a parallel build so need this parallel: true base-path: ./packages/optimizely-sdk From a004c028f14ec886af324386c7ae1f385e204d18 Mon Sep 17 00:00:00 2001 From: Muhammad Noman Date: Fri, 13 May 2022 18:37:27 +0500 Subject: [PATCH 2/6] test --- .github/workflows/javascript.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml index c25c65c85..03a772299 100644 --- a/.github/workflows/javascript.yml +++ b/.github/workflows/javascript.yml @@ -85,6 +85,7 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info + flag-name: run-total # This is a parallel build so need this parallel: true base-path: ./packages/optimizely-sdk From 90034d288b4a1f4fc972276f6620252af007cccf Mon Sep 17 00:00:00 2001 From: Muhammad Noman Date: Fri, 13 May 2022 18:48:44 +0500 Subject: [PATCH 3/6] if that resolves the issue --- .github/workflows/javascript.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml index 03a772299..85d76d54d 100644 --- a/.github/workflows/javascript.yml +++ b/.github/workflows/javascript.yml @@ -85,7 +85,7 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info - flag-name: run-total + flag-name: run-${{ matrix.node }} # This is a parallel build so need this parallel: true base-path: ./packages/optimizely-sdk From e10c06c8eef5eb598247de85a856dd7ee144b4e4 Mon Sep 17 00:00:00 2001 From: Muhammad Noman Date: Fri, 13 May 2022 18:59:21 +0500 Subject: [PATCH 4/6] test --- .github/workflows/javascript.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml index 85d76d54d..02ce885d2 100644 --- a/.github/workflows/javascript.yml +++ b/.github/workflows/javascript.yml @@ -10,6 +10,10 @@ jobs: lint_markdown_files: uses: optimizely/javascript-sdk/.github/workflows/lint_markdown.yml@master + + + + lint: runs-on: ubuntu-latest steps: From 43ff109167ffee96d9344cf65c7bc125c2365827 Mon Sep 17 00:00:00 2001 From: Muhammad Noman Date: Fri, 13 May 2022 19:03:27 +0500 Subject: [PATCH 5/6] test --- .github/workflows/javascript.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml index 02ce885d2..488689a56 100644 --- a/.github/workflows/javascript.yml +++ b/.github/workflows/javascript.yml @@ -89,7 +89,7 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info - flag-name: run-${{ matrix.node }} + flag-name: run-total # This is a parallel build so need this parallel: true base-path: ./packages/optimizely-sdk From 2d73144eab36866390e6ebef24a5a617112ce0ab Mon Sep 17 00:00:00 2001 From: Muhammad Noman Date: Fri, 13 May 2022 19:36:09 +0500 Subject: [PATCH 6/6] Fixed --- .github/workflows/javascript.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml index 488689a56..03a772299 100644 --- a/.github/workflows/javascript.yml +++ b/.github/workflows/javascript.yml @@ -10,10 +10,6 @@ jobs: lint_markdown_files: uses: optimizely/javascript-sdk/.github/workflows/lint_markdown.yml@master - - - - lint: runs-on: ubuntu-latest steps: