Skip to content

Commit e8bc418

Browse files
authored
Merge branch 'master' into zeeshan/replace_lodash_values
2 parents fa6343b + 31b5a4d commit e8bc418

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

packages/optimizely-sdk/lib/utils/fns/index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,7 @@ module.exports = {
3333
uuid: function() {
3434
return uuid.v4();
3535
},
36-
isNumber: require('lodash/isNumber'),
36+
isNumber: function(value) {
37+
return typeof value === 'number';
38+
},
3739
};

packages/optimizely-sdk/lib/utils/fns/index.tests.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,22 @@ describe('lib/utils/fns', function() {
3737
assert.isTrue(fns.isFinite(-Math.pow(2, 53)));
3838
});
3939
});
40+
describe('isNumber', function() {
41+
it('should return true in case of number', function() {
42+
assert.isTrue(fns.isNumber(3));
43+
});
44+
it('should return true in case of value from Number object ', function() {
45+
assert.isTrue(fns.isNumber(Number.MIN_VALUE));
46+
});
47+
it('should return true in case of Infinity ', function() {
48+
assert.isTrue(fns.isNumber(Infinity));
49+
});
50+
it('should return false in case of string', function() {
51+
assert.isFalse(fns.isNumber('3'));
52+
});
53+
it('should return false in case of null', function() {
54+
assert.isFalse(fns.isNumber(null));
55+
});
56+
});
4057
});
4158
});

0 commit comments

Comments
 (0)