Removed dependency from tests as well where it was being used directly

Author: fayyazarshad

packages/optimizely-sdk/lib/core/bucketer/index.tests.js

@@ -23,7 +23,6 @@ var testData = require('../../tests/test_data').getTestProjectConfig();
 var chai = require('chai');
 var assert = chai.assert;
 var expect = chai.expect;
-var cloneDeep = require('lodash/cloneDeep');
 var sinon = require('sinon');
 
 var ERROR_MESSAGES = enums.ERROR_MESSAGES;
@@ -67,7 +66,7 @@ describe('lib/core/bucketer', function() {
         });
 
         it('should return correct variation ID when provided bucket value', function() {
-          var bucketerParamsTest1 = cloneDeep(bucketerParams);
+          var bucketerParamsTest1 = bucketerParams;
           bucketerParamsTest1.userId = 'ppid1';
           expect(bucketer.bucket(bucketerParamsTest1)).to.equal('111128');
 
@@ -77,7 +76,7 @@ describe('lib/core/bucketer', function() {
           expect(bucketedUser_log1).to.equal(sprintf(LOG_MESSAGES.USER_ASSIGNED_TO_VARIATION_BUCKET, 'BUCKETER', '50', 'ppid1'));
           expect(bucketedUser_log2).to.equal(sprintf(LOG_MESSAGES.USER_HAS_VARIATION, 'BUCKETER', 'ppid1', 'control', 'testExperiment'));
 
-          var bucketerParamsTest2 = cloneDeep(bucketerParams);
+          var bucketerParamsTest2 = bucketerParams;
           bucketerParamsTest2.userId = 'ppid2';
           expect(bucketer.bucket(bucketerParamsTest2)).to.equal(null);
 
@@ -189,7 +188,7 @@ describe('lib/core/bucketer', function() {
           });
 
           it('should throw an error if group ID is not in the datafile', function() {
-            var bucketerParamsWithInvalidGroupId = cloneDeep(bucketerParams);
+            var bucketerParamsWithInvalidGroupId = bucketerParams;
             bucketerParamsWithInvalidGroupId.experimentKeyMap[configObj.experiments[4].key].groupId = '6969';
 
             assert.throws(function() {
@@ -256,7 +255,7 @@ describe('lib/core/bucketer', function() {
         });
 
         it('should return null', function() {
-          var bucketerParamsTest1 = cloneDeep(bucketerParams);
+          var bucketerParamsTest1 = bucketerParams;
           bucketerParamsTest1.userId = 'ppid1';
           expect(bucketer.bucket(bucketerParamsTest1)).to.equal('');
         });
@@ -283,7 +282,7 @@ describe('lib/core/bucketer', function() {
         });
 
         it('should return null', function() {
-          var bucketerParamsTest1 = cloneDeep(bucketerParams);
+          var bucketerParamsTest1 = bucketerParams;
           bucketerParamsTest1.userId = 'ppid1';
           expect(bucketer.bucket(bucketerParamsTest1)).to.equal(null);
         });
@@ -329,7 +328,7 @@ describe('lib/core/bucketer', function() {
       });
 
       it('check that a non null bucketingId buckets a variation different than the one expected with userId', function () {
-        var bucketerParams1 = cloneDeep(bucketerParams);
+        var bucketerParams1 = bucketerParams;
         bucketerParams1['userId'] = 'testBucketingIdControl';
         bucketerParams1['bucketingId'] = '123456789';
         bucketerParams1['experimentKey'] = 'testExperiment';
@@ -338,7 +337,7 @@ describe('lib/core/bucketer', function() {
       });
 
       it('check that a null bucketing ID defaults to bucketing with the userId', function () {
-        var bucketerParams2 = cloneDeep(bucketerParams);
+        var bucketerParams2 = bucketerParams;
         bucketerParams2['userId'] = 'testBucketingIdControl';
         bucketerParams2['bucketingId'] = null;
         bucketerParams2['experimentKey'] = 'testExperiment';
@@ -347,7 +346,7 @@ describe('lib/core/bucketer', function() {
       });
 
       it('check that bucketing works with an experiment in group', function () {
-        var bucketerParams4 = cloneDeep(bucketerParams);
+        var bucketerParams4 = bucketerParams;
         bucketerParams4['userId'] = 'testBucketingIdControl';
         bucketerParams4['bucketingId'] = '123456789';
         bucketerParams4['experimentKey'] = 'groupExperiment2';