Incorporated more review feedback.

Author: zashraf1985

packages/datafile-manager/__test__/reactNativeAsyncStorageCache.spec.ts

@@ -34,7 +34,8 @@ describe('reactNativeAsyncStorageCache', () => {
     })
 
     it('should reject promise error if string has an incorrect JSON format', function() {
-      return cacheInstance.get('keyWithInvalidJsonObject').catch(() => {})
+      return cacheInstance.get('keyWithInvalidJsonObject')
+        .catch(() => 'exception caught').then(v => { expect(v).toEqual('exception caught') })
     })
   })
 
@@ -47,7 +48,8 @@ describe('reactNativeAsyncStorageCache', () => {
     it('should reject promise if item was not set in the cache because of json stringifying error', function() {
       const testObj: any = { name: "Awesome Object" }
       testObj.myOwnReference = testObj
-      return cacheInstance.set('testKey', testObj).catch(() => {})
+      return cacheInstance.set('testKey', testObj)
+        .catch(() => 'exception caught').then(v => expect(v).toEqual('exception caught'))
     })
   })
 

packages/datafile-manager/src/reactNativeAsyncStorageCache.ts

@@ -22,23 +22,27 @@ import PersistentKeyValueCache from './persistentKeyValueCache'
 const logger = getLogger('DatafileManager')
 
 export default class ReactNativeAsyncStorageCache implements PersistentKeyValueCache {
-
   get(key: string): Promise<any | null> {
-    try {
-      return AsyncStorage.getItem(key)
-        .then((val: string | null) => val ? JSON.parse(val) : null)
-    } catch (ex) {
-      logger.error('Error Parsing Object from cache - %s', ex)
-      return Promise.resolve(ex);
-    }
+    return AsyncStorage.getItem(key)
+      .then((val: string | null) => {
+        if (!val) {
+          return null
+        }
+        try {
+          return JSON.parse(val);
+        } catch (ex) {
+          logger.error('Error Parsing Object from cache - %s', ex)
+          throw ex
+        }  
+      })
   }
 
   set(key: string, val: any): Promise<void> {    
     try {
       return AsyncStorage.setItem(key, JSON.stringify(val))
-    } catch (e) {
-      logger.error('Error stringifying Object to Json - %s', e)
-      return Promise.reject(e)
+    } catch (ex) {
+      logger.error('Error stringifying Object to Json - %s', ex)
+      return Promise.reject(ex)
     }
   }