Skip to content

chore: remove the redundant settings.gradle from quickstart #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

chore: remove the redundant settings.gradle from quickstart #465

merged 1 commit into from
Mar 4, 2022

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Mar 3, 2022

Summary

  • remove the redundant settings.gradle from quickstart (it makes build failed with Intellij 2021.3)
  • upgrade gradle to 6.5 for quickstart

@jaeopt jaeopt requested a review from a team as a code owner March 3, 2022 18:09
@coveralls
Copy link

coveralls commented Mar 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1956

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.752%
Totals Coverage Status
Change from base Build 1952: 0.0%
Covered Lines: 4877
Relevant Lines: 5374
💛 - Coveralls

@jaeopt jaeopt removed their assignment Mar 3, 2022
msohailhussain
msohailhussain approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit d3dfb97 into master Mar 4, 2022
@jaeopt jaeopt deleted the jae/fix-quickstart branch March 4, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 4 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot