Skip to content

Update: Removed log4j properties from quick start application #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Update: Removed log4j properties from quick start application #456

merged 1 commit into from
Dec 14, 2021

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Dec 14, 2021

Summary

  • Removing log4j properties from quick start application for now.

Test plan

All fsc and unit tests should pass.

@coveralls
Copy link

coveralls commented Dec 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1913

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.733%
Totals Coverage Status
Change from base Build 1910: 0.0%
Covered Lines: 4866
Relevant Lines: 5363
💛 - Coveralls

@msohailhussain msohailhussain marked this pull request as ready for review December 14, 2021 18:52
@msohailhussain msohailhussain requested a review from a team as a code owner December 14, 2021 18:52
The-inside-man
The-inside-man approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jaeopt
jaeopt approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit ca3690d into master Dec 14, 2021
@jaeopt jaeopt deleted the mnoman/RemovedLogj branch December 14, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@The-inside-man The-inside-man The-inside-man approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mnoman09 @coveralls @The-inside-man @jaeopt @NomanShoaib