From 277f975baceff2ca956a012fa05d623e53eac60f Mon Sep 17 00:00:00 2001 From: Juan Carlos Tong Date: Fri, 7 Feb 2020 12:50:46 -0800 Subject: [PATCH 1/5] ci(travis): add mdspell --- .travis.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.travis.yml b/.travis.yml index 625c82fb8..e4bcd1609 100644 --- a/.travis.yml +++ b/.travis.yml @@ -51,6 +51,19 @@ jobs: - find . -type f -name '*.md' -exec awesome_bot {} \; notifications: email: false + + - stage: 'Lint markdown files' + language: node_js + node_js: 12 + os: linux + before_install: skip + install: + - npm i -g markdown-spellcheck + before_script: + - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/29e085302a9418edbefba15d8f790fa76e0a89d5/.spelling + script: + - mdspell -a -n -r --en-us '**/*.md' + after_success: skip - &integrationtest stage: 'Integration tests' From a614621b9d3954769f7b45ff6fb15f23e8952fed Mon Sep 17 00:00:00 2001 From: Juan Carlos Tong Date: Fri, 7 Feb 2020 13:06:37 -0800 Subject: [PATCH 2/5] use latest version .spelling --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index e4bcd1609..27a5b98d4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -60,7 +60,7 @@ jobs: install: - npm i -g markdown-spellcheck before_script: - - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/29e085302a9418edbefba15d8f790fa76e0a89d5/.spelling + - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/.spelling script: - mdspell -a -n -r --en-us '**/*.md' after_success: skip From fc4615b5cffdd6e4195a70f7ba4cceeefd52d920 Mon Sep 17 00:00:00 2001 From: Juan Carlos Tong Date: Fri, 7 Feb 2020 14:11:31 -0800 Subject: [PATCH 3/5] spelling fixes --- CHANGELOG.md | 6 +++--- core-api/README.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f4d42e18e..234368a6c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -216,7 +216,7 @@ This is the release candidate for the 3.0 SDK, which includes a number of improv * refactor: Performance improvements for JacksonConfigParser ([#209](https://github.com/optimizely/java-sdk/pull/209)) * refactor: typeAudience.combinations will not be string encoded like audience.combinations. To handle this we created a new parsing type TypedAudience. * fix for exact match when dealing with integers and doubles. Created a new Numeric match type. -* make a copy of attributes passed in to avoid any concurrency problems. Addresses GitHub isue in Optimizely Andriod SDK. +* make a copy of attributes passed in to avoid any concurrency problems. Addresses GitHub issue in Optimizely Andriod SDK. * allow single root node for audience.conditions, typedAudience.conditions, and Experiment.audienceCombinations. ## 3.0.0-RC @@ -239,7 +239,7 @@ This is the release candidate for the 3.0 SDK, which includes a number of improv * refactor: Performance improvements for JacksonConfigParser ([#209](https://github.com/optimizely/java-sdk/pull/209)) * refactor: typeAudience.combinations will not be string encoded like audience.combinations. To handle this we created a new parsing type TypedAudience. * fix for exact match when dealing with integers and doubles. Created a new Numeric match type. -* make a copy of attributes passed in to avoid any concurrency problems. Addresses GitHub isue in Optimizely Andriod SDK. +* make a copy of attributes passed in to avoid any concurrency problems. Addresses GitHub issue in Optimizely Andriod SDK. ## 3.0.0-alpha @@ -386,7 +386,7 @@ January 30, 2018 This release adds support for bucketing id (By passing in `$opt_bucketing_id` in the attribute map to override the user id as the bucketing variable. This is useful when wanting a set of users to share the same experience such as two players in a game). -This release also depricates the old notification broadcaster in favor of a notification center that supports a wide range of notifications. The notification listener is now registered for the specific notification type such as ACTIVATE and TRACK. This is accomplished by allowing for a variable argument call to notify (a new var arg method added to the NotificationListener). Specific abstract classes exist for the associated notification type (ActivateNotification and TrackNotification). These abstract classes enforce the strong typing that exists in Java. You may also add custom notification types and fire them through the notification center. The notification center is implemented using this var arg approach in all Optimizely SDKs. +This release also deprecates the old notification broadcaster in favor of a notification center that supports a wide range of notifications. The notification listener is now registered for the specific notification type such as ACTIVATE and TRACK. This is accomplished by allowing for a variable argument call to notify (a new var arg method added to the NotificationListener). Specific abstract classes exist for the associated notification type (ActivateNotification and TrackNotification). These abstract classes enforce the strong typing that exists in Java. You may also add custom notification types and fire them through the notification center. The notification center is implemented using this var arg approach in all Optimizely SDKs. ### New Features diff --git a/core-api/README.md b/core-api/README.md index 73be6ce9d..13504566f 100644 --- a/core-api/README.md +++ b/core-api/README.md @@ -41,7 +41,7 @@ interface is available for handling errors from the SDK without interfering with ### NoOpErrorHandler The [`NoOpErrorHandler`](https://github.com/optimizely/java-sdk/blob/master/core-api/src/main/java/com/optimizely/ab/error/NoOpErrorHandler.java) -is the default `ErrorHandler` implemetation that silently consumes all errors raised from the SDK. +is the default `ErrorHandler` implementation that silently consumes all errors raised from the SDK. ### RaiseExceptionErrorHandler The [`RaiseExceptionErrorHandler`](https://github.com/optimizely/java-sdk/blob/master/core-api/src/main/java/com/optimizely/ab/error/RaiseExceptionErrorHandler.java) From 3808cde32fc2e145d23ab6e33ffced59d69a934e Mon Sep 17 00:00:00 2001 From: Juan Carlos Tong Date: Mon, 10 Feb 2020 09:54:53 -0800 Subject: [PATCH 4/5] update source location for .spelling --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 27a5b98d4..77620d34f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -60,7 +60,7 @@ jobs: install: - npm i -g markdown-spellcheck before_script: - - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/.spelling + - wget --quiet https://raw.githubusercontent.com/optimizely/mdspell-config/master/.spelling script: - mdspell -a -n -r --en-us '**/*.md' after_success: skip From 4b179c4c6e8062cd5709107dbacd5eb0617ff01a Mon Sep 17 00:00:00 2001 From: Juan Carlos Tong Date: Mon, 10 Feb 2020 16:26:16 -0800 Subject: [PATCH 5/5] improves build speed --- .travis.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 77620d34f..a48429109 100644 --- a/.travis.yml +++ b/.travis.yml @@ -43,9 +43,8 @@ stages: jobs: include: - stage: 'Lint markdown files' - language: ruby - rvm: 2.4.1 os: linux + language: generic install: gem install awesome_bot script: - find . -type f -name '*.md' -exec awesome_bot {} \; @@ -53,9 +52,8 @@ jobs: email: false - stage: 'Lint markdown files' - language: node_js - node_js: 12 os: linux + language: generic before_install: skip install: - npm i -g markdown-spellcheck