Skip to content

Add support for native http proxying. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2019
Merged

Add support for native http proxying. #349

merged 3 commits into from
Dec 16, 2019

Conversation

@mikecdavis
Copy link
Contributor

@mikecdavis mikecdavis commented Dec 13, 2019

Summary

  • Use system properties with custom http client.

This enables http client settings (e.g. http.proxyHost, etc) to be set via system properties.

Test plan

  • Unit test ensuring system properties are getting pulled in.
  • Manually tested by running a local proxy and the provided example via ./gradlew -Dhttps.proxyHost=localhost -Dhttps.proxyPort=8888 runExample

Issues

  • OASIS-5725

@mikecdavis mikecdavis requested a review from a team as a code owner December 13, 2019 23:34
mikeproeng37
mikeproeng37 approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Dec 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1289

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 89.682%
Totals Coverage Status
Change from base Build 1249: 0.003%
Covered Lines: 25249
Relevant Lines: 28154
💛 - Coveralls

@mikecdavis mikecdavis merged commit 914ab7a into master Dec 16, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-5725-proxy-support branch December 16, 2019 18:08
mikecdavis pushed a commit that referenced this pull request Dec 16, 2019
Add support for native http proxying. (#349)
6b07524 
* Use system properties with custom http client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjc1283 mjc1283 Awaiting requested review from mjc1283

@thomaszurkan-optimizely thomaszurkan-optimizely Awaiting requested review from thomaszurkan-optimizely

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikecdavis mikecdavis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikecdavis @coveralls @mikeproeng37