Skip to content

Refac: Refactored Decision Listener SourceInfo as per discussion #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2019
Merged

Refac: Refactored Decision Listener SourceInfo as per discussion #286

merged 3 commits into from
Apr 24, 2019

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Apr 24, 2019

Ticket

@coveralls
Copy link

coveralls commented Apr 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 986

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.613%
Totals Coverage Status
Change from base Build 985: 0.0%
Covered Lines: 2847
Relevant Lines: 3177
💛 - Coveralls

aliabbasrizvi
aliabbasrizvi approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aliabbasrizvi aliabbasrizvi merged commit 684ab9c into master Apr 24, 2019
@aliabbasrizvi aliabbasrizvi deleted the mnoman/ListenerSourceInfoRefac branch April 24, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mnoman09 @coveralls @aliabbasrizvi