Skip to content

Added GetEnabledFeatures method and its unit tests #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2018
Merged

Added GetEnabledFeatures method and its unit tests #172

merged 1 commit into from
Mar 7, 2018

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Mar 2, 2018

  • Added GetEnabledFeatures method and its unit tests

@mnoman09
Added GetEnabledFeatures method and its unit tests
d7a27df 
* Added GetEnabledFeatures method and its unit tests
@mnoman09 mnoman09 self-assigned this Mar 2, 2018
@optibot
Copy link

optibot commented Mar 2, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Mar 2, 2018

Pull Request Test Coverage Report for Build 475

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 88.732%
Totals Coverage Status
Change from base Build 474: 0.04%
Covered Lines: 2197
Relevant Lines: 2476
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 2, 2018

Pull Request Test Coverage Report for Build 475

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 88.732%
Totals Coverage Status
Change from base Build 474: 0.04%
Covered Lines: 2197
Relevant Lines: 2476
💛 - Coveralls

@msohailhussain
Copy link
Contributor

msohailhussain commented Mar 2, 2018

@wangjoshuah @thomaszurkan-optimizely can u please review this PR.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit c43046f into master Mar 7, 2018
@msohailhussain msohailhussain deleted the sohail/getEnabledFeaturePR branch May 21, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnoman09 mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mnoman09 @optibot @coveralls @msohailhussain @thomaszurkan-optimizely