Skip to content

Commit c4d48c5

Browse files
committed
Test null, empty and malformed data corner cases
1 parent 3c4c6bf commit c4d48c5

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

core-api/src/main/java/com/optimizely/ab/Optimizely.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -498,13 +498,7 @@ private void track(@Nonnull String eventName,
498498
* @return a {@link ProjectConfig} instance given a json string
499499
*/
500500
private static ProjectConfig getProjectConfig(String datafile) throws ConfigParseException {
501-
ProjectConfig projectConfig;
502-
try {
503-
projectConfig = DefaultConfigParser.getInstance().parseProjectConfig(datafile);
504-
} catch (Exception e) {
505-
throw new ConfigParseException(e.getMessage(), e);
506-
}
507-
return projectConfig;
501+
return DefaultConfigParser.getInstance().parseProjectConfig(datafile);
508502
}
509503

510504
//======== Notification listeners ========//

core-api/src/test/java/com/optimizely/ab/OptimizelyBuilderTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,19 @@ public class OptimizelyBuilderTest {
6363
@Mock private ErrorHandler mockErrorHandler;
6464

6565
@Test(expected = ConfigParseException.class)
66+
@SuppressFBWarnings(value="NP_NONNULL_PARAM_VIOLATION", justification="Testing nullness contract violation")
6667
public void withNullConfig() throws Exception {
67-
Optimizely optimizelyClient = Optimizely.builder(null, mockEventHandler).build();
68+
Optimizely.builder(null, mockEventHandler).build();
6869
}
6970

7071
@Test(expected = ConfigParseException.class)
7172
public void withEmptyConfig() throws Exception {
72-
Optimizely optimizelyClient = Optimizely.builder("", mockEventHandler).build();
73+
Optimizely.builder("", mockEventHandler).build();
7374
}
7475

7576
@Test(expected = ConfigParseException.class)
7677
public void withInvalidConfig() throws Exception {
77-
Optimizely optimizelyClient = Optimizely.builder("malformed json", mockEventHandler).build();
78+
Optimizely.builder("malformed json", mockEventHandler).build();
7879
}
7980

8081
@Test

0 commit comments

Comments
 (0)