From 2eb6ae59d78232851df53befda23bc218b7da6a5 Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 20 Dec 2022 11:58:58 +0500 Subject: [PATCH 1/7] Fixing acceptance tests and coveralls. --- .../services/rest_ups_test.go | 16 +++++++++++++--- tests/acceptance/datafile.py | 18 +++++++++--------- tests/acceptance/helpers.py | 4 ++-- 3 files changed, 24 insertions(+), 14 deletions(-) diff --git a/plugins/userprofileservice/services/rest_ups_test.go b/plugins/userprofileservice/services/rest_ups_test.go index 22d9538b..4223b6c7 100644 --- a/plugins/userprofileservice/services/rest_ups_test.go +++ b/plugins/userprofileservice/services/rest_ups_test.go @@ -21,8 +21,8 @@ import ( "encoding/json" "net/http" "net/http/httptest" + "sync" "testing" - "time" "github.com/go-chi/render" "github.com/optimizely/agent/pkg/handlers" @@ -39,6 +39,7 @@ type RestUPSTestSuite struct { userProfile decision.UserProfile MethodUsed string savedUserProfile decision.UserProfile + wg *sync.WaitGroup } func (rups *RestUPSTestSuite) SetupTest() { @@ -70,6 +71,9 @@ func (rups *RestUPSTestSuite) SetupTest() { } rups.savedUserProfile = convertToUserProfile(userProfile, rups.ups.getUserIDKey()) w.WriteHeader(http.StatusOK) + if rups.wg != nil { + rups.wg.Done() + } case "/ups/lookup": userProfileMap := convertUserProfileToMap(rups.userProfile, rups.ups.getUserIDKey()) w.Header().Set("Content-Type", "application/json") @@ -178,8 +182,11 @@ func (rups *RestUPSTestSuite) TestSaveDefaultPOST() { func (rups *RestUPSTestSuite) TestSaveDefaultPOSTAsync() { rups.ups.Async = true + rups.wg = &sync.WaitGroup{} + rups.wg.Add(1) rups.ups.Save(rups.userProfile) - time.Sleep(100 * time.Millisecond) + rups.wg.Wait() + rups.wg = nil rups.Equal(rups.userProfile, rups.savedUserProfile) rups.Equal("POST", rups.MethodUsed) } @@ -193,9 +200,12 @@ func (rups *RestUPSTestSuite) TestSaveWithGetMethod() { func (rups *RestUPSTestSuite) TestSaveWithGetMethodAsync() { rups.ups.Async = true + rups.wg = &sync.WaitGroup{} rups.ups.SaveMethod = "GET" + rups.wg.Add(1) rups.ups.Save(rups.userProfile) - time.Sleep(100 * time.Millisecond) + rups.wg.Wait() + rups.wg = nil rups.Equal(rups.userProfile, rups.savedUserProfile) rups.Equal("GET", rups.MethodUsed) } diff --git a/tests/acceptance/datafile.py b/tests/acceptance/datafile.py index 010655c4..d955b793 100644 --- a/tests/acceptance/datafile.py +++ b/tests/acceptance/datafile.py @@ -9,7 +9,7 @@ 'events': [{'experimentIds': ['16910084756', '16911963060'], 'id': '16911532385', 'key': 'myevent'}], 'experiments': [ {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, - 'id': '16911963060', 'key': 'ab_test1', 'layerId': '16916031507', 'status': 'Running', + 'id': '16911963060', 'key': 'ab_test1', 'layerId': 'default-layer-16916031507', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 1000, 'entityId': '16905941566'}, {'endOfRange': 5000, 'entityId': '16905941566'}, {'endOfRange': 8000, 'entityId': '16905941566'}, @@ -18,7 +18,7 @@ 'variations': [{'featureEnabled': True, 'id': '16905941566', 'key': 'variation_1', 'variables': []}, {'featureEnabled': True, 'id': '16927770169', 'key': 'variation_2', 'variables': []}]}, {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, - 'id': '16910084756', 'key': 'feature_2_test', 'layerId': '16933431472', 'status': 'Running', + 'id': '16910084756', 'key': 'feature_2_test', 'layerId': 'default-layer-16933431472', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 5000, 'entityId': '16925360560'}, {'endOfRange': 10000, 'entityId': '16925360560'}], 'variations': [{'featureEnabled': True, 'id': '16925360560', 'key': 'variation_1', 'variables': []}, @@ -49,12 +49,12 @@ 'experiments': [ {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, 'id': '16924931120', 'key': '16924931120', - 'layerId': '16917900798', 'status': 'Running', + 'layerId': 'default-layer-16917900798', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16931381940'}], 'variations': [{'featureEnabled': True, 'id': '16931381940', 'key': '16931381940', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, - 'id': '18234756110', 'key': '18234756110', 'layerId': '16917900798', + 'id': '18234756110', 'key': '18234756110', 'layerId': 'default-layer-16917900798', 'status': 'Running', 'trafficAllocation': [], 'variations': [ {'featureEnabled': True, 'id': '18244927831', 'key': '18244927831', 'variables': []}]}, @@ -65,7 +65,7 @@ {'featureEnabled': False, 'id': '35770', 'key': 'off', 'variables': []}]}], 'id': '16917900798'}, {'experiments': [ {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '16932940705', - 'key': '16932940705', 'layerId': '16917103311', 'status': 'Running', + 'key': '16932940705', 'layerId': 'default-layer-16917103311', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16927890136'}], 'variations': [{'featureEnabled': True, 'id': '16927890136', 'key': '16927890136', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16917103311', @@ -74,13 +74,13 @@ 'variations': [{'featureEnabled': False, 'id': '35769', 'key': 'off', 'variables': []}]}], 'id': '16917103311'}, {'experiments': [ {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, - 'id': '16941022436', 'key': '16941022436', 'layerId': '16928980969', 'status': 'Running', + 'id': '16941022436', 'key': '16941022436', 'layerId': 'default-layer-16928980969', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16906801184'}], 'variations': [ {'featureEnabled': True, 'id': '16906801184', 'key': '16906801184', 'variables': [{'id': '16932993089', 'value': 'true'}, {'id': '16923002469', 'value': '5.6'}, {'id': '16937161477', 'value': '1'}, {'id': '16916052157', 'value': 'hello'}]}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '18263416053', - 'key': '18263416053', 'layerId': '16928980969', 'status': 'Running', 'trafficAllocation': [], + 'key': '18263416053', 'layerId': 'default-layer-16928980969', 'status': 'Running', 'trafficAllocation': [], 'variations': [{'featureEnabled': True, 'id': '18317043587', 'key': '18317043587', 'variables': [{'id': '16932993089', 'value': 'true'}, {'id': '16923002469', 'value': '5.6'}, @@ -94,7 +94,7 @@ {'id': '16937161477', 'value': '1'}, {'id': '16916052157', 'value': 'hello'}]}]}], 'id': '16928980969'}, {'experiments': [ {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '16907440927', - 'key': '16907440927', 'layerId': '16909553406', 'status': 'Running', 'trafficAllocation': [], + 'key': '16907440927', 'layerId': 'default-layer-16909553406', 'status': 'Running', 'trafficAllocation': [], 'variations': [{'featureEnabled': True, 'id': '16908510336', 'key': '16908510336', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16909553406', 'key': 'default-16909553406', 'layerId': 'default-layer-16909553406', 'status': 'Running', @@ -103,7 +103,7 @@ 'id': '16909553406'}, {'experiments': [ {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '16939051724', - 'key': '16939051724', 'layerId': '16943340293', 'status': 'Running', + 'key': '16939051724', 'layerId': 'default-layer-16943340293', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16925940659'}], 'variations': [ {'featureEnabled': True, 'id': '16925940659', 'key': '16925940659', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, diff --git a/tests/acceptance/helpers.py b/tests/acceptance/helpers.py index a618744b..8aa76f15 100644 --- a/tests/acceptance/helpers.py +++ b/tests/acceptance/helpers.py @@ -4,7 +4,7 @@ from random import randint, choice import yaml -from openapi_core import create_spec +from openapi_core import OpenAPISpec as Spec from openapi_core.validation.request.datatypes import (OpenAPIRequest, RequestParameters) from openapi_core.validation.request.validators import RequestValidator from openapi_core.validation.response.datatypes import OpenAPIResponse @@ -33,7 +33,7 @@ def parse_yaml(path): print(exc) -spec = create_spec(parse_yaml(YAML_FILE_PATH)) +spec = Spec.create(parse_yaml(YAML_FILE_PATH)) def get_random_string(): From f00a7169b491bbc83fac42db9aedccf82aa650ed Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 20 Dec 2022 12:08:29 +0500 Subject: [PATCH 2/7] fixes. --- tests/acceptance/helpers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/helpers.py b/tests/acceptance/helpers.py index 8aa76f15..c1ede437 100644 --- a/tests/acceptance/helpers.py +++ b/tests/acceptance/helpers.py @@ -4,7 +4,7 @@ from random import randint, choice import yaml -from openapi_core import OpenAPISpec as Spec +from openapi_core import Spec from openapi_core.validation.request.datatypes import (OpenAPIRequest, RequestParameters) from openapi_core.validation.request.validators import RequestValidator from openapi_core.validation.response.datatypes import OpenAPIResponse From e1fe1ac5917c6f5bcb064fcc8b4595790f85fef9 Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 20 Dec 2022 12:24:49 +0500 Subject: [PATCH 3/7] fixes. --- tests/acceptance/helpers.py | 4 ++-- tests/acceptance/requirements.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/helpers.py b/tests/acceptance/helpers.py index c1ede437..a618744b 100644 --- a/tests/acceptance/helpers.py +++ b/tests/acceptance/helpers.py @@ -4,7 +4,7 @@ from random import randint, choice import yaml -from openapi_core import Spec +from openapi_core import create_spec from openapi_core.validation.request.datatypes import (OpenAPIRequest, RequestParameters) from openapi_core.validation.request.validators import RequestValidator from openapi_core.validation.response.datatypes import OpenAPIResponse @@ -33,7 +33,7 @@ def parse_yaml(path): print(exc) -spec = Spec.create(parse_yaml(YAML_FILE_PATH)) +spec = create_spec(parse_yaml(YAML_FILE_PATH)) def get_random_string(): diff --git a/tests/acceptance/requirements.txt b/tests/acceptance/requirements.txt index b76ed147..6868add6 100644 --- a/tests/acceptance/requirements.txt +++ b/tests/acceptance/requirements.txt @@ -1,4 +1,4 @@ pytest>=5.3.2 pytest-clarity>=0.2.0a1 requests>=2.22.0 -openapi_core>=0.13.4 +openapi_core==0.13.4 From 5c5b5b9e3a93ea1d57cb97e8fe2a329a843611b4 Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 20 Dec 2022 12:36:29 +0500 Subject: [PATCH 4/7] fix requirements for acceptance tests. --- tests/acceptance/requirements.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/requirements.txt b/tests/acceptance/requirements.txt index 6868add6..41e1595f 100644 --- a/tests/acceptance/requirements.txt +++ b/tests/acceptance/requirements.txt @@ -1,4 +1,4 @@ -pytest>=5.3.2 -pytest-clarity>=0.2.0a1 -requests>=2.22.0 -openapi_core==0.13.4 +pytest==7.0.0 +pytest-clarity==1.0.1 +requests==2.27.1 +openapi_core==0.14.2 From 4ace492f7bdbc2e7c00757c2752d8e5fea1d7b2b Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 20 Dec 2022 13:16:10 +0500 Subject: [PATCH 5/7] fixes. --- tests/acceptance/datafile.py | 32 +++++++++---------- .../acceptance/test_acceptance/test_batch.py | 2 +- .../acceptance/test_acceptance/test_config.py | 2 +- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/acceptance/datafile.py b/tests/acceptance/datafile.py index d955b793..3b8d40d9 100644 --- a/tests/acceptance/datafile.py +++ b/tests/acceptance/datafile.py @@ -9,7 +9,7 @@ 'events': [{'experimentIds': ['16910084756', '16911963060'], 'id': '16911532385', 'key': 'myevent'}], 'experiments': [ {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, - 'id': '16911963060', 'key': 'ab_test1', 'layerId': 'default-layer-16916031507', 'status': 'Running', + 'id': '16911963060', 'key': 'ab_test1', 'layerId': '16916031507', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 1000, 'entityId': '16905941566'}, {'endOfRange': 5000, 'entityId': '16905941566'}, {'endOfRange': 8000, 'entityId': '16905941566'}, @@ -18,7 +18,7 @@ 'variations': [{'featureEnabled': True, 'id': '16905941566', 'key': 'variation_1', 'variables': []}, {'featureEnabled': True, 'id': '16927770169', 'key': 'variation_2', 'variables': []}]}, {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, - 'id': '16910084756', 'key': 'feature_2_test', 'layerId': 'default-layer-16933431472', 'status': 'Running', + 'id': '16910084756', 'key': 'feature_2_test', 'layerId': '16933431472', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 5000, 'entityId': '16925360560'}, {'endOfRange': 10000, 'entityId': '16925360560'}], 'variations': [{'featureEnabled': True, 'id': '16925360560', 'key': 'variation_1', 'variables': []}, @@ -38,77 +38,77 @@ {'experimentIds': [], 'id': '16907463855', 'key': 'feature_3', 'rolloutId': '16909553406', 'variables': []}, {'experimentIds': [], 'id': '16912161768', 'key': 'feature_4', 'rolloutId': '16943340293', - 'variables': []}], 'groups': [], 'projectId': '16931203314', 'revision': '130', + 'variables': []}], 'groups': [], 'projectId': '16931203314', 'revision': '131', 'rollouts': [{'experiments': [{'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-rollout-12672-16935023792', 'key': 'default-rollout-12672-16935023792', - 'layerId': 'default-layer-rollout-12672-16935023792', 'status': 'Running', + 'layerId': 'rollout-12672-16935023792', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '35771'}], 'variations': [{'featureEnabled': False, 'id': '35771', 'key': 'off', 'variables': []}]}], 'id': 'rollout-12672-16935023792'}, { 'experiments': [ {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, 'id': '16924931120', 'key': '16924931120', - 'layerId': 'default-layer-16917900798', 'status': 'Running', + 'layerId': '16917900798', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16931381940'}], 'variations': [{'featureEnabled': True, 'id': '16931381940', 'key': '16931381940', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, - 'id': '18234756110', 'key': '18234756110', 'layerId': 'default-layer-16917900798', + 'id': '18234756110', 'key': '18234756110', 'layerId': '16917900798', 'status': 'Running', 'trafficAllocation': [], 'variations': [ {'featureEnabled': True, 'id': '18244927831', 'key': '18244927831', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16917900798', 'key': 'default-16917900798', - 'layerId': 'default-layer-16917900798', 'status': 'Running', + 'layerId': '16917900798', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '35770'}], 'variations': [ {'featureEnabled': False, 'id': '35770', 'key': 'off', 'variables': []}]}], 'id': '16917900798'}, {'experiments': [ {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '16932940705', - 'key': '16932940705', 'layerId': 'default-layer-16917103311', 'status': 'Running', + 'key': '16932940705', 'layerId': '16917103311', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16927890136'}], 'variations': [{'featureEnabled': True, 'id': '16927890136', 'key': '16927890136', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16917103311', - 'key': 'default-16917103311', 'layerId': 'default-layer-16917103311', 'status': 'Running', + 'key': 'default-16917103311', 'layerId': '16917103311', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '35769'}], 'variations': [{'featureEnabled': False, 'id': '35769', 'key': 'off', 'variables': []}]}], 'id': '16917103311'}, {'experiments': [ {'audienceConditions': ['or', '16902921321'], 'audienceIds': ['16902921321'], 'forcedVariations': {}, - 'id': '16941022436', 'key': '16941022436', 'layerId': 'default-layer-16928980969', 'status': 'Running', + 'id': '16941022436', 'key': '16941022436', 'layerId': '16928980969', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16906801184'}], 'variations': [ {'featureEnabled': True, 'id': '16906801184', 'key': '16906801184', 'variables': [{'id': '16932993089', 'value': 'true'}, {'id': '16923002469', 'value': '5.6'}, {'id': '16937161477', 'value': '1'}, {'id': '16916052157', 'value': 'hello'}]}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '18263416053', - 'key': '18263416053', 'layerId': 'default-layer-16928980969', 'status': 'Running', 'trafficAllocation': [], + 'key': '18263416053', 'layerId': '16928980969', 'status': 'Running', 'trafficAllocation': [], 'variations': [{'featureEnabled': True, 'id': '18317043587', 'key': '18317043587', 'variables': [{'id': '16932993089', 'value': 'true'}, {'id': '16923002469', 'value': '5.6'}, {'id': '16937161477', 'value': '1'}, {'id': '16916052157', 'value': 'hello'}]}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16928980969', - 'key': 'default-16928980969', 'layerId': 'default-layer-16928980969', 'status': 'Running', + 'key': 'default-16928980969', 'layerId': '16928980969', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '35768'}], 'variations': [ {'featureEnabled': False, 'id': '35768', 'key': 'off', 'variables': [{'id': '16932993089', 'value': 'true'}, {'id': '16923002469', 'value': '5.6'}, {'id': '16937161477', 'value': '1'}, {'id': '16916052157', 'value': 'hello'}]}]}], 'id': '16928980969'}, {'experiments': [ {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '16907440927', - 'key': '16907440927', 'layerId': 'default-layer-16909553406', 'status': 'Running', 'trafficAllocation': [], + 'key': '16907440927', 'layerId': '16909553406', 'status': 'Running', 'trafficAllocation': [], 'variations': [{'featureEnabled': True, 'id': '16908510336', 'key': '16908510336', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16909553406', - 'key': 'default-16909553406', 'layerId': 'default-layer-16909553406', 'status': 'Running', + 'key': 'default-16909553406', 'layerId': '16909553406', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '35767'}], 'variations': [{'featureEnabled': False, 'id': '35767', 'key': 'off', 'variables': []}]}], 'id': '16909553406'}, {'experiments': [ {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': '16939051724', - 'key': '16939051724', 'layerId': 'default-layer-16943340293', 'status': 'Running', + 'key': '16939051724', 'layerId': '16943340293', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '16925940659'}], 'variations': [ {'featureEnabled': True, 'id': '16925940659', 'key': '16925940659', 'variables': []}]}, {'audienceConditions': [], 'audienceIds': [], 'forcedVariations': {}, 'id': 'default-16943340293', 'key': 'default-16943340293', - 'layerId': 'default-layer-16943340293', 'status': 'Running', + 'layerId': '16943340293', 'status': 'Running', 'trafficAllocation': [{'endOfRange': 10000, 'entityId': '35766'}], 'variations': [{'featureEnabled': False, 'id': '35766', 'key': 'off', 'variables': []}]}], 'id': '16943340293'}], 'sdkKey': 'KZbunNn9bVfBWLpZPq2XC4', 'typedAudiences': [], diff --git a/tests/acceptance/test_acceptance/test_batch.py b/tests/acceptance/test_acceptance/test_batch.py index 8a651b8b..5e92dc93 100644 --- a/tests/acceptance/test_acceptance/test_batch.py +++ b/tests/acceptance/test_acceptance/test_batch.py @@ -186,7 +186,7 @@ def test_batch_valid_reponse(session_obj): "variablesMap": {} } }, - "revision": "20", + "revision": "21", "sdkKey": "TkB2xhu8WEAHa4LphN3xZ2" }""" diff --git a/tests/acceptance/test_acceptance/test_config.py b/tests/acceptance/test_acceptance/test_config.py index 1f46703a..be4b01cc 100644 --- a/tests/acceptance/test_acceptance/test_config.py +++ b/tests/acceptance/test_acceptance/test_config.py @@ -9,7 +9,7 @@ expected_config = """{ "environmentKey": "production", "sdkKey": "KZbunNn9bVfBWLpZPq2XC4", - "revision": "130", + "revision": "131", "experimentsMap": { "ab_test1": { "id": "16911963060", From c5ac15af001e594ac4753724787f17d78b69b821 Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 20 Dec 2022 13:23:44 +0500 Subject: [PATCH 6/7] fixes. --- tests/acceptance/requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/requirements.txt b/tests/acceptance/requirements.txt index 41e1595f..ce7459f0 100644 --- a/tests/acceptance/requirements.txt +++ b/tests/acceptance/requirements.txt @@ -2,3 +2,4 @@ pytest==7.0.0 pytest-clarity==1.0.1 requests==2.27.1 openapi_core==0.14.2 +openapi_spec_validator==0.4.0 \ No newline at end of file From bcd817b11483ce61d19a314dc9afa4e72737f3d2 Mon Sep 17 00:00:00 2001 From: Mirza Sohail Hussain Date: Tue, 20 Dec 2022 11:06:20 -0800 Subject: [PATCH 7/7] by passing travis --- .travis.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.travis.yml b/.travis.yml index 39aeb1f4..34606294 100644 --- a/.travis.yml +++ b/.travis.yml @@ -82,17 +82,17 @@ jobs: script: - MYHOST="http://localhost:8080" make test-acceptance - - stage: 'Trigger FSC Tests' - if: (branch = master AND type = push) OR type = pull_request OR tag IS present - env: - SDK=agent - SDK_BRANCH=$(if [ -z "$TRAVIS_PULL_REQUEST_BRANCH" ]; then echo ${TRAVIS_BRANCH}; else echo "$TRAVIS_PULL_REQUEST_BRANCH"; fi) - cache: false - before_install: - ./scripts/pull_travis_ci_tools.sh - install: skip - script: - - "$HOME/travisci-tools/trigger-script-with-status-update.sh" + # - stage: 'Trigger FSC Tests' + # if: (branch = master AND type = push) OR type = pull_request OR tag IS present + # env: + # SDK=agent + # SDK_BRANCH=$(if [ -z "$TRAVIS_PULL_REQUEST_BRANCH" ]; then echo ${TRAVIS_BRANCH}; else echo "$TRAVIS_PULL_REQUEST_BRANCH"; fi) + # cache: false + # before_install: + # ./scripts/pull_travis_ci_tools.sh + # install: skip + # script: + # - "$HOME/travisci-tools/trigger-script-with-status-update.sh" - stage: 'Test Build using latest tag (no upload)' name: linux