From ac44a3c40577f6d5ca58f67767a493a08612d8f0 Mon Sep 17 00:00:00 2001 From: Joe Lanford Date: Mon, 21 Jul 2025 22:51:20 -0400 Subject: [PATCH 1/3] Define fine-grained owners for the various subcomponents of OLMv1. The goal is to reduce the possibility of the bystander effect (see https://en.wikipedia.org/wiki/Bystander_effect), and give maintainers more accountability and ownership of the areas in which they are experts. This will also help contributors more quickly identify those experts and get the necessary reviews for their work to merge. --- .bingo/.gitignore | 1 + .bingo/OWNERS | 2 ++ .github/OWNERS | 2 ++ OWNERS | 5 ++-- OWNERS_ALIASES | 41 +++++++++++++++++++++-------- api/OWNERS | 2 ++ cmd/OWNERS | 2 ++ config/OWNERS | 2 ++ docs/OWNERS | 23 +--------------- hack/OWNERS | 2 ++ internal/catalogd/OWNERS | 2 ++ internal/operator-controller/OWNERS | 2 ++ manifests/OWNERS | 2 ++ scripts/OWNERS | 2 ++ 14 files changed, 54 insertions(+), 36 deletions(-) create mode 100644 .bingo/OWNERS create mode 100644 .github/OWNERS create mode 100644 api/OWNERS create mode 100644 cmd/OWNERS create mode 100644 config/OWNERS create mode 100644 hack/OWNERS create mode 100644 internal/catalogd/OWNERS create mode 100644 internal/operator-controller/OWNERS create mode 100644 manifests/OWNERS create mode 100644 scripts/OWNERS diff --git a/.bingo/.gitignore b/.bingo/.gitignore index 9efccf683c..9969518178 100644 --- a/.bingo/.gitignore +++ b/.bingo/.gitignore @@ -9,5 +9,6 @@ !README.md !Variables.mk !variables.env +!OWNERS *tmp.mod diff --git a/.bingo/OWNERS b/.bingo/OWNERS new file mode 100644 index 0000000000..835cabe507 --- /dev/null +++ b/.bingo/OWNERS @@ -0,0 +1,2 @@ +approvers: + - ci-approvers diff --git a/.github/OWNERS b/.github/OWNERS new file mode 100644 index 0000000000..835cabe507 --- /dev/null +++ b/.github/OWNERS @@ -0,0 +1,2 @@ +approvers: + - ci-approvers diff --git a/OWNERS b/OWNERS index 6dbe776904..b7e9325fea 100644 --- a/OWNERS +++ b/OWNERS @@ -1,5 +1,4 @@ approvers: - - operator-controller-approvers + - olmv1-approvers reviewers: - - operator-controller-approvers - - operator-controller-reviewers + - olmv1-reviewers diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 52dba52e08..a0aff35efd 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -1,25 +1,44 @@ - aliases: - # contributors who can approve any PRs in the repo - operator-controller-approvers: - - camilamacedo86 - - grokspawn + olmv1-approvers: - joelanford - kevinrizza - perdasilva - - thetechnick - tmshort - # contributors who can review/lgtm any PRs in the repo - operator-controller-reviewers: + olmv1-reviewers: - anik120 - ankitathomas - bentito + - camilamacedo86 - dtfranz - - gallettilance - - gavinmbell - - LalatenduMohanty + - grokspawn + - joelanford - oceanc80 - OchiengEd + - perdasilva - rashmigottipati + - thetechnick + - tmshort - trgeiger + + api-approvers: + - grokspawn + - thetechnick + + catalogd-approvers: + - grokspawn + + operator-controller-approvers: + - thetechnick + + cmd-approvers: + - grokspawn + + manifest-approvers: + - camilamacedo86 + + ci-approvers: + - camilamacedo86 + + docs-approvers: + - michaelryanpeter diff --git a/api/OWNERS b/api/OWNERS new file mode 100644 index 0000000000..71df7cfc52 --- /dev/null +++ b/api/OWNERS @@ -0,0 +1,2 @@ +approvers: + - api-approvers diff --git a/cmd/OWNERS b/cmd/OWNERS new file mode 100644 index 0000000000..740420d64f --- /dev/null +++ b/cmd/OWNERS @@ -0,0 +1,2 @@ +approvers: + - cmd-approvers diff --git a/config/OWNERS b/config/OWNERS new file mode 100644 index 0000000000..b44dad0ea8 --- /dev/null +++ b/config/OWNERS @@ -0,0 +1,2 @@ +approvers: + - manifest-approvers diff --git a/docs/OWNERS b/docs/OWNERS index d1a8d41f19..342c5f6315 100644 --- a/docs/OWNERS +++ b/docs/OWNERS @@ -1,23 +1,2 @@ approvers: - # contributors who can approve any docs PRs in the repo - - michaelryanpeter -reviewers: - # contributors who can review/lgtm any docs PRs in the repo - - anik120 - - ankitathomas - - bentito - - camilamacedo86 - - dtfranz - - gallettilance - - gavinmbell - - grokspawn - - joelanford - - kevinrizza - - LalatenduMohanty - - oceanc80 - - OchiengEd - - perdasilva - - rashmigottipati - - thetechnick - - tmshort - - trgeiger + - docs-approvers diff --git a/hack/OWNERS b/hack/OWNERS new file mode 100644 index 0000000000..835cabe507 --- /dev/null +++ b/hack/OWNERS @@ -0,0 +1,2 @@ +approvers: + - ci-approvers diff --git a/internal/catalogd/OWNERS b/internal/catalogd/OWNERS new file mode 100644 index 0000000000..84b5bd1cca --- /dev/null +++ b/internal/catalogd/OWNERS @@ -0,0 +1,2 @@ +approvers: + - catalogd-approvers diff --git a/internal/operator-controller/OWNERS b/internal/operator-controller/OWNERS new file mode 100644 index 0000000000..3174715ba6 --- /dev/null +++ b/internal/operator-controller/OWNERS @@ -0,0 +1,2 @@ +approvers: + - operator-controller-approvers diff --git a/manifests/OWNERS b/manifests/OWNERS new file mode 100644 index 0000000000..b44dad0ea8 --- /dev/null +++ b/manifests/OWNERS @@ -0,0 +1,2 @@ +approvers: + - manifest-approvers diff --git a/scripts/OWNERS b/scripts/OWNERS new file mode 100644 index 0000000000..b44dad0ea8 --- /dev/null +++ b/scripts/OWNERS @@ -0,0 +1,2 @@ +approvers: + - manifest-approvers From 542be90c311d1a47d132251c9583e9b70a9cc29e Mon Sep 17 00:00:00 2001 From: Joe Lanford Date: Tue, 22 Jul 2025 12:04:13 -0400 Subject: [PATCH 2/3] add OWNERS and alias for docs/draft Signed-off-by: Joe Lanford --- OWNERS_ALIASES | 5 +++++ docs/draft/OWNERS | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 docs/draft/OWNERS diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index a0aff35efd..d24c20b01c 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -42,3 +42,8 @@ aliases: docs-approvers: - michaelryanpeter + + docs-draft-approvers: + - camilamacedo86 + - grokspawn + - thetechnick diff --git a/docs/draft/OWNERS b/docs/draft/OWNERS new file mode 100644 index 0000000000..c81ed41103 --- /dev/null +++ b/docs/draft/OWNERS @@ -0,0 +1,2 @@ +approvers: + - docs-draft-approvers From 116f6c8bceefe504c28c2f6cfe545125df4f4d4e Mon Sep 17 00:00:00 2001 From: Joe Lanford Date: Wed, 23 Jul 2025 16:02:21 -0400 Subject: [PATCH 3/3] api-approvers for generated CRDs Signed-off-by: Joe Lanford --- config/base/catalogd/crd/OWNERS | 2 ++ config/base/operator-controller/crd/OWNERS | 2 ++ 2 files changed, 4 insertions(+) create mode 100644 config/base/catalogd/crd/OWNERS create mode 100644 config/base/operator-controller/crd/OWNERS diff --git a/config/base/catalogd/crd/OWNERS b/config/base/catalogd/crd/OWNERS new file mode 100644 index 0000000000..71df7cfc52 --- /dev/null +++ b/config/base/catalogd/crd/OWNERS @@ -0,0 +1,2 @@ +approvers: + - api-approvers diff --git a/config/base/operator-controller/crd/OWNERS b/config/base/operator-controller/crd/OWNERS new file mode 100644 index 0000000000..71df7cfc52 --- /dev/null +++ b/config/base/operator-controller/crd/OWNERS @@ -0,0 +1,2 @@ +approvers: + - api-approvers