Update target namespace validation to reject own namespace installation on single namespace mode

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

internal/operator-controller/rukpak/render/render.go

@@ -159,10 +159,13 @@ func validateTargetNamespaces(rv1 *bundle.RegistryV1, installNamespace string, t
 		}
 		return fmt.Errorf("supported install modes %v do not support targeting all namespaces", sets.List(supportedInstallModes))
 	case set.Len() == 1 && !set.Has(""):
-		if supportedInstallModes.Has(v1alpha1.InstallModeTypeSingleNamespace) {
+		if targetNamespaces[0] == installNamespace {
+			if !supportedInstallModes.Has(v1alpha1.InstallModeTypeOwnNamespace) {
+				return fmt.Errorf("supported install modes %v do not support targeting own namespace", sets.List(supportedInstallModes))
+			}
 			return nil
 		}
-		if supportedInstallModes.Has(v1alpha1.InstallModeTypeOwnNamespace) && targetNamespaces[0] == installNamespace {
+		if supportedInstallModes.Has(v1alpha1.InstallModeTypeSingleNamespace) {
 			return nil
 		}
 	default:

internal/operator-controller/rukpak/render/render_test.go

@@ -213,7 +213,7 @@ func Test_BundleRenderer_ValidatesRenderOptions(t *testing.T) {
 			opts: []render.Option{
 				render.WithTargetNamespaces("install-namespace"),
 			},
-			err: errors.New("invalid option(s): invalid target namespaces [install-namespace]: supported install modes [AllNamespaces] do not support target namespaces [install-namespace]"),
+			err: errors.New("invalid option(s): invalid target namespaces [install-namespace]: supported install modes [AllNamespaces] do not support targeting own namespace"),
 		}, {
 			name:             "rejects install out of own namespace if only OwnNamespace install mode is supported",
 			installNamespace: "install-namespace",
@@ -266,6 +266,14 @@ func Test_BundleRenderer_ValidatesRenderOptions(t *testing.T) {
 			opts: []render.Option{
 				render.WithTargetNamespaces("some-namespace"),
 			},
+		}, {
+			name:             "rejects single namespace render if OwnNamespace install mode is unsupported and targets own namespace",
+			installNamespace: "install-namespace",
+			csv:              MakeCSV(WithInstallModeSupportFor(v1alpha1.InstallModeTypeSingleNamespace)),
+			opts: []render.Option{
+				render.WithTargetNamespaces("install-namespace"),
+			},
+			err: errors.New("invalid option(s): invalid target namespaces [install-namespace]: supported install modes [SingleNamespace] do not support targeting own namespace"),
 		}, {
 			name:             "accepts multi namespace render if MultiNamespace install mode is supported",
 			installNamespace: "install-namespace",