Skip to content

Commit 40e213b

Browse files
committed
(fix) Remove "Serving" condition type from ConditionSets
conditionset.ConditionTypes was being used by the CluterExtension controller to `ensureAllConditionsWithReason` whenever a particular reason needed to be set for all of the ClusterExention's conditions. However, the `ConditionTypes` included a Condition Type `Serving`, which is not a ClusterExtension Condition(it is a ClusterCatalog condition). This is causing the `Serving` condition to show up when a resolution fails, which is incorrect to begin with, and is then never cleared when the resolution succeeds at a later stage. ``` try to upgrade ClusterExtension to a non-exist version $ kubectl patch ClusterExtension extension-77972 -p '{"spec":{"source":{"catalog":{"version":"0.2.0"}}}}' --type=merge clusterextension.olm.operatorframework.io/extension-77972 patched - lastTransitionTime: "2025-03-04T07:16:27Z" message: 'error upgrading from currently installed version "0.1.0": no bundles found for package "nginx77972" matching version "0.2.0"' observedGeneration: 2 reason: Retrying status: "True" type: Progressing - lastTransitionTime: "2025-03-04T07:16:35Z" message: 'error upgrading from currently installed version "0.1.0": no bundles found for package "nginx77972" matching version "0.2.0"' observedGeneration: 2 reason: Failed status: "False" type: Serving install: bundle: name: nginx77972.v0.1.0 version: 0.1.0 ``` This PR removes the `Serving` condition type from `conditonSets.ConditionType`
1 parent 995dc2b commit 40e213b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

internal/operator-controller/conditionsets/conditionsets.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ var ConditionTypes = []string{
3131
ocv1.TypeChannelDeprecated,
3232
ocv1.TypeBundleDeprecated,
3333
ocv1.TypeProgressing,
34-
ocv1.TypeServing,
3534
}
3635

3736
var ConditionReasons = []string{

0 commit comments

Comments
 (0)