fix?: make sure we wrap all ExecutorServices

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ExecutorServiceManager.java

@@ -20,7 +20,8 @@ public class ExecutorServiceManager {
   private final ExecutorService executor;
   private final int terminationTimeoutSeconds;
 
-  private ExecutorServiceManager(ExecutorService executor, int terminationTimeoutSeconds) {
+  private ExecutorServiceManager(InstrumentedExecutorService executor,
+      int terminationTimeoutSeconds) {
     this.executor = executor;
     this.terminationTimeoutSeconds = terminationTimeoutSeconds;
   }
@@ -46,7 +47,8 @@ public static void stop() {
 
   public static void useTestInstance() {
     if (instance == null) {
-      instance = new ExecutorServiceManager(Executors.newFixedThreadPool(5), 1);
+      instance = new ExecutorServiceManager(
+          new InstrumentedExecutorService(Executors.newFixedThreadPool(5)), 1);
     }
   }
 

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/CustomResourceSelectorTest.java

@@ -19,7 +19,6 @@
 import io.fabric8.kubernetes.client.server.mock.KubernetesMockServer;
 import io.javaoperatorsdk.operator.Operator;
 import io.javaoperatorsdk.operator.api.config.ConfigurationService;
-import io.javaoperatorsdk.operator.api.config.ExecutorServiceManager;
 import io.javaoperatorsdk.operator.api.config.Version;
 import io.javaoperatorsdk.operator.api.reconciler.Context;
 import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
@@ -49,7 +48,6 @@ public class CustomResourceSelectorTest {
   @SuppressWarnings("unchecked")
   @BeforeEach
   void setUpResources() {
-    ExecutorServiceManager.useTestInstance();
     configurationService = spy(ConfigurationService.class);
     when(configurationService.checkCRDAndValidateLocalModel()).thenReturn(false);
     when(configurationService.getVersion()).thenReturn(new Version("1", "1", new Date()));