refactor: remove the use of knownResourceVersions

closes: #2984

Signed-off-by: Steve Hawkins <[email protected]>

Author: shawkins

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java

@@ -80,19 +80,12 @@ void clean() {
   private final ExpirationCache<String> tombstones = new ExpirationCache<>(1000000, 1200000);
   private final ManagedInformerEventSource<T, ?, ?> managedInformerEventSource;
   private final boolean parseResourceVersions;
-  private final ExpirationCache<String> knownResourceVersions;
 
   public TemporaryResourceCache(
       ManagedInformerEventSource<T, ?, ?> managedInformerEventSource,
       boolean parseResourceVersions) {
     this.managedInformerEventSource = managedInformerEventSource;
     this.parseResourceVersions = parseResourceVersions;
-    if (parseResourceVersions) {
-      // keep up to the 50000 add/updates for up to 5 minutes
-      knownResourceVersions = new ExpirationCache<>(50000, 600000);
-    } else {
-      knownResourceVersions = null;
-    }
   }
 
   public synchronized void onDeleteEvent(T resource, boolean unknownState) {
@@ -122,9 +115,6 @@ public synchronized void putAddedResource(T newResource) {
    * @param previousResourceVersion null indicates an add
    */
   public synchronized void putResource(T newResource, String previousResourceVersion) {
-    if (knownResourceVersions != null) {
-      knownResourceVersions.add(newResource.getMetadata().getResourceVersion());
-    }
     var resourceId = ResourceID.fromResource(newResource);
     var cachedResource = managedInformerEventSource.get(resourceId).orElse(null);
 
@@ -160,8 +150,17 @@ public synchronized void putResource(T newResource, String previousResourceVersi
   }
 
   public synchronized boolean isKnownResourceVersion(T resource) {
-    return knownResourceVersions != null
-        && knownResourceVersions.contains(resource.getMetadata().getResourceVersion());
+    var resourceId = ResourceID.fromResource(resource);
+    var knownResource = cache.get(resourceId);
+    if (knownResource == null) {
+      knownResource = managedInformerEventSource.get(resourceId).orElse(null);
+    }
+
+    if (knownResource == null) {
+      return tombstones.contains(resource.getMetadata().getUid());
+    }
+
+    return isLaterResourceVersion(resourceId, knownResource, resource);
   }
 
   /**