refactor: introduce DefaultResourceConfiguration class

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultControllerConfiguration.java

@@ -1,31 +1,25 @@
 package io.javaoperatorsdk.operator.api.config;
 
-import java.util.Collections;
 import java.util.Set;
 
 import io.fabric8.kubernetes.api.model.HasMetadata;
 import io.javaoperatorsdk.operator.processing.event.source.ResourceEventFilter;
 
 public class DefaultControllerConfiguration<R extends HasMetadata>
+    extends DefaultResourceConfiguration<R, ControllerConfiguration<R>>
     implements ControllerConfiguration<R> {
 
   private final String associatedControllerClassName;
   private final String name;
-  private final String crdName;
   private final String finalizer;
-  private final boolean generationAware;
-  private final Set<String> namespaces;
-  private final boolean watchAllNamespaces;
   private final RetryConfiguration retryConfiguration;
-  private final String labelSelector;
   private final ResourceEventFilter<R, ControllerConfiguration<R>> resourceEventFilter;
-  private final Class<R> resourceClass;
-  private ConfigurationService service;
+  private final boolean generationAware;
 
   public DefaultControllerConfiguration(
       String associatedControllerClassName,
       String name,
-      String crdName,
+      String resourceName,
       String finalizer,
       boolean generationAware,
       Set<String> namespaces,
@@ -34,92 +28,50 @@ public DefaultControllerConfiguration(
       ResourceEventFilter<R, ControllerConfiguration<R>> resourceEventFilter,
       Class<R> resourceClass,
       ConfigurationService service) {
+    super(resourceName, resourceClass, namespaces, labelSelector, service);
     this.associatedControllerClassName = associatedControllerClassName;
     this.name = name;
-    this.crdName = crdName;
     this.finalizer = finalizer;
     this.generationAware = generationAware;
-    this.namespaces =
-        namespaces != null ? Collections.unmodifiableSet(namespaces) : Collections.emptySet();
-    this.watchAllNamespaces = this.namespaces.isEmpty();
     this.retryConfiguration =
         retryConfiguration == null
             ? ControllerConfiguration.super.getRetryConfiguration()
             : retryConfiguration;
-    this.labelSelector = labelSelector;
     this.resourceEventFilter = resourceEventFilter;
-    this.resourceClass =
-        resourceClass == null ? ControllerConfiguration.super.getResourceClass()
-            : resourceClass;
-    setConfigurationService(service);
   }
 
   @Override
   public String getName() {
     return name;
   }
 
-  @Override
-  public String getResourceTypeName() {
-    return crdName;
-  }
-
   @Override
   public String getFinalizer() {
     return finalizer;
   }
 
-  @Override
-  public boolean isGenerationAware() {
-    return generationAware;
-  }
-
   @Override
   public String getAssociatedReconcilerClassName() {
     return associatedControllerClassName;
   }
 
-  @Override
-  public Set<String> getNamespaces() {
-    return namespaces;
-  }
-
-  @Override
-  public boolean watchAllNamespaces() {
-    return watchAllNamespaces;
-  }
-
   @Override
   public RetryConfiguration getRetryConfiguration() {
     return retryConfiguration;
   }
 
   @Override
-  public ConfigurationService getConfigurationService() {
-    return service;
-  }
-
-  @Override
-  public void setConfigurationService(ConfigurationService service) {
-    if (this.service != null) {
-      throw new RuntimeException("A ConfigurationService is already associated with '" + name
-          + "' ControllerConfiguration. Cannot change it once set!");
-    }
-    this.service = service;
-  }
-
-  @Override
-  public String getLabelSelector() {
-    return labelSelector;
+  public boolean isGenerationAware() {
+    return generationAware;
   }
 
   @Override
-  public Class<R> getResourceClass() {
-    return resourceClass;
+  public ResourceEventFilter<R, ControllerConfiguration<R>> getEventFilter() {
+    return resourceEventFilter;
   }
 
   @Override
-  public ResourceEventFilter<R, ControllerConfiguration<R>> getEventFilter() {
-    return resourceEventFilter;
+  protected String identifierForException() {
+    return "'" + name + "' ControllerConfiguration";
   }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultDependentResourceConfiguration.java

@@ -0,0 +1,62 @@
+package io.javaoperatorsdk.operator.api.config;
+
+import java.util.Set;
+import java.util.function.Function;
+
+import io.fabric8.kubernetes.api.model.HasMetadata;
+import io.javaoperatorsdk.operator.processing.event.ResourceID;
+
+public class DefaultDependentResourceConfiguration<R extends HasMetadata>
+    extends DefaultResourceConfiguration<R, DependentResourceConfiguration<R>>
+    implements DependentResourceConfiguration<R> {
+  private final boolean creatable;
+  private final boolean updatable;
+  private final boolean owned;
+  private final Function<R, Set<ResourceID>> secondaryToPrimariesMapper;
+  private final Function<HasMetadata, R> primaryToSecondaryMapper;
+  private final boolean skipUpdateIfUnchanged;
+
+  public DefaultDependentResourceConfiguration(String crdName, Class<R> resourceClass,
+      Set<String> namespaces, String labelSelector,
+      ConfigurationService service, boolean creatable, boolean updatable, boolean owned,
+      Function<R, Set<ResourceID>> secondaryToPrimariesMapper,
+      Function<HasMetadata, R> primaryToSecondaryMapper, boolean skipUpdateIfUnchanged) {
+    super(crdName, resourceClass, namespaces, labelSelector, service);
+    this.creatable = creatable;
+    this.updatable = updatable;
+    this.owned = owned;
+    this.secondaryToPrimariesMapper = secondaryToPrimariesMapper;
+    this.primaryToSecondaryMapper = primaryToSecondaryMapper;
+    this.skipUpdateIfUnchanged = skipUpdateIfUnchanged;
+  }
+
+  @Override
+  public boolean creatable() {
+    return creatable;
+  }
+
+  @Override
+  public boolean updatable() {
+    return updatable;
+  }
+
+  @Override
+  public boolean owned() {
+    return owned;
+  }
+
+  @Override
+  public Function<R, Set<ResourceID>> getSecondaryToPrimaryResourcesMapper() {
+    return secondaryToPrimariesMapper;
+  }
+
+  @Override
+  public Function<HasMetadata, R> getSecondaryResourceAssociatedWithPrimaryMapper() {
+    return primaryToSecondaryMapper;
+  }
+
+  @Override
+  public boolean skipUpdateIfUnchanged() {
+    return skipUpdateIfUnchanged;
+  }
+}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultResourceConfiguration.java

@@ -0,0 +1,73 @@
+package io.javaoperatorsdk.operator.api.config;
+
+import java.util.Collections;
+import java.util.Set;
+
+import io.fabric8.kubernetes.api.model.HasMetadata;
+
+public class DefaultResourceConfiguration<R extends HasMetadata, T extends ResourceConfiguration<R, T>>
+    implements ResourceConfiguration<R, T> {
+
+  private final String labelSelector;
+  private final Class<R> resourceClass;
+  private final String resourceName;
+  private final Set<String> namespaces;
+  private final boolean watchAllNamespaces;
+  private ConfigurationService service;
+
+  public DefaultResourceConfiguration(String resourceName, Class<R> resourceClass,
+      Set<String> namespaces, String labelSelector, ConfigurationService service) {
+    this.resourceName = resourceName;
+    this.namespaces =
+        namespaces != null ? Collections.unmodifiableSet(namespaces) : Collections.emptySet();
+    this.watchAllNamespaces = this.namespaces.isEmpty();
+    this.labelSelector = labelSelector;
+    this.resourceClass =
+        resourceClass == null ? ResourceConfiguration.super.getResourceClass()
+            : resourceClass;
+    setConfigurationService(service);
+  }
+
+  @Override
+  public String getResourceTypeName() {
+    return resourceName;
+  }
+
+  @Override
+  public Set<String> getNamespaces() {
+    return namespaces;
+  }
+
+  @Override
+  public boolean watchAllNamespaces() {
+    return watchAllNamespaces;
+  }
+
+  @Override
+  public ConfigurationService getConfigurationService() {
+    return service;
+  }
+
+  @Override
+  public void setConfigurationService(ConfigurationService service) {
+    if (this.service != null) {
+      throw new RuntimeException("A ConfigurationService is already associated with "
+          + identifierForException() + ". Cannot change it once set!");
+    }
+    this.service = service;
+  }
+
+  protected String identifierForException() {
+    return getClass().getName();
+  }
+
+  @Override
+  public String getLabelSelector() {
+    return labelSelector;
+  }
+
+  @Override
+  public Class<R> getResourceClass() {
+    return resourceClass;
+  }
+}