improve

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java

@@ -460,6 +460,12 @@ public static int compareResourceVersions(String v1, String v2) {
     if (v2Length == 0) {
       throw new IllegalArgumentException("resource version must not be empty (2)");
     }
+    if (v1.charAt(0) == '0') {
+      throw new IllegalArgumentException("resource version (1) must not start with 0");
+    }
+    if (v2.charAt(0) == '0') {
+      throw new IllegalArgumentException("resource version (2) must not start with 0");
+    }
     if (v1Length > v2Length) {
       return 1;
     }

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtilsTest.java

@@ -195,6 +195,8 @@ public void compareResourceVersionsTest() {
     assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("11", "ba"));
     assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("", "22"));
     assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("11", ""));
+    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("01", "123"));
+    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("123", "01"));
   }
 
   // naive performance that compares the works case scenario for non parsing variant