feat: showcase initilized list cleanup when adding finalizer with SSA

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/SSAFinalizerIssueCustomResource.java renamed to operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueCustomResource.java

@@ -1,4 +1,4 @@
-package io.javaoperatorsdk.operator.baseapi.ssaissue;
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
 
 import io.fabric8.kubernetes.api.model.Namespaced;
 import io.fabric8.kubernetes.client.CustomResource;

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/SSAFinalizerIssueIT.java renamed to operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueIT.java

@@ -1,4 +1,4 @@
-package io.javaoperatorsdk.operator.baseapi.ssaissue;
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
 
 import java.util.List;
 
@@ -21,6 +21,11 @@ class SSAFinalizerIssueIT {
           .withReconciler(new SSAFinalizerIssueReconciler())
           .build();
 
+  /**
+   * Showcases the problem when we add a finalizer and in the spec a list is initialized with an
+   * empty list by default. This at the end results in a change that when adding the finalizer the
+   * SSA patch deletes the initial values in the spec.
+   */
   @Test
   void addingFinalizerRemoveListValues() {
     operator.create(testResource());

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/SSAFinalizerIssueReconciler.java renamed to operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueReconciler.java

@@ -1,4 +1,4 @@
-package io.javaoperatorsdk.operator.baseapi.ssaissue;
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
 
 import io.javaoperatorsdk.operator.api.reconciler.Cleaner;
 import io.javaoperatorsdk.operator.api.reconciler.Context;

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/SSAFinalizerIssueSpec.java renamed to operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueSpec.java

@@ -1,12 +1,15 @@
-package io.javaoperatorsdk.operator.baseapi.ssaissue;
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
 
+import java.util.ArrayList;
 import java.util.List;
 
 public class SSAFinalizerIssueSpec {
 
   private String value;
 
-  private List<String> list;
+  // List is initialized, that at the end becomes problematic when adding the finalizer
+  // If the list is not initialized like this (this its null) it works fine
+  private List<String> list = new ArrayList<>();
 
   public String getValue() {
     return value;

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/SSAFinalizerIssueStatus.java renamed to operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueStatus.java

@@ -1,4 +1,4 @@
-package io.javaoperatorsdk.operator.baseapi.ssaissue;
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
 
 public class SSAFinalizerIssueStatus {