explicit exception

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/NonComparableResourceVersionException.java

@@ -0,0 +1,10 @@
+package io.javaoperatorsdk.operator.api.reconciler;
+
+import io.javaoperatorsdk.operator.OperatorException;
+
+public class NonComparableResourceVersionException extends OperatorException {
+
+  public NonComparableResourceVersionException(String message) {
+    super(message);
+  }
+}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java

@@ -454,11 +454,11 @@ public static <P extends HasMetadata> P addFinalizerWithSSA(
   public static int compareResourceVersions(String v1, String v2) {
     var v1Length = v1.length();
     if (v1Length == 0) {
-      throw new IllegalArgumentException("Resource version (1) is empty");
+      throw new NonComparableResourceVersionException("Resource version (1) is empty");
     }
     var v2Length = v2.length();
     if (v2Length == 0) {
-      throw new IllegalArgumentException("Resource version (2) is empty");
+      throw new NonComparableResourceVersionException("Resource version (1) is empty");
     }
     var maxLength = Math.max(v1Length, v2Length);
     boolean v1LeadingZero = true;
@@ -470,25 +470,27 @@ public static int compareResourceVersions(String v1, String v2) {
         char1 = v1.charAt(i);
         if (v1LeadingZero) {
           if (char1 == '0') {
-            throw new IllegalArgumentException("Resource version (1) cannot begin with 0");
+            throw new NonComparableResourceVersionException(
+                "Resource version (1) cannot begin with 0");
           }
           v1LeadingZero = false;
         }
         if (!Character.isDigit(char1)) {
-          throw new IllegalArgumentException(
+          throw new NonComparableResourceVersionException(
               "Non numeric characters in resource version (1): " + char1);
         }
       }
       if (i < v2Length) {
         var char2 = v2.charAt(i);
         if (v2LeadingZero) {
           if (char2 == '0') {
-            throw new IllegalArgumentException("Resource version (2) cannot begin with 0");
+            throw new NonComparableResourceVersionException(
+                "Resource version (2) cannot begin with 0");
           }
           v2LeadingZero = false;
         }
         if (!Character.isDigit(char2)) {
-          throw new IllegalArgumentException(
+          throw new NonComparableResourceVersionException(
               "Non numeric characters in resource version (2): " + char2);
         }
         if (char1 == 0) {

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtilsTest.java

@@ -191,14 +191,22 @@ public void compareResourceVersionsTest() {
     assertThat(compareResourceVersions("123", "2")).isPositive();
     assertThat(compareResourceVersions("3", "211")).isNegative();
 
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("aa", "22"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("11", "ba"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("", "22"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("11", ""));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("01", "123"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("123", "01"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("3213", "123a"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("321", "123a"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("aa", "22"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("11", "ba"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("", "22"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("11", ""));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("01", "123"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("123", "01"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("3213", "123a"));
+    assertThrows(
+        NonComparableResourceVersionException.class, () -> compareResourceVersions("321", "123a"));
   }
 
   // naive performance test that compares the work case scenario for the parsing and non-parsing