wip

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java

@@ -454,18 +454,6 @@ public static <P extends HasMetadata> P addFinalizerWithSSA(
   public static int compareResourceVersions(String v1, String v2) {
     var v1Length = v1.length();
     var v2Length = v2.length();
-    if (v1Length == 0) {
-      throw new IllegalArgumentException("resource version must not be empty (1)");
-    }
-    if (v2Length == 0) {
-      throw new IllegalArgumentException("resource version must not be empty (2)");
-    }
-    if (v1.charAt(0) == '0') {
-      throw new IllegalArgumentException("resource version (1) must not start with 0");
-    }
-    if (v2.charAt(0) == '0') {
-      throw new IllegalArgumentException("resource version (2) must not start with 0");
-    }
     if (v1Length > v2Length) {
       return 1;
     }
@@ -475,14 +463,6 @@ public static int compareResourceVersions(String v1, String v2) {
     for (int i = 0; i < v1Length; i++) {
       var char1 = v1.charAt(i);
       var char2 = v2.charAt(i);
-      if (!Character.isDigit(char1)) {
-        throw new IllegalArgumentException(
-            "Non numeric characters in resource version (1): " + char1);
-      }
-      if (!Character.isDigit(char2)) {
-        throw new IllegalArgumentException(
-            "Non numeric characters in resource version (2): " + char2);
-      }
       if (char1 > char2) {
         return 1;
       }

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtilsTest.java

@@ -190,13 +190,6 @@ public void compareResourceVersionsTest() {
 
     assertThat(compareResourceVersions("123", "2")).isPositive();
     assertThat(compareResourceVersions("3", "211")).isNegative();
-
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("aa", "22"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("11", "ba"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("", "22"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("11", ""));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("01", "123"));
-    assertThrows(IllegalArgumentException.class, () -> compareResourceVersions("123", "01"));
   }
 
   // naive performance that compares the works case scenario for non parsing variant