Skip to content

Commit 9991f88

Browse files
committed
restored deletion on webp error
1 parent 81758b0 commit 9991f88

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/zimscraperlib/image/optimization.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,12 @@ def optimize_webp(
203203
webp_image.save(dst, format="WEBP", **params)
204204
dst.seek(0)
205205
else:
206-
save_image(webp_image, dst, fmt="WEBP", **params)
206+
try:
207+
save_image(webp_image, dst, fmt="WEBP", **params)
208+
except Exception as exc:
209+
if src.resolve() != dst.resolve() and dst.exists():
210+
dst.unlink() # pragma: nocover
211+
raise exc
207212
return dst
208213

209214

@@ -253,7 +258,7 @@ def optimize_gif(
253258

254259
# remove dst if gifsicle failed and src is different from dst
255260
if gifsicle.returncode != 0 and src.resolve() != dst.resolve() and dst.exists():
256-
dst.unlink()
261+
dst.unlink() # pragma: nocover
257262

258263
# raise error if unsuccessful
259264
gifsicle.check_returncode()

0 commit comments

Comments
 (0)