fix: fix member memory management.

Author: andycall

bridge/bindings/qjs/cppgc/member.h

@@ -36,18 +36,12 @@ class Member {
     raw_ = other.raw_;
     runtime_ = other.runtime_;
     js_object_ptr_ = other.js_object_ptr_;
+    ((JSRefCountHeader*) other.js_object_ptr_)->ref_count++;
   }
   ~Member() {
     if (raw_ != nullptr) {
       assert(runtime_ != nullptr);
-      // There are two ways to free the member values:
-      //  One is by GC marking and sweep stage.
-      //  Two is by free directly when running out of function body.
-      // We detect the GC phase to handle case two, and free our members by hand(call JS_FreeValueRT directly).
-      JSGCPhaseEnum phase = JS_GetEnginePhase(runtime_);
-      if (phase == JS_GC_PHASE_DECREF || phase == JS_GC_PHASE_REMOVE_CYCLES) {
-        JS_FreeValueRT(runtime_, JS_MKPTR(JS_TAG_OBJECT, js_object_ptr_));
-      }
+      JS_FreeValueRT(runtime_, JS_MKPTR(JS_TAG_OBJECT, js_object_ptr_));
     }
   };
 
@@ -75,6 +69,7 @@ class Member {
     raw_ = other.raw_;
     runtime_ = other.runtime_;
     js_object_ptr_ = other.js_object_ptr_;
+    ((JSRefCountHeader*) other.js_object_ptr_)->ref_count++;
     return *this;
   }
   // Move assignment.

bridge/core/dom/child_list_mutation_scope.cc

@@ -52,18 +52,6 @@ ChildListMutationAccumulator::ChildListMutationAccumulator(Node* target,
     : target_(target), last_added_(nullptr), observers_(observers), mutation_scopes_(0) {}
 
 ChildListMutationAccumulator::~ChildListMutationAccumulator() {
-  for(auto& node : removed_nodes_) {
-    node.Clear();
-  }
-
-  for(auto& node : added_nodes_) {
-    node.Clear();
-  }
-
-  target_.Clear();
-  previous_sibling_.Clear();
-  next_sibling_.Clear();
-  last_added_.Clear();
 }
 
 void ChildListMutationAccumulator::LeaveMutationScope() {

bridge/core/dom/child_list_mutation_scope.h

@@ -81,13 +81,13 @@ class ChildListMutationScope final {
   }
 
   void ChildAdded(Node& child) {
-//    if (accumulator_ && accumulator_->HasObservers())
-//      accumulator_->ChildAdded(child);
+    if (accumulator_ && accumulator_->HasObservers())
+      accumulator_->ChildAdded(child);
   }
 
   void WillRemoveChild(Node& child) {
-//    if (accumulator_ && accumulator_->HasObservers())
-//      accumulator_->WillRemoveChild(child);
+    if (accumulator_ && accumulator_->HasObservers())
+      accumulator_->WillRemoveChild(child);
   }
 
  private:

bridge/core/dom/collection_items_cache.h

@@ -72,9 +72,6 @@ template <typename Collection, typename NodeType>
 void CollectionItemsCache<Collection, NodeType>::Invalidate() {
   Base::Invalidate();
   if (list_valid_) {
-    for (auto& item : cached_list_) {
-      item.Clear();
-    }
     cached_list_.clear();
     list_valid_ = false;
   }
@@ -88,7 +85,8 @@ unsigned CollectionItemsCache<Collection, NodeType>::NodeCount(const Collection&
   NodeType* current_node = collection.TraverseToFirst();
   unsigned current_index = 0;
   while (current_node) {
-    cached_list_.push_back(current_node);
+    cached_list_.emplace_back(current_node);
+//    cached_list_.push_back(current_node);
     current_node = collection.TraverseForwardToOffset(current_index + 1, *current_node, current_index);
   }
 

bridge/core/dom/mutation_observer_interest_group.cc

@@ -60,10 +60,6 @@ MutationObserverInterestGroup::MutationObserverInterestGroup(
 }
 
 MutationObserverInterestGroup::~MutationObserverInterestGroup() {
-  WEBF_LOG(VERBOSE) << "INTERST";
-  for(auto& observer : observers_) {
-    observer.first.Clear();
-  }
 }
 
 bool MutationObserverInterestGroup::IsOldValueRequested() {

bridge/core/dom/mutation_observer_registration.cc

@@ -49,19 +49,11 @@ MutationObserverRegistration::MutationObserverRegistration(MutationObserver& obs
 }
 
 MutationObserverRegistration::~MutationObserverRegistration() {
-  registration_node_.Clear();
-  registration_node_keep_alive_.Clear();
-  observer_.Clear();
-
-  for(auto& node : transient_registration_nodes_) {
-    node.Clear();
-  }
 }
 
 void MutationObserverRegistration::Dispose() {
   ClearTransientRegistrations();
   observer_->ObservationEnded(shared_from_this());
-  observer_.Clear();
 }
 
 void MutationObserverRegistration::ResetObservation(

bridge/core/timing/performance.cc

@@ -107,8 +107,6 @@ void Performance::clearMarks(ExceptionState& exception_state) {
   while (it != entries_.end()) {
     if ((*it)->entryType() != performance_entry_names::kmark) {
       new_entries.emplace_back(*it);
-    } else {
-      it->Clear();
     }
     it++;
   }
@@ -123,8 +121,6 @@ void Performance::clearMarks(const AtomicString& name, ExceptionState& exception
   while (it != std::end(entries_)) {
     if (!((*it)->entryType() == performance_entry_names::kmark && (*it)->name() == name)) {
       new_entries.emplace_back(*it);
-    } else {
-      it->Clear();
     }
     it++;
   }
@@ -139,8 +135,6 @@ void Performance::clearMeasures(ExceptionState& exception_state) {
   while (it != std::end(entries_)) {
     if ((*it)->entryType() != performance_entry_names::kmeasure) {
       new_entries.emplace_back(*it);
-    } else {
-      it->Clear();
     }
     it++;
   }
@@ -155,8 +149,6 @@ void Performance::clearMeasures(const AtomicString& name, ExceptionState& except
   while (it != std::end(entries_)) {
     if (!((*it)->entryType() == performance_entry_names::kmeasure && (*it)->name() == name)) {
       new_entries.emplace_back(*it);
-    } else {
-      it->Clear();
     }
     it++;
   }