From e8a192b3e20018dbda2a02169e218e82500398fc Mon Sep 17 00:00:00 2001
From: Hongkai Liu <hongkailiu@users.noreply.github.com>
Date: Tue, 4 Nov 2025 11:26:08 -0500
Subject: [PATCH] NO-JIRA: Clarify test names in OTE

This pull add a section to clarify test names in OTE.
It modifies `hack/update-test-metadata.sh` to give a
hint of what to do to fix the issue.
---
 cmd/cluster-version-operator-tests/README.md | 38 +++++++++++++++++++-
 hack/update-test-metadata.sh                 |  6 +++-
 2 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/cmd/cluster-version-operator-tests/README.md b/cmd/cluster-version-operator-tests/README.md
index 40a0aa197..c92404998 100644
--- a/cmd/cluster-version-operator-tests/README.md
+++ b/cmd/cluster-version-operator-tests/README.md
@@ -21,4 +21,40 @@ After [installing-ginkgo](https://onsi.github.io/ginkgo/#installing-ginkgo):
 $ ginkgo ./test/...
 ```
 
-The output looks nicer this way.
\ No newline at end of file
+The output looks nicer this way.
+
+
+## Test Names
+
+### Test labels
+
+See [docs](https://github.com/openshift/origin/tree/main/test/extended#test-labels) for details.
+
+### Ownership
+
+* A `[Jira:"Component"]` tag in the test name (e.g., [Jira:"Cluster Version Operator"]) is preferred to claim the ownership of the test. The component comes from [the list of components of Jira Project OCPBUGS](https://issues.redhat.com/projects/OCPBUGS?selectedItem=com.atlassian.jira.jira-projects-plugin:components-page). See [here](https://github.com/openshift/origin/blob/6b584254d53cdd1b5cd6471b69cb7c22f3e28ecd/test/extended/apiserver/rollout.go#L36) for example.
+
+* Or an entry in the [ci-test-mapping](https://github.com/openshift-eng/ci-test-mapping) repository, which maps tests to owning components. See [here](https://github.com/openshift-eng/ci-test-mapping/tree/main/pkg/components/clusterversionoperator) for example.
+
+### Renaming
+
+If a test is renamed, claim it with [specs.Walk](https://pkg.go.dev/github.com/openshift-eng/openshift-tests-extension@v0.0.0-20251024155203-c498f9efe478/pkg/extension/extensiontests#ExtensionTestSpecs.Walk):
+
+```go
+specs = specs.Walk(func(spec *et.ExtensionTestSpec) {
+    if orig, ok := renamedTests[spec.Name]; ok {
+		spec.OriginalName = orig
+	}
+})
+```
+
+### Deleting
+
+If a test is renamed, claim it with [ext.IgnoreObsoleteTests](https://pkg.go.dev/github.com/openshift-eng/openshift-tests-extension@v0.0.0-20251024155203-c498f9efe478/pkg/extension#Extension.IgnoreObsoleteTests)
+
+```go
+ext.IgnoreObsoleteTests(
+"[sig-abc] My removed test",
+// Add more removed test names below
+)
+```
diff --git a/hack/update-test-metadata.sh b/hack/update-test-metadata.sh
index 47575a3a6..16c82d25f 100755
--- a/hack/update-test-metadata.sh
+++ b/hack/update-test-metadata.sh
@@ -5,4 +5,8 @@ set -eu
 source hack/build-info.sh
 
 # Update test metadata
-eval "${BIN_PATH}/cluster-version-operator-tests" "update"
+if ! "${BIN_PATH}/cluster-version-operator-tests" "update"; then
+  >&2 echo "run 'make update' to fix the metadata after going through the teest renaming process.
+See https://github.com/openshift/cluster-version-operator/blob/main/cmd/cluster-version-operator-tests/README.md#test-names for details."
+  exit 1
+fi