fixup! return a slice of errors to avoid nil errors counting in length check

Signed-off-by: Bryce Palmer <[email protected]>

Author: everettraven

test/e2e-oidc/external_oidc_test.go

@@ -727,7 +727,7 @@ func (tc *testClient) validateOAuthState(t *testing.T, ctx context.Context, requ
 		validationErrs = append(validationErrs, validateOAuthResources(ctx, dynamicClient, requireMissing)...)
 		validationErrs = append(validationErrs, validateOAuthRoutes(ctx, tc.routeClient, tc.configClient, requireMissing)...)
 		validationErrs = append(validationErrs, validateOAuthControllerConditions(tc.operatorClient, requireMissing)...)
-		validationErrs = append(validationErrs, validateOperandVersions(ctx, tc.configClient, requireMissing))
+		validationErrs = append(validationErrs, validateOperandVersions(ctx, tc.configClient, requireMissing)...)
 		return len(validationErrs) == 0, nil
 	})
 
@@ -873,12 +873,12 @@ func validateOAuthControllerConditions(operatorClient v1helpers.OperatorClient,
 	return nil
 }
 
-func validateOperandVersions(ctx context.Context, cfgClient *configclient.Clientset, requireMissing bool) error {
+func validateOperandVersions(ctx context.Context, cfgClient *configclient.Clientset, requireMissing bool) []error {
 	operands := sets.New("oauth-apiserver", "oauth-openshift")
 
 	authnClusterOperator, err := cfgClient.ConfigV1().ClusterOperators().Get(ctx, "authentication", metav1.GetOptions{})
 	if err != nil {
-		return fmt.Errorf("fetching authentication ClusterOperator: %w", err)
+		return []error{fmt.Errorf("fetching authentication ClusterOperator: %w", err)}
 	}
 
 	foundOperands := []string{}
@@ -889,12 +889,12 @@ func validateOperandVersions(ctx context.Context, cfgClient *configclient.Client
 	}
 
 	if requireMissing && len(foundOperands) > 0 {
-		return fmt.Errorf("authentication ClusterOperator status has operands %v in versions when they should be unset", foundOperands)
+		return []error{fmt.Errorf("authentication ClusterOperator status has operands %v in versions when they should be unset", foundOperands)}
 	}
 
 	foundSet := sets.New(foundOperands...)
 	if !requireMissing && !foundSet.Equal(operands) {
-		return fmt.Errorf("authentication ClusterOperator status expected to have operands %v in versions but got %v", operands.UnsortedList(), foundOperands)
+		return []error{fmt.Errorf("authentication ClusterOperator status expected to have operands %v in versions but got %v", operands.UnsortedList(), foundOperands)}
 	}
 
 	return nil