Skip to content

Cluster bot org auth #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Cluster bot org auth #564

wants to merge 27 commits into from

Conversation

@hoxhaeris
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from bradmwilliams and jupierce July 31, 2025 14:46
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2025
@bradmwilliams
Copy link
Contributor

/retest-required

@hoxhaeris
Copy link
Contributor Author

/retest

@hoxhaeris hoxhaeris force-pushed the cluster_bot_org_auth_poc branch 2 times, most recently from 7515bb3 to 0847735 Compare August 13, 2025 20:14
@bradmwilliams
Copy link
Contributor

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 28, 2025
@hoxhaeris hoxhaeris force-pushed the cluster_bot_org_auth_poc branch from 98956a7 to 01f559a Compare August 29, 2025 09:52
@hoxhaeris
authorization POC
820c82c
@hoxhaeris
several bugfixes, add a few debug lines
5c9fa59
@hoxhaeris
add an AI generated readme, based on the code change
791e371
@hoxhaeris
improve whoami output, note the org type
08094f4
@hoxhaeris
fix lint
5c6e454
@hoxhaeris
change logic to use the pre-indexed data;
a18a942 
the index is not being built anymore in the service here, only consumed
@hoxhaeris
the rosa hash was broken, I had to fix the vendor
ee6ddcb
@hoxhaeris
create a new separate orgdata-code package, ready to be moved to a se…
abdf184 
…parate package
@hoxhaeris
update README
d0a28ea
@hoxhaeris
update go.mod with new dependencies
486f59a
@hoxhaeris
vendor: fix the vbom.ml/util issue
d33dd9b
@hoxhaeris
add gcs datasource, adapt current code to use it as a pluginable source
540221a
@hoxhaeris
update Makefile and run scripts to support the new feature
3987c04
@hoxhaeris
update the AUTHORIZATION.md AI-generated readme to reflect the gcs ch…
6270c0f 
…anges
@hoxhaeris
remove references to my local paths on hack run scripts;
fa5c1e8 
update README to reflect the new changes (gcs) and link the new MD files
@hoxhaeris
fix lint
b415f1e
@hoxhaeris
clean up the orgdata package, remove duplicated types definitions;
a217896 
improve the auth data source, use a similar pluggable approach like in the orgdata-code;
update documentation to reflect the auth config loading changes
@hoxhaeris
move orgdata-core to a new repository
7217ece 
update Makefile to use Openshift Builder
@hoxhaeris
add SOURCE_GIT_TAG on Makefile
9869c98
@hoxhaeris hoxhaeris force-pushed the cluster_bot_org_auth_poc branch from 99162a0 to 048be25 Compare September 30, 2025 08:26
@hoxhaeris
standardize logging;
50795dd 
change the gcs bucket references
@hoxhaeris hoxhaeris force-pushed the cluster_bot_org_auth_poc branch from 048be25 to 5ac51f6 Compare September 30, 2025 08:30
@hoxhaeris hoxhaeris changed the title [WIP] Cluster bot org auth Cluster bot org auth Sep 30, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@hoxhaeris
Copy link
Contributor Author

/hold
We need to set up the cron job generating the org dump first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2025
@hoxhaeris hoxhaeris force-pushed the cluster_bot_org_auth_poc branch from 5ac51f6 to 516fd35 Compare September 30, 2025 10:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hoxhaeris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 516fd35 link false /test security
ci/prow/govulncheck 516fd35 link false /test govulncheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
bradmwilliams
bradmwilliams suggested changes Oct 9, 2025
View reviewed changes
Makefile
Comment on lines +12 to +13
# Use standard GO_BUILD_FLAGS for build tags (e.g., -tags gcs)
GO_BUILD_FLAGS ?=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our standup, I took a look at this again and I think that you should probably just change this line to:
GO_BUILD_FLAGS=-tags gcs -trimpath

The current issue is that GO_BUILD_FLAGS is imported directly from build-machinery and using ?= doesn't work unless passed in on the command line. That's silly when we can force the issue ourselves and then we won't have to make any changes to openshift/release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of us will have to update our IDE specific builds to add the tags accordingly, but for production we always produce the GCS version.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jupierce jupierce Awaiting requested review from jupierce

1 more reviewer

@bradmwilliams bradmwilliams bradmwilliams requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bradmwilliams bradmwilliams

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoxhaeris @bradmwilliams