linter fix

Author: andfasano

machineconfiguration/v1alpha1/types_internalreleaseimage.go

@@ -23,65 +23,75 @@ import (
 // Compatibility level 4: No compatibility is provided, the API can change at any point for any reason. These capabilities should not be used by applications needing long term support.
 // +openshift:compatibility-gen:level=4
 type InternalReleaseImage struct {
-	metav1.TypeMeta   `json:",inline"`
+	metav1.TypeMeta `json:",inline"`
+
+	// metadata is the standard object's metadata.
+	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
+	// +optional
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	// spec describes the configuration of this internal release image.
 	// +required
-	Spec InternalReleaseImageSpec `json:"spec"`
+	Spec InternalReleaseImageSpec `json:"spec,omitzero"`
 
 	// status describes the last observed state of this internal release image.
 	// +optional
-	Status InternalReleaseImageStatus `json:"status"`
+	Status *InternalReleaseImageStatus `json:"status,omitempty"`
 }
 
 // InternalReleaseImageStatus describes the current state of a InternalReleaseImage.
 type InternalReleaseImageStatus struct {
+	// conditions represent the observations of an internal release image current state.
+	// +listType=map
+	// +listMapKey=type
+	// +kubebuilder:validation:MinItems=1
+	// +kubebuilder:validation:MaxItems=256
+	// +optional
+	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
 	// availableReleases is a list of release bundle identifiers currently detected
 	// from the attached ISO.
 	// +listType=map
 	// +listMapKey=name
+	// +kubebuilder:validation:MinItems=1
+	// +kubebuilder:validation:MaxItems=64
 	// +optional
-	AvailableReleases []InternalReleaseImageRef `json:"availableReleases"`
+	AvailableReleases []InternalReleaseImageRef `json:"availableReleases,omitempty"`
 
 	// releases is a list of the currently managed release bundles.
 	// +listType=map
 	// +listMapKey=name
-	// +required
-	Releases []InternalReleaseImageRef `json:"releases"`
-
-	// conditions represent the observations of an internal release image current state.
-	// +listType=map
-	// +listMapKey=type
+	// +kubebuilder:validation:MinItems=1
+	// +kubebuilder:validation:MaxItems=64
 	// +optional
-	Conditions []metav1.Condition `json:"conditions,omitempty"`
+	Releases []InternalReleaseImageRef `json:"releases,omitempty"`
 }
 
 // InternalReleaseImageSpec defines the desired state of a InternalReleaseImage.
 type InternalReleaseImageSpec struct {
 	// releases is a list of release bundle identifiers that the user wants to
 	// add/remove to/from the control plane nodes.
-	// +required
 	// +kubebuilder:validation:MinItems=1
 	// +kubebuilder:validation:MaxItems=20
 	// +listType=map
 	// +listMapKey=name
-	Releases []InternalReleaseImageRef `json:"releases"`
+	// +required
+	Releases []InternalReleaseImageRef `json:"releases,omitempty"`
 }
 
 type InternalReleaseImageRef struct {
 	// name indicates the desired release bundle identifier.
 	// +required
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=64
-	Name string `json:"name"`
+	Name string `json:"name,omitempty"`
 
 	// image is an OCP release imaged referenced by digest.
 	// The format of the image pull spec is: host[:port][/namespace]/name@sha256:<digest>,
 	// where the digest must be 64 characters long, and consist only of lowercase hexadecimal characters, a-f and 0-9.
 	// The length of the whole spec must be between 1 to 447 characters.
 	// +optional
-	Image machineosconfig.ImageDigestFormat `json:"image"`
+	Image machineosconfig.ImageDigestFormat `json:"image,omitempty"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-CustomNoUpgrade.crd.yaml

@@ -122,6 +122,8 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
@@ -183,6 +185,8 @@ spec:
                   - status
                   - type
                   type: object
+                maxItems: 256
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - type
@@ -215,12 +219,12 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
                 x-kubernetes-list-type: map
-            required:
-            - releases
             type: object
         required:
         - spec

machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-DevPreviewNoUpgrade.crd.yaml

@@ -121,6 +121,8 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
@@ -182,6 +184,8 @@ spec:
                   - status
                   - type
                   type: object
+                maxItems: 256
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - type
@@ -214,12 +218,12 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
                 x-kubernetes-list-type: map
-            required:
-            - releases
             type: object
         required:
         - spec

machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-TechPreviewNoUpgrade.crd.yaml

@@ -121,6 +121,8 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
@@ -182,6 +184,8 @@ spec:
                   - status
                   - type
                   type: object
+                maxItems: 256
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - type
@@ -214,12 +218,12 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
                 x-kubernetes-list-type: map
-            required:
-            - releases
             type: object
         required:
         - spec

machineconfiguration/v1alpha1/zz_generated.deepcopy.go

@@ -122,6 +122,8 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
@@ -183,6 +185,8 @@ spec:
                   - status
                   - type
                   type: object
+                maxItems: 256
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - type
@@ -215,12 +219,12 @@ spec:
                   required:
                   - name
                   type: object
+                maxItems: 64
+                minItems: 1
                 type: array
                 x-kubernetes-list-map-keys:
                 - name
                 x-kubernetes-list-type: map
-            required:
-            - releases
             type: object
         required:
         - spec