Refactor RemoteTranslogTransferTracker.Stats and RemoteSegmentTransferTracker.Stats with Builder pattern #19837
+526
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pado0
force-pushed
the
builder-remote-transfer-tracker
branch
from
e85aa3e to
96ffd50
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19837 +/- ##
============================================
- Coverage 73.08% 73.06% -0.03%
+ Complexity 71063 71042 -21
============================================
Files 5754 5754
Lines 325262 325437 +175
Branches 47033 47033
============================================
+ Hits 237732 237791 +59
- Misses 68380 68542 +162
+ Partials 19150 19104 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pado0
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
sandeshkr419
approved these changes
Oct 31, 2025
server/src/main/java/org/opensearch/index/remote/RemoteTranslogTransferTracker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
pado0
force-pushed
the
builder-remote-transfer-tracker
branch
from
ce6cdab to
d48903a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
RemoteTranslogTransferTracker.StatsandRemoteSegmentTransferTracker.Statsclass to use the Builder pattern instead of relying on multiple constructors.By adopting the Builder pattern, it becomes easier to evolve the stats API, add new metrics, and maintain backward compatibility without forcing disruptive constructor changes.
Based on the related issue:
There are multiple stats-related classes that need similar refactoring, and we are addressing them in priority order. This PR covers
RemoteTranslogTransferTracker.StatsandRemoteSegmentTransferTracker.Statsas part of that effort.Related Issues
Related to #19225
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.