-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: issue-19148 - bump commons-lang3, bcprov-jdk18on, bouncycastle #19155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue-19148 - bump commons-lang3, bcprov-jdk18on, bouncycastle #19155
Conversation
|
❌ Gradle check result for c1430e4: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5b04548 to
2a079dd
Compare
|
❌ Gradle check result for 2a079dd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2a079dd to
7e054a2
Compare
|
@cwperks @peternied the vulnerable versions are already updated in main branches and these are not updated in the 2.19 branch, thats why I have created the backport branch directly to 2.19. |
|
❌ Gradle check result for 7e054a2: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
|
@Archiit19 Thank you for submitting this. Sorry for the delay taking action until now. I'll take this over and push it through to completion. |
Signed-off-by: Archit Goyal <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
7e054a2 to
b1e32df
Compare
|
❌ Gradle check result for b1e32df: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b1e32df: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b1e32df: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Tests have failed twice now on org.opensearch.plugins.InstallPluginCommandTests.classMethod Given that bouncycastle is in this PR, may be some additional change needed. |
2f8177b to
f904953
Compare
|
❌ Gradle check result for f904953: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f904953 to
cf923b9
Compare
|
❌ Gradle check result for cf923b9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Daniel Widdis <[email protected]>
cf923b9 to
024b994
Compare
|
❌ Gradle check result for 024b994: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
The setting only prevents one of the two cleanup threads from starting; the other one always runs. Porting over the workaround from #19222.... |
Signed-off-by: Daniel Widdis <[email protected]>
|
❌ Gradle check result for f017ef0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.19 #19155 +/- ##
============================================
+ Coverage 72.02% 72.08% +0.05%
- Complexity 66027 66060 +33
============================================
Files 5341 5341
Lines 307273 307273
Branches 44845 44845
============================================
+ Hits 221320 221494 +174
+ Misses 67537 67327 -210
- Partials 18416 18452 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks a lot @dbwiddis, I have closed the related github issue as well. |
…pensearch-project#19155) * fix: security: bump commons-lang3, bcprov-jdk18on, bouncycastle Signed-off-by: Archit Goyal <[email protected]> * Update SHAs Signed-off-by: Daniel Widdis <[email protected]> * Bump bc-fips to 2.1.2 and set cleanup delay to 0 to fix tests Signed-off-by: Daniel Widdis <[email protected]> * Suppress Thread Leak warning on BouncyCastle daemon Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Archit Goyal <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]>
Description
Bump vulnerable dependencies to the fixed versions.
Related Issues
Resolves #19148
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.