chore: reenable skipped windows tests that were skipped in the meantime (#306)

* chore: reenable windows test that was fixed in the meantime

* chore: also reenable wasm tests

* chore: and also the page router tests

* chore: and also the cache handler tests

* chore: and also edge handler! this is getting better and better

* fix: place temp dirs on same drive

* chore: remove unused imports

* fix: skip one test

Author: Skn0tt

.github/workflows/run-tests.yml

@@ -107,3 +107,4 @@ jobs:
         run: npm run test:ci -- --shard=${{ matrix.shard }}
         env:
           NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
+          TEMP: ${{ github.workspace }}/..

tests/integration/build/copy-next-code.test.ts

@@ -7,7 +7,6 @@ import { copyNextServerCode } from '../../../src/build/content/server.js'
 import { PluginContext } from '../../../src/build/plugin-context.js'
 import { FixtureTestContext, createFsFixture } from '../../utils/fixture.js'
 import { readFile, readdir } from 'node:fs/promises'
-import { platform } from 'node:process'
 
 test<FixtureTestContext>('should copy the next standalone folder correctly for a simple site', async (ctx) => {
   const reqServerFiles = JSON.stringify({ config: { distDir: '.next' } })

tests/integration/cache-handler.test.ts

@@ -16,7 +16,6 @@ import {
   getBlobEntries,
   startMockBlobStore,
 } from '../utils/helpers.js'
-import { platform } from 'node:process'
 
 // Disable the verbose logging of the lambda-local runtime
 getLogger().level = 'alert'
@@ -35,7 +34,7 @@ beforeEach<FixtureTestContext>(async (ctx) => {
 })
 
 describe('page router', () => {
-  test.skipIf(platform === 'win32')<FixtureTestContext>('page router with static revalidate', async (ctx) => {
+  test<FixtureTestContext>('page router with static revalidate', async (ctx) => {
     await createFixture('page-router', ctx)
     console.time('runPlugin')
     await runPlugin(ctx)

tests/integration/edge-handler.test.ts

@@ -8,7 +8,6 @@ import {
 } from '../utils/fixture.js'
 import { generateRandomObjectID, startMockBlobStore } from '../utils/helpers.js'
 import { LocalServer } from '../utils/local-server.js'
-import { platform } from 'process'
 
 beforeEach<FixtureTestContext>(async (ctx) => {
   // set for each test a new deployID and siteID
@@ -19,11 +18,9 @@ beforeEach<FixtureTestContext>(async (ctx) => {
   await startMockBlobStore(ctx)
 })
 
-test.skipIf(platform === 'win32')<FixtureTestContext>(
-  'should add request/response headers',
-  async (ctx) => {
-    await createFixture('middleware', ctx)
-    await runPlugin(ctx)
+test<FixtureTestContext>('should add request/response headers', async (ctx) => {
+  await createFixture('middleware', ctx)
+  await runPlugin(ctx)
 
     const origin = await LocalServer.run(async (req, res) => {
       expect(req.url).toBe('/test/next')
@@ -50,11 +47,9 @@ test.skipIf(platform === 'win32')<FixtureTestContext>(
   },
 )
 
-test.skipIf(platform === 'win32')<FixtureTestContext>(
-  'should add request/response headers when using src dir',
-  async (ctx) => {
-    await createFixture('middleware-src', ctx)
-    await runPlugin(ctx)
+test<FixtureTestContext>('should add request/response headers when using src dir', async (ctx) => {
+  await createFixture('middleware-src', ctx)
+  await runPlugin(ctx)
 
     const origin = await LocalServer.run(async (req, res) => {
       expect(req.url).toBe('/test/next')
@@ -81,7 +76,7 @@ test.skipIf(platform === 'win32')<FixtureTestContext>(
   },
 )
 
-describe.skipIf(platform === 'win32')('redirect', () => {
+describe('redirect', () => {
   test<FixtureTestContext>('should return a redirect response', async (ctx) => {
     await createFixture('middleware', ctx)
     await runPlugin(ctx)
@@ -130,7 +125,7 @@ describe.skipIf(platform === 'win32')('redirect', () => {
   })
 })
 
-describe.skipIf(platform === 'win32')('rewrite', () => {
+describe('rewrite', () => {
   test<FixtureTestContext>('should rewrite to an external URL', async (ctx) => {
     await createFixture('middleware', ctx)
     await runPlugin(ctx)
@@ -190,12 +185,10 @@ describe.skipIf(platform === 'win32')('rewrite', () => {
   })
 })
 
-describe.skipIf(platform === 'win32')(
-  "aborts middleware execution when the matcher conditions don't match the request",
-  () => {
-    test<FixtureTestContext>('when the path is excluded', async (ctx) => {
-      await createFixture('middleware', ctx)
-      await runPlugin(ctx)
+describe("aborts middleware execution when the matcher conditions don't match the request", () => {
+  test<FixtureTestContext>('when the path is excluded', async (ctx) => {
+    await createFixture('middleware', ctx)
+    await runPlugin(ctx)
 
       const origin = await LocalServer.run(async (req, res) => {
         expect(req.url).toBe('/_next/data')
@@ -238,8 +231,8 @@ describe.skipIf(platform === 'win32')(
         functions: ['___netlify-edge-handler-middleware'],
         origin,
         url: '/foo',
-      })
-
+      })  
+      
       expect(await response1.text()).toBe('Hello from origin!')
       expect(response1.status).toBe(200)
       expect(response1.headers.has('x-hello-from-middleware-res')).toBeTruthy()
@@ -305,7 +298,7 @@ describe.skipIf(platform === 'win32')(
   },
 )
 
-describe.skipIf(platform === 'win32')('should run middleware on data requests', () => {
+describe('should run middleware on data requests', () => {
   test<FixtureTestContext>('when `trailingSlash: false`', async (ctx) => {
     await createFixture('middleware', ctx)
     await runPlugin(ctx)

tests/integration/page-router.test.ts

@@ -63,7 +63,7 @@ test<FixtureTestContext>('Should add pathname to cache-tags for pages route', as
   expect(staticFetch1.headers?.['netlify-cache-tag']).toBe('_N_T_/static/revalidate-manual')
 })
 
-test.skipIf(platform === 'win32')<FixtureTestContext>('Should revalidate path with On-demand Revalidation', async (ctx) => {
+test<FixtureTestContext>('Should revalidate path with On-demand Revalidation', async (ctx) => {
   await createFixture('page-router', ctx)
   await runPlugin(ctx)
 
@@ -115,14 +115,17 @@ test<FixtureTestContext>('Should return JSON for data req to page route', async
   expect(data.pageProps.show).toBeDefined()
 })
 
-test.skipIf(platform === "win32")<FixtureTestContext>('Should set permanent "netlify-cdn-cache-control" header on fully static pages"', async (ctx) => {
-  await createFixture('page-router', ctx)
-  await runPlugin(ctx)
+test.skipIf(platform === 'win32')<FixtureTestContext>(
+  'Should set permanent "netlify-cdn-cache-control" header on fully static pages"',
+  async (ctx) => {
+    await createFixture('page-router', ctx)
+    await runPlugin(ctx)
 
-  const response = await invokeFunction(ctx, {
-    url: '/static/fully-static',
-  })
+    const response = await invokeFunction(ctx, {
+      url: '/static/fully-static',
+    })
 
-  expect(response.headers?.['netlify-cdn-cache-control']).toBe('max-age=31536000')
-  expect(response.headers?.['cache-control']).toBe('public, max-age=0, must-revalidate')
-})
+    expect(response.headers?.['netlify-cdn-cache-control']).toBe('max-age=31536000')
+    expect(response.headers?.['cache-control']).toBe('public, max-age=0, must-revalidate')
+  },
+)

tests/integration/request-context.test.ts

@@ -18,7 +18,6 @@ import type { CacheHandler } from 'next/dist/server/lib/incremental-cache/index.
 import { SERVER_HANDLER_NAME } from '../../src/build/plugin-context.js'
 import { realpathSync } from 'node:fs'
 import { join } from 'node:path'
-import { platform } from 'node:process'
 
 // Disable the verbose logging of the lambda-local runtime
 getLogger().level = 'alert'
@@ -85,7 +84,7 @@ function spyOnRequestContext(ctx: FixtureTestContext) {
   return mockedRequestContextModule.getRequestContext
 }
 
-describe.skipIf(platform === 'win32')(
+describe(
   'request-context does NOT leak between concurrent requests',
   () => {
     test<FixtureTestContext>('pages router', async (ctx) => {

tests/integration/static.test.ts

@@ -18,7 +18,6 @@ import {
   getBlobEntries,
   startMockBlobStore,
 } from '../utils/helpers.js'
-import { platform } from 'node:process'
 
 // Disable the verbose logging of the lambda-local runtime
 getLogger().level = 'alert'

tests/integration/wasm.test.ts

@@ -11,7 +11,6 @@ import {
 } from '../utils/fixture.js'
 import { generateRandomObjectID, startMockBlobStore } from '../utils/helpers.js'
 import { LocalServer } from '../utils/local-server.js'
-import { platform } from 'node:process'
 
 // Disable the verbose logging of the lambda-local runtime
 getLogger().level = 'alert'
@@ -28,7 +27,7 @@ beforeEach<FixtureTestContext>(async (ctx) => {
   await startMockBlobStore(ctx)
 })
 
-describe.skipIf(platform === 'win32')('WASM', () => {
+describe('WASM', () => {
   beforeEach<FixtureTestContext>(async (ctx) => {
     // set for each test a new deployID and siteID
     ctx.deployID = generateRandomObjectID()