From 86c116dbf21d0384162da45b8fc7dd94d50adb33 Mon Sep 17 00:00:00 2001 From: PJC Date: Fri, 28 Aug 2020 10:42:13 +0900 Subject: [PATCH] fix: peerConnectionAddICECandidateAsync getString candidateMap.getString("sdpMid"); have a error because some of case sdpMid return null but peerConnectionAddICECandidateAsync function doesn't have exception handling to get sdpMid --- .../java/com/oney/WebRTCModule/WebRTCModule.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java index 26845ebfe..9a2187f2e 100644 --- a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java +++ b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java @@ -921,9 +921,19 @@ private void peerConnectionAddICECandidateAsync(ReadableMap candidateMap, PeerConnection peerConnection = getPeerConnection(id); Log.d(TAG, "peerConnectionAddICECandidate() start"); if (peerConnection != null) { + String sdpMid; + int sdpMLineIndex; + try { + sdpMid = candidateMap.getString("sdpMid"); + sdpMLineIndex = candidateMap.getInt("sdpMLineIndex"); + } catch (Exception e) { + Log.d("%s", String.valueOf(e)); + sdpMid = ""; + sdpMLineIndex = 0; + } IceCandidate candidate = new IceCandidate( - candidateMap.getString("sdpMid"), - candidateMap.getInt("sdpMLineIndex"), + sdpMid, + sdpMLineIndex, candidateMap.getString("candidate") ); result = peerConnection.addIceCandidate(candidate);