8269668: [aarch64] java.library.path not including /usr/lib64

[gnu-andrew]

The AArch64 DEFAULT_LIBPATH on OpenJDK 11 & 17 was adjusted back in July 2021 to include /usr/lib64 and /lib64, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions.

I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in /lib and /usr/libwill still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in /lib64 and /usr/lib64, where this would currently fail.

The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change JDK-8057109 in OpenJDK 9 and later) rather than breaking the indentation for the new lines.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8269668 needs maintainer approval

Issue

• JDK-8269668: [aarch64] java.library.path not including /usr/lib64 (Bug - P3 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/719/head:pull/719
$ git checkout pull/719

Update a local copy of the PR:
$ git checkout pull/719
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 719

View PR using the GUI difftool:
$ git pr show -t 719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/719.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269668: [aarch64] java.library.path not including /usr/lib64

Reviewed-by: sgehwolf, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• fad33c7: 8305072: Win32ShellFolder2.compareTo is inconsistent

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (642a6b21)

[gnu-andrew]

I don't see how this would break gc/logging/TestGCId.java on x86. Existing sporadic failure?

[jerboaa]

OK.

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

/approval request Fixes the DEFAULT_LIBPATH on AArch64 to be consistent with later JDKs. The risk is low as the additional directories are appended to the path, and will thus only change behaviour in existing situations where the libraries could not be found in /lib and /usr/lib. Patch was reviewed by Severin Gehwolf.

[openjdk]

@gnu-andrew
8269668: The approval request has been created successfully.