Skip to content

Conversation

@elifaslan1
Copy link

@elifaslan1 elifaslan1 commented Nov 11, 2025

Clean backport.Resolves al2023 fastdebug build failure. This double assignment causes undefined behavior.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8257709 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8257709: C1: Double assignment in InstructionPrinter::print_stack (Bug - P5 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/718/head:pull/718
$ git checkout pull/718

Update a local copy of the PR:
$ git checkout pull/718
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 718

View PR using the GUI difftool:
$ git pr show -t 718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/718.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 563b268c8f23a1f9f5e70065419d4e8661d1d0b4 8257709: C1: Double assignment in InstructionPrinter::print_stack Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 11, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2025

Webrevs

@elifaslan1
Copy link
Author

/approval request Clean backport.Resolves al2023 fastdebug build failure. This double assignment causes undefined behavior. GHA tested

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@elifaslan1
8257709: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 11, 2025
Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants